[jira] Created: (OFBIZ-327) I18N problem with "Inventory Receive" in german environment

[Nicolas Malin (Jira)]

I18N problem with "Inventory Receive" in german environment
-----------------------------------------------------------

                 Key: OFBIZ-327
                 URL: http://issues.apache.org/jira/browse/OFBIZ-327
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
         Environment: Linux and language locale "de_DE"
            Reporter: Markus Studer
            Priority: Trivial


It is not possible to receive inventory through purchase orders in a "german" language environment. The problem is receiveInventory.flt which assigns a I18N translated value to _rowSubmit_o_xxx (i.e. in my "german"-environment a letter "J").

As the ServiceMultiEventHandler Class accesses this value through:

  boolean rowSelected = request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i) == null ? false :
            "Y".equalsIgnoreCase(request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i));

this never matches in a non-english language environment and it is not possible to receive Inventory.

Solution: Directly assign "Y" to the _rowSubmit_o_xxx values in receiveInventory.flt (as it is done in other uses of _rowSubmit_o_

Patch:

--- /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (revision 449749)
+++ /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (working copy)
@@ -439,7 +439,7 @@
               </table>
             </td>
             <td align="right">
-              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="${uiLabelMap.CommonY}" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
+              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="Y" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
             </td>
           </tr>
           <#assign rowCount = rowCount + 1>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-327?page=all ]

Markus Studer updated OFBIZ-327:
--------------------------------

    Attachment: patch.txt

Patch file for this issue

(I do not exactly know how to create a valid patch file but still hope that it is usefull).

> I18N problem with "Inventory Receive" in german environment
> -----------------------------------------------------------
>
>                 Key: OFBIZ-327
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-327
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux and language locale "de_DE"
>            Reporter: Markus Studer
>            Priority: Trivial
>         Attachments: patch.txt
>
>
> It is not possible to receive inventory through purchase orders in a "german" language environment. The problem is receiveInventory.flt which assigns a I18N translated value to _rowSubmit_o_xxx (i.e. in my "german"-environment a letter "J").
> As the ServiceMultiEventHandler Class accesses this value through:
>   boolean rowSelected = request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i) == null ? false :
>             "Y".equalsIgnoreCase(request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i));
> this never matches in a non-english language environment and it is not possible to receive Inventory.
> Solution: Directly assign "Y" to the _rowSubmit_o_xxx values in receiveInventory.flt (as it is done in other uses of _rowSubmit_o_
> Patch:
> --- /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (revision 449749)
> +++ /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (working copy)
> @@ -439,7 +439,7 @@
>                </table>
>              </td>
>              <td align="right">
> -              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="${uiLabelMap.CommonY}" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
> +              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="Y" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
>              </td>
>            </tr>
>            <#assign rowCount = rowCount + 1>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-327?page=all ]

Jacques Le Roux reassigned OFBIZ-327:
-------------------------------------

    Assignee: Jacques Le Roux

> I18N problem with "Inventory Receive" in german environment
> -----------------------------------------------------------
>
>                 Key: OFBIZ-327
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-327
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux and language locale "de_DE"
>            Reporter: Markus Studer
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: patch.txt
>
>
> It is not possible to receive inventory through purchase orders in a "german" language environment. The problem is receiveInventory.flt which assigns a I18N translated value to _rowSubmit_o_xxx (i.e. in my "german"-environment a letter "J").
> As the ServiceMultiEventHandler Class accesses this value through:
>   boolean rowSelected = request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i) == null ? false :
>             "Y".equalsIgnoreCase(request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i));
> this never matches in a non-english language environment and it is not possible to receive Inventory.
> Solution: Directly assign "Y" to the _rowSubmit_o_xxx values in receiveInventory.flt (as it is done in other uses of _rowSubmit_o_
> Patch:
> --- /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (revision 449749)
> +++ /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (working copy)
> @@ -439,7 +439,7 @@
>                </table>
>              </td>
>              <td align="right">
> -              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="${uiLabelMap.CommonY}" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
> +              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="Y" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
>              </td>
>            </tr>
>            <#assign rowCount = rowCount + 1>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-327?page=all ]

Jacques Le Roux closed OFBIZ-327.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Markus,

Your patch is not exactly as expected but as it's so simple it's not a problem at all. If you want to submit patches in the future please take a look at : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

I verified there are no other problems like this one (was my - old now - fault ;o).

Commited in revision: 449817  

> I18N problem with "Inventory Receive" in german environment
> -----------------------------------------------------------
>
>                 Key: OFBIZ-327
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-327
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux and language locale "de_DE"
>            Reporter: Markus Studer
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: patch.txt
>
>
> It is not possible to receive inventory through purchase orders in a "german" language environment. The problem is receiveInventory.flt which assigns a I18N translated value to _rowSubmit_o_xxx (i.e. in my "german"-environment a letter "J").
> As the ServiceMultiEventHandler Class accesses this value through:
>   boolean rowSelected = request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i) == null ? false :
>             "Y".equalsIgnoreCase(request.getParameter(UtilHttp.ROW_SUBMIT_PREFIX + i));
> this never matches in a non-english language environment and it is not possible to receive Inventory.
> Solution: Directly assign "Y" to the _rowSubmit_o_xxx values in receiveInventory.flt (as it is done in other uses of _rowSubmit_o_
> Patch:
> --- /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (revision 449749)
> +++ /home/mast/.eclipse/ofbiz - Remote Repository/applications/product/webapp/facility/inventory/receiveInventory.ftl (working copy)
> @@ -439,7 +439,7 @@
>                </table>
>              </td>
>              <td align="right">
> -              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="${uiLabelMap.CommonY}" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
> +              <input type="checkbox" name="_rowSubmit_o_${rowCount}" value="Y" onclick="javascript:checkToggle(this, 'selectAllForm');"/>
>              </td>
>            </tr>
>            <#assign rowCount = rowCount + 1>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira