[jira] Created: (OFBIZ-3318) manual sales tax and item sales tax are not included in total amount on invoice

[Nicolas Malin (Jira)]

manual sales tax and item sales tax are not included in total amount on invoice
-------------------------------------------------------------------------------

                 Key: OFBIZ-3318
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
         Environment: http://demo.ofbiz.org
            Reporter: Willem Janssen


When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Janssen updated OFBIZ-3318:
----------------------------------

    Attachment: PO.png

Example of excluded tax amounts

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: PO.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788926#action_12788926 ]

Scott Gray commented on OFBIZ-3318:
-----------------------------------

The reason is because you haven't set a quantity so the tax amount is multiplied by zero.

My question to the community at large would be should we default quantities to 1 if no quantity is provided when creating an invoice item?

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: PO.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788960#action_12788960 ]

Jacques Le Roux commented on OFBIZ-3318:
----------------------------------------

+1 for 1 as default quantity, makes sense

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: PO.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788985#action_12788985 ]

Willem Janssen commented on OFBIZ-3318:
---------------------------------------

Thank you for looking into this.

Indeed the amount in the example is zero. If I remember correctly the tax amounts did add up to the total amount also with quantity zero. (perhaps 1-2 months ago).
When I try with quantity '1' the tax amount is not included in the total amount on the invoice so the amount of zero can not be the cause? (see 2nd screenprint)

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: PO.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Janssen updated OFBIZ-3318:
----------------------------------

    Attachment: PO_2.png

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: PO.png, PO_2.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788990#action_12788990 ]

Scott Gray commented on OFBIZ-3318:
-----------------------------------

Thanks for the update Willem, that'll teach me not to guess.

If you could provide the steps to reproduce I'll write a test case for the scenario when I get a chance.

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: PO.png, PO_2.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Janssen updated OFBIZ-3318:
----------------------------------

    Attachment: Create Purchase Invoice.doc

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: Create Purchase Invoice.doc, PO.png, PO_2.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789166#action_12789166 ]

Willem Janssen commented on OFBIZ-3318:
---------------------------------------

The steps to reproduce the issue are in the attached word doc.

I wanted to reproduce the same case with a sales invoice, but saw that there were no sales tax and item sales tax invoice item types available (actually a lot of item types are not present in the dropdown). Are those not provided anymore when creating a sales invoice?

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>         Attachments: Create Purchase Invoice.doc, PO.png, PO_2.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3318:
---------------------------------

    Assignee: Scott Gray

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>            Assignee: Scott Gray
>         Attachments: Create Purchase Invoice.doc, PO.png, PO_2.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-3318.
-----------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks for reporting Willem, fixed in r901070.

> manual sales tax and item sales tax are not included in total amount on invoice
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3318
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: http://demo.ofbiz.org
>            Reporter: Willem Janssen
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: Create Purchase Invoice.doc, PO.png, PO_2.png
>
>
> When manually adding item sales tax or sales tax on a purchase invoice or a sales invoice the amount of the tax is not included in the total amount of the invoice.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.