[jira] Created: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Nicolas Malin (Jira)
Restrict Canceled Financial Account operations in AR Payment screens.
---------------------------------------------------------------------

                 Key: OFBIZ-3337
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3337
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Surya Kusumakar
            Priority: Minor
             Fix For: SVN trunk


When we create Payment (Batch Payment) at find AR payment screen then deactivated bank account should not get displayed in Bank Account list.
Also add validation at service level so that deactivated(canceled/frozen) financial account cannot be assigned to batch.
On New payment screen deactivated fin account should not get displayed in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surya Kusumakar updated OFBIZ-3337:
-----------------------------------

    Attachment: Ofbiz_3337.patch

I have put checks at service and Ui level for validating the deactivated Financial Account at AR Payment screens .
Testing steps are as follows :

Scenario 1 :
1)Cancel/Frozen any of the Fin Account (https://localhost:8443/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING) by setting its status to Cancel/Set Manually Frozen.
2)Now go to Find Payments screen in AR https://localhost:8443/ar/control/findPayments.
3)Click on New Payment.
4)Select Fin Account Field.
    --> Expected Result : - It will not show inactive Fin Account.
    --> Actual Result : -      Working as expected.

Scenario 2 :
1)Now go to Find payments screen and then click on Batch Payments tab https://localhost:8443/ar/control/batchPayments.
2)Click on Find button.
3)Select few payments and select Create a batch option from select box.
   --> Expected Result : - It will not show inactive Fin Account.
   --> Actual Result : -      Working as expected.

Scenario 3 :
1)Remove check from batchPayments.ftl to validate this work.
2)Now go to Find payments screen and then click on Batch Payments tab https://localhost:8443/ar/control/batchPayments.
3)Click on Find button.
4)Select few payments and then select 'Create a batch' option from select box.
5)Select Fin Account which is in Inactive status.
6)Click on Run button.
   --> Expected Result : - Service will through Invalid status error.
   --> Actual Result : -      Working as expected.

--
Thanks
Surya Kusumakar

> Restrict Canceled Financial Account operations in AR Payment screens.
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3337
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3337
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Surya Kusumakar
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Ofbiz_3337.patch
>
>
> When we create Payment (Batch Payment) at find AR payment screen then deactivated bank account should not get displayed in Bank Account list.
> Also add validation at service level so that deactivated(canceled/frozen) financial account cannot be assigned to batch.
> On New payment screen deactivated fin account should not get displayed in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-3337:
----------------------------------

    Assignee: Vikas Mayur

> Restrict Canceled Financial Account operations in AR Payment screens.
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3337
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3337
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Surya Kusumakar
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: Ofbiz_3337.patch
>
>
> When we create Payment (Batch Payment) at find AR payment screen then deactivated bank account should not get displayed in Bank Account list.
> Also add validation at service level so that deactivated(canceled/frozen) financial account cannot be assigned to batch.
> On New payment screen deactivated fin account should not get displayed in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-3337:
-------------------------------

        Fix Version/s: Release Branch 10.04
    Affects Version/s: Release Branch 10.04

> Restrict Canceled Financial Account operations in AR Payment screens.
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3337
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3337
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Surya Kusumakar
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: Ofbiz_3337.patch
>
>
> When we create Payment (Batch Payment) at find AR payment screen then deactivated bank account should not get displayed in Bank Account list.
> Also add validation at service level so that deactivated(canceled/frozen) financial account cannot be assigned to batch.
> On New payment screen deactivated fin account should not get displayed in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-3337.
------------------------------

    Resolution: Fixed

Thanks Surya for reporting the bug, providing the patch and most importantly the testing steps.

A slight different version of your patch is in trunk rev. 950892 and release10.04 branch rev. 950896

> Restrict Canceled Financial Account operations in AR Payment screens.
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3337
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3337
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Surya Kusumakar
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: Ofbiz_3337.patch
>
>
> When we create Payment (Batch Payment) at find AR payment screen then deactivated bank account should not get displayed in Bank Account list.
> Also add validation at service level so that deactivated(canceled/frozen) financial account cannot be assigned to batch.
> On New payment screen deactivated fin account should not get displayed in the list.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Closed: (OFBIZ-3337) Restrict Canceled Financial Account operations in AR Payment screens.

Surya Kusumakar-2
Thanks Vikas for committing the patch.

--
Regards
Surya Kusumakar


On Jun 3, 2010, at 12:52 PM, Vikas Mayur (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/OFBIZ-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Vikas Mayur closed OFBIZ-3337.
> ------------------------------
>
>    Resolution: Fixed
>
> Thanks Surya for reporting the bug, providing the patch and most importantly the testing steps.
>
> A slight different version of your patch is in trunk rev. 950892 and release10.04 branch rev. 950896
>
>> Restrict Canceled Financial Account operations in AR Payment screens.
>> ---------------------------------------------------------------------
>>
>>                Key: OFBIZ-3337
>>                URL: https://issues.apache.org/jira/browse/OFBIZ-3337
>>            Project: OFBiz
>>         Issue Type: Bug
>>         Components: accounting
>>   Affects Versions: Release Branch 10.04, SVN trunk
>>           Reporter: Surya Kusumakar
>>           Assignee: Vikas Mayur
>>           Priority: Minor
>>            Fix For: Release Branch 10.04, SVN trunk
>>
>>        Attachments: Ofbiz_3337.patch
>>
>>
>> When we create Payment (Batch Payment) at find AR payment screen then deactivated bank account should not get displayed in Bank Account list.
>> Also add validation at service level so that deactivated(canceled/frozen) financial account cannot be assigned to batch.
>> On New payment screen deactivated fin account should not get displayed in the list.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>