[jira] Created: (OFBIZ-3371) FinAccountHelper.getBalance attempts to filter withdrawl transactions by currency

[Nicolas Malin (Jira)]

FinAccountHelper.getBalance attempts to filter withdrawl transactions by currency
---------------------------------------------------------------------------------

                 Key: OFBIZ-3371
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3371
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Bob Morley
            Priority: Critical


The getBalance method sets up two entity condition lists; one for increases and one for decreases.  The decrease list has a condition on the currencyUomId against the "FinAccountTransSum" view-entity.  This entity does not have a currency (in fact currency is set on the financial acocunt itself, and not the transactions which _must_ be in that currency.  I have simply removed the offending line and cleaned up the method a little bit (generics violations, un-used variables).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3371:
------------------------------

    Attachment: OFBIZ-3371_Invalid_Filtering_Of_Withdrawl_Transactions_By_Currency.patch

> FinAccountHelper.getBalance attempts to filter withdrawl transactions by currency
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3371
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3371
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Priority: Critical
>         Attachments: OFBIZ-3371_Invalid_Filtering_Of_Withdrawl_Transactions_By_Currency.patch
>
>
> The getBalance method sets up two entity condition lists; one for increases and one for decreases.  The decrease list has a condition on the currencyUomId against the "FinAccountTransSum" view-entity.  This entity does not have a currency (in fact currency is set on the financial acocunt itself, and not the transactions which _must_ be in that currency.  I have simply removed the offending line and cleaned up the method a little bit (generics violations, un-used variables).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3371:
---------------------------------

    Assignee: Scott Gray

> FinAccountHelper.getBalance attempts to filter withdrawl transactions by currency
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3371
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3371
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Scott Gray
>            Priority: Critical
>         Attachments: OFBIZ-3371_Invalid_Filtering_Of_Withdrawl_Transactions_By_Currency.patch
>
>
> The getBalance method sets up two entity condition lists; one for increases and one for decreases.  The decrease list has a condition on the currencyUomId against the "FinAccountTransSum" view-entity.  This entity does not have a currency (in fact currency is set on the financial acocunt itself, and not the transactions which _must_ be in that currency.  I have simply removed the offending line and cleaned up the method a little bit (generics violations, un-used variables).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-3371.
-----------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Bob, I've committed the fix in r899860 and the generics markup in r899861

> FinAccountHelper.getBalance attempts to filter withdrawl transactions by currency
> ---------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3371
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3371
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Scott Gray
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3371_Invalid_Filtering_Of_Withdrawl_Transactions_By_Currency.patch
>
>
> The getBalance method sets up two entity condition lists; one for increases and one for decreases.  The decrease list has a condition on the currencyUomId against the "FinAccountTransSum" view-entity.  This entity does not have a currency (in fact currency is set on the financial acocunt itself, and not the transactions which _must_ be in that currency.  I have simply removed the offending line and cleaned up the method a little bit (generics violations, un-used variables).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.