[jira] Created: (OFBIZ-3374) UI upgrade, new lookups

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794779#action_12794779 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

Hi Sascha,

Looks great, sorry I have no time right now to look at it closerly. Hopefully Bruno will do.
I'm verry happy with that, it will make OFBiz more "professional" (at least for PHB ;o)

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

hi Jacques, hi Bruno

i hope u had a few nice x-mas days.
here my first rc.

CSS bug fixed and everything works fine in FF and IE 8/7. :-)

So long
Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795033#action_12795033 ]

Bruno Busco commented on OFBIZ-3374:
------------------------------------

Hi Sascha,
I have looked at your latest patch.

Few comments:
1) Are we sure we can commit the resize.js file as it is? There is a license note that I do not know if is compatible with the Apache. I would like others to check at least thi file in the patch.
2) To check that a section is empty there is now the tag <if-empty-section section-name="body"/> you should use instead of <if-empty field="sections.body"/>
3) There are some conflict with the latest trunk
4) Generally to get the review simpler is better to remove all the formatting changes (there are lots of trailing spaces removal)
5) Where and which gif file need to be added to let the patch work?

Thank you Sascha for the continued effort with this but I try to do my best to avoid wrong things committed. I hope you understand.

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795126#action_12795126 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

HI Bruno, Sascha,

1) We already have a notice about Thomas Fuchs's works  in the NOTICE file so it's OK.
4) True, but on the other hand, we should not have any trailing spaces :/ Adam and I have struggled against them many times, but they always creep in again :) Actually it's hard to avoid them, notably on new lines, etc. And most of them in this patch are from new lines...
5) From the patch wr.png, header_close_button.png and header_bg.gif are needed, so it's looks like wr.png is missing.

Thanks guys!

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

Hey,

sorry for the late update (yersterday was birthday time, i took a little freetime to celebrate :-))
the patch is updated.
 - I try to delete all not needed spaces, i hope now it's simpler to review.
 - The conflicts are solved.
 - image location: Both images (heade_close_button.png, header_bg.gif) should copied in the folders:
      /themes/bizznestime/webapp/bizznestime/images/
      /themes/bluelight/webapp/bluelight/images/
     /themes/droppingcrumbs/webapp/droppingcrumbs/images/
     /themes/flatgrey/webapp/flatgrey/
(Jacques there is no wr.png in my Patch:-))

Bruno no problem, i understand your point :-)
(If there are any points i can do better/ create patches with higher quality... let me now.. :-))

So long
Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795374#action_12795374 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

Hi Sascha,

Right, I found this line
    +    background:url(../images/wr.png) top right no-repeat;
And did not check: it was already in trunk. It was only a white space change which makes popup this line

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

 - the position is no configurable
 - one IE 6/7 bug with pagination is fixed

so long
Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797835#action_12797835 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

Hi Sascha,

Hopefully I will have a look this weekend, if nobody beat me on it...

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

Hehe Jacques ok,

i attached a new patch file, there were some css updates this week. Which causes conflicts.

Have a nice WE
Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups-OFBIZ-3374.patch

An updated patch without conflicts. I just changed a word in widget-form.xsd: width instead of weight. I tried to use this new feature but did not find enought time tonight for that. Hopefully tomorrow...
BTW a little tuto on how to use it would be great (even better: an example in https://localhost:8443/example/control/FormWidgetExamples). I will try if I find enough time...

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798434#action_12798434 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

Mmm, it seems my patch is the same than Sascha but the word I changed. I maybe got conflicts for another reason, most possible: it's late ;)

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798468#action_12798468 ]

Sascha Rodekamp commented on OFBIZ-3374:
----------------------------------------

Hi Jacques, thanks for testing, i will have a look tomorrow morning and create an example...

have a nice day
Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

Hi Jacques,

so i added an example in [https://localhost:8443/example/control/FormWidgetExamples]
and fixed the conflicts from tha latest updates.

So long Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801173#action_12801173 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

Hi Sascha,

I just tried but get an error after an "ant clean build run"? I don't see any data to load, did you test your last patch? May I miss something?

Thanks

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookups.patch

Hi,

i haven't any problems during ant clean/ build.

After may last patch file there where a few updates in the trunk which evoked conflicts.
The new file should solve them.

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801698#action_12801698 ]

Sascha Rodekamp commented on OFBIZ-3374:
----------------------------------------

BTW Jacques,
i don't need any data to be load.
I tested the patch one more time and ... what should i say ... no problems with the latest trunk :-)

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801720#action_12801720 ]

Jacques Le Roux commented on OFBIZ-3374:
----------------------------------------

Thanks Sascha,

I will have a fresh look this afternoon. When I tried to use Example I got an error loading the Widget page (missing something said the message, as I had not much time I gave up)

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3374:
-----------------------------------

    Attachment: lookup.jpg

Hi Jacques,
i dt no why but i haven't any trouble with the patch i applied it one more time, go to the examples screen and called the lookup... no problem see screenshot

hmm... interesting :-)

Cu
Sascha

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801873#action_12801873 ]

Bruno Busco commented on OFBIZ-3374:
------------------------------------

Hi Sascha,
did you try with a fresh checkout?

> UI upgrade, new lookups
> -----------------------
>
>                 Key: OFBIZ-3374
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3374
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch
>
>
> Hi,
> regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields.
> They shouldn't open in a page layer instead of a seperate windows.
> My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows?
> Should i follow this idea, any suggestions?
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.