|
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802134#action_12802134 ] Sascha Rodekamp commented on OFBIZ-3374: ---------------------------------------- Hey Brund, Hey Jacques, yes i checked the patch in a fresh checkout! > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802182#action_12802182 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- Hi Sascha, I just tried, no problems to apply the patch, the example with normal style works well on XP with FF3.5, Opera and IE8 but the example with center style does not work at all (nothing appears in any browsers). Could you have a look please ? Thanks > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802211#action_12802211 ] Sascha Rodekamp commented on OFBIZ-3374: ---------------------------------------- Hm it worked, but the lookup will apear in the center top of the page. I have to improve the positining, maybe i can implement a better positioning in the next release? > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802285#action_12802285 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- When you say it worked you mean at some point earlier right? What do you mean exactly by next release? > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802292#action_12802292 ] Sascha Rodekamp commented on OFBIZ-3374: ---------------------------------------- No everything should work fine in my last patch from the 2010-01-18. I tested this patch in a fresh checkout... no problems. I mean in a next step to improve the lookup, maybe there are some other ideas which can be implemented. This patch make a lot more work as expected, thanks for your patiences :-) > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3374: ----------------------------------- Attachment: lookups.patch now the lookup is centered relative to the scrollbar position ;) > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802369#action_12802369 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- Thanks Sascha, It works well indeed. I will commit it soon and I agree that some new ideas may come up. For instance I wonder if instead of showing/hiding using only the lookup icon we should not allow to hide simply by clicking out of the lookup area, like the calendar works for instance. Anyway it's good enough for testing on a higher level. I will commit as is for the moment and I will ask the community to try to use this feature not only in example. Good job! > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802407#action_12802407 ] Sascha Rodekamp commented on OFBIZ-3374: ---------------------------------------- Hey Jacques, thanks. yes good point i write it on my list :-) i'm alittle bit busy in the next days (project stuff) but i think there will be a little bit freetime at the weekend. Have a nice day Sascha > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3374. ---------------------------------- Resolution: Fixed Assignee: Jacques Le Roux Thanks Sascha, Commited in trunk at r900950 For enhancements, if any, we will open a new issue Thank you Bruno for testing and comments. > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-3374: ------------------------------------ I had to revert at r901197, because it introduces a bad side-effect when using a lookup by name, at least as far as I can tell. > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802853#action_12802853 ] Sascha Rodekamp commented on OFBIZ-3374: ---------------------------------------- hm side-effect? what happend? > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802938#action_12802938 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- Hi Sascha, In a custom project I'm working on, we use "lookups by name" and we use the trunk. Those lookups work like the ordinary lookups, but on return they show the name of the object looked up instead of its Id (most of the time, users prefer to see names than Ids). For that we use also an hidden field where we put the Id (the hidden field has the same name than the description-field-name). When I updated the project and tested I got an error with this patch. The error appears in the fieldLookup2 (in fieldlookup.js) because obj_target2.value == null (it's the last error message). I hope to have a closer look tonight to see if it's relate to custom code or not. I will let you know as soon as I get more information... Chris Snow also reported an issue with the Calendar on user ML but I'm not sure it's related. > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802949#action_12802949 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- Also if you try, for instance, to search a party group containing a string or a letter and hit enter the lookup surprinsigly closes > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802963#action_12802963 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- To complete about the "lookups by name". There are essentially the same apart that they render not only one parameter but 2. ie the hyperlink instead of being for intance <hyperlink also-hidden="false" target-type="plain" description="${partyId}" target="javascript:set_value('${partyId}')"/> is something like <hyperlink also-hidden="false" target-type="plain" description="${partyId}" target="javascript:set_values('${personName}','${partyId}')"/> There is of course a row-actions block above to create the personName value {code} <row-actions> <entity-one entity-name="Enumeration" value-field="salutationDescription"> <field-map field-name="enumId" from-field="salutation"/> </entity-one> <set field="personName" value="${salutationDescription.description} ${firstName} ${middleName} ${lastName} ${suffix}"/> </row-actions> {code} So it seems that there is something wrong when returning the second parameter (here partyId) > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3374: ----------------------------------- Attachment: lookups.patch Hi Jacques, so i had a look at the "lookups by name" issue. In the standard ofbiz it is used in the facility module https://localhost:8443/facility/control/EditFacility. What should i say, worked without promblems. I only can reconstruct your problem when i use the wrong decorator. In the attached patch i changed the second input field in the example lookup in a "lookup layer by name" Maybe u uses the new LookupPopupLayerDecorator instead of the LookupDecorator for your Lookup. The original Lookups wouldn't work with the new decorator. Conclusion: Lookup By Name, using set_values(), works without problems in the original and the new Lookup layout. Have a nice day :) Sascha > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804307#action_12804307 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- Hi Sascha, Yes, I agree it works well in the trunk. Except this issue I already reported: if you enter some characters in a zone to search (for instance some letters of the 1st name) and hit enter the lookup closes and nothing happens. Also, I have still this issue in the custom code (ok in trunk), I hope to see that this week... > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3374: ----------------------------------- Attachment: lookups-OFBIZ-3374.patch I attach a new patch, WIP, not intended for inclusion, more for myself actually... > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3374: ----------------------------------- Attachment: lookups.patch Hi Jacques, i fixed the Enter-Button Problem. When you now type some chars in the input field and press enter, you will see the expected behaviour. So long Sascha > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804981#action_12804981 ] Jacques Le Roux commented on OFBIZ-3374: ---------------------------------------- Thanks Sascha, I hope to have a look this week, else weekend > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3374. ---------------------------------- Resolution: Fixed Hi Sascha, I have finally commited your work at r904047 I find that the positioning mechanism is only working with the bizznesstime theme (at list centering, the only case I tried with all themes). But it should not be a big deal to fix since it works already in one theme. I have created a new issue for that OFBIZ-3430 Thanks > UI upgrade, new lookups > ----------------------- > > Key: OFBIZ-3374 > URL: https://issues.apache.org/jira/browse/OFBIZ-3374 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: header_bg.gif, header_close_button.png, lookup.jpg, lookup.jpg, lookup2.jpg, lookups-OFBIZ-3374.patch, lookups-OFBIZ-3374.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch, lookups.patch > > > Hi, > regarding to this articel: [here|http://cwiki.apache.org/confluence/display/OFBADMIN/New+Features+Roadmap+-+Living+Document#NewFeaturesRoadmap-LivingDocument-Quickeranintuitiveaccesstobasicfunctionnalities%28creation,etc.%29] I decided to improve the lookup fields. > They shouldn't open in a page layer instead of a seperate windows. > My Patch contains a prototype (not a final patch), so what do you think about the new lookup windows? > Should i follow this idea, any suggestions? > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
| Free forum by Nabble | Edit this page |
