[jira] Created: (OFBIZ-3379) Email sending process using one connection for To/CC/BCC causing issues

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795241#action_12795241 ]

Pranay Pandey commented on OFBIZ-3379:
--------------------------------------

Thanks Scott, I will test the patch uploaded by you and will post the results here.

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-3379:
------------------------------

    Attachment: OFBIZ-3379.patch

Updated patch for testing, prevents infinite recursion when the failure notification also fails to be sent

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795816#action_12795816 ]

Scott Gray commented on OFBIZ-3379:
-----------------------------------

If there are no objections I'll likely commit this patch in the next day or so, here's are summary of the changes in case anyone hasn't been following closely:
- Emails will now be sent to any valid recipients even if the SMTP server rejected any invalid ones.  This can be turned off if desired in general.properties and also on a per service call basis.
- A failure notification will be sent to the email's "from" address, listing the failed recipients and the reason for each failure.  The notification can be turned off by setting the sendFailureNotification parameter to false in the service context.  If a failure notification is sent then the service will return success even if there were failures (this prevents async calls from retrying and multiple failure notifications being sent).

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795864#action_12795864 ]

Tim Ruppert commented on OFBIZ-3379:
------------------------------------

Ruth, this is a good example of there being a REAL problem and addressing that problem directly - which, in the real world, is how bugs are found and problems are solved - real customers, real problems - not just trying to think like someone else might be thinking.

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795865#action_12795865 ]

Tim Ruppert commented on OFBIZ-3379:
------------------------------------

Scott, thanks for taking the extra time to abstract all of this so that everyone can have anything configured however they like.  Please commit this fix so that the issues this has caused can be fixed for the entire community.

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795867#action_12795867 ]

Ruth Hoffman commented on OFBIZ-3379:
-------------------------------------

Tim:
Really? And what was that problem? Email wasn't "broken". The process by which OFBiz sends notification - using email - does not work the way the original developers had intended.

On another note: Don't waste your time presuming to lecture me on problem solving techniques. I've been working with computers and software since before Al Gore invented the internet :-) if, on the other hand you feel compelled to vent because you don't agree with me, well then by all means - go for it!

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795868#action_12795868 ]

Tim Ruppert commented on OFBIZ-3379:
------------------------------------

Read the subject and description of the error - they describe EXACTLY what the real world problem was and provide a solution for it.  Thru the community process, and as a result of one of your comments, the original fix was improved to have more flexibility to allow people to configure if they don't want to get emails addressed to them (if there are other issues).  So, as I stated earlier, the way that OFBiz sends notifications WAS broken for the way many customers use it - and yes it has now been fixed.

On your other note - just because you've been doing it for a long time doesn't mean that you do it right - not now and no guarantee about then.  But, at least you're now putting comments related to JIRA tasks in JIRA - instead of in email - so I guess we can all take that as a bonus and moving in the right direction together!  Just follow the processes and be a part of intelligent communication in the projects and everyone will continue to be happy with your contributions.

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-3379.
-----------------------------

       Resolution: Fixed
    Fix Version/s:     (was: Release Branch 9.04)

Thanks all, fixed in trunk r896213

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reopened OFBIZ-3379:
-------------------------------

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-3379:
------------------------------

    Attachment: OFBIZ-3379-2.patch

Pranay, if you get a chance could you please test this patch which addresses Adam's concerns about using Sun's SMTP classes?  No rush, whenever you have time would be great.

Thanks
Scott

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3379-2.patch, OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805829#action_12805829 ]

Pranay Pandey commented on OFBIZ-3379:
--------------------------------------

Sure Scott, I will test it and will get back to you soon.

Thanks
--
Pranay Pandey

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3379-2.patch, OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841185#action_12841185 ]

Pranay Pandey commented on OFBIZ-3379:
--------------------------------------

Hi Scott,

Sorry for late reply.
Thanks for the patch. I tested the patch given by you and it worked well except one issue that I found while calling sendMailMultiPart(in sendFailureNotification method) with newContext  in which missing bodyPart gives service validation error.

Please let me know if you have any questions.

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3379-2.patch, OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841185#action_12841185 ]

Pranay Pandey edited comment on OFBIZ-3379 at 3/4/10 11:13 AM:
---------------------------------------------------------------

Hi Scott,

Sorry for late reply.
Thanks for the patch. I tested the patch given by you and it worked well except one issue that I found while calling sendMailMultiPart(in sendFailureNotification method) with newContext  in which missing bodyPart gives service validation error. This is from the last patch on the issue OFBIZ-3379-2.patch.

Please let me know if you have any questions.

      was (Author: pandeypranay):
    Hi Scott,

Sorry for late reply.
Thanks for the patch. I tested the patch given by you and it worked well except one issue that I found while calling sendMailMultiPart(in sendFailureNotification method) with newContext  in which missing bodyPart gives service validation error.

Please let me know if you have any questions.
 

> Email sending process using one connection for To/CC/BCC causing issues
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3379
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3379
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Pranay Pandey
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3379-2.patch, OFBIZ-3379.patch, OFBIZ-3379.patch, OFBIZ-3379.patch
>
>
> Typically BCCs are handled via the sending mail client. That is, when the client sees a BCC in an email, it will open up two connections to the mail server, the first for the To/CC fields, the second for BCC fields, this way the addresses are masked from the headers and there is that layer of anonymity that BCC is used for.
> What appears to be happening is that OFBiz is sending all of the information in one connection to the mail server and having the mail server sort out the details. So when sendTo encountering an invalid email, and then terminating the remaining execution of the outgoing process and no email sent to BCC address which is usually going to be a valid address from email settings for the company.
> To fix the issue, we need to send this via two connection to mail client.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.