[jira] Created: (OFBIZ-3381) Update of the geolocation screen in party
Locked
[jira] Created: (OFBIZ-3381) Update of the geolocation screen in party
 
|
Update of the geolocation screen in party
----------------------------------------- Key: OFBIZ-3381 URL: https://issues.apache.org/jira/browse/OFBIZ-3381 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: SVN trunk Reporter: Erwan de FERRIERES Fix For: SVN trunk This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3381) Update of the geolocation screen in party
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-3381: -------------------------------------- Attachment: OFBIZ-3381.diff > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794548#action_12794548 ] Bruno Busco commented on OFBIZ-3381: ------------------------------------ Erwan, there are two things I do not like in the patch: 1) (minor) Since we have the PartyGeoLocation.groovy script executed I would move all the <set...> stuff in there and have a complete geoChart valorization in the groovy. 2) (major) In the geolocation.ftl I would not include this: {code} <#if point.partyId?has_content> marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=<@ofbizUrl>viewprofile?partyId=${point.partyId}</@ofbizUrl>>${uiLabelMap.PartyProfile} ${uiLabelMap.CommonOf} ${point.partyId}</a></div>"); </#if> {code} because it introduces a (soft) framework dependance from the Party component. I would replace it with a more generic: {code} <#if point.link?has_content> marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=${point.link.url}>${point.link.label}</a></div>"); </#if> {code} BTW: I only watched at the code. I did not succeded to show any map screen even for the DemoCustomer. I always get the "No Geolocation Available (for a demo you may try using DemoCustomer party profil)" message. > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794548#action_12794548 ] Bruno Busco edited comment on OFBIZ-3381 at 12/26/09 8:24 AM: -------------------------------------------------------------- Erwan, there are two things I do not like in the patch: 1) (minor) Since we have the PartyGeoLocation.groovy script executed I would move all the <set...> stuff in there and have a complete geoChart valorization in the groovy. 2) (major) In the geolocation.ftl I would not include this: {code} <#if point.partyId?has_content> marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=<@ofbizUrl>viewprofile?partyId=${point.partyId}</@ofbizUrl>>${uiLabelMap.PartyProfile} ${uiLabelMap.CommonOf} ${point.partyId}</a></div>"); </#if> {code} because it introduces a (soft) framework dependance from the Party component. I would replace it with a more generic: {code} <#if point.link?has_content> marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=${point.link.url}>${point.link.label}</a></div>"); </#if> {code} was (Author: bruno.busco): Erwan, there are two things I do not like in the patch: 1) (minor) Since we have the PartyGeoLocation.groovy script executed I would move all the <set...> stuff in there and have a complete geoChart valorization in the groovy. 2) (major) In the geolocation.ftl I would not include this: {code} <#if point.partyId?has_content> marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=<@ofbizUrl>viewprofile?partyId=${point.partyId}</@ofbizUrl>>${uiLabelMap.PartyProfile} ${uiLabelMap.CommonOf} ${point.partyId}</a></div>"); </#if> {code} because it introduces a (soft) framework dependance from the Party component. I would replace it with a more generic: {code} <#if point.link?has_content> marker.openInfoWindowHtml("<div style=\"width:210px; padding-right:10px;\"><a href=${point.link.url}>${point.link.label}</a></div>"); </#if> {code} BTW: I only watched at the code. I did not succeded to show any map screen even for the DemoCustomer. I always get the "No Geolocation Available (for a demo you may try using DemoCustomer party profil)" message. > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794892#action_12794892 ] Erwan de FERRIERES commented on OFBIZ-3381: ------------------------------------------- Hi Bruno, Thanks for the comments, I will look into it ! > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794932#action_12794932 ] Jacques Le Roux commented on OFBIZ-3381: ---------------------------------------- Hi Erwan, I don't know if it's your intent but I also used the geolocation on fixed asset and facilities. Maybe you could have a look while at it? > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795092#action_12795092 ] Erwan de FERRIERES commented on OFBIZ-3381: ------------------------------------------- Hi Jacques, this is was my intent, but I hadn't yet search for other screens to update. Thanks for pointing them. I'm a bit busy this week, but I will take a look at it next week ! Cheers, > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795095#action_12795095 ] Jacques Le Roux commented on OFBIZ-3381: ---------------------------------------- Thanks Erwan, Cheers > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-3381: ----------------------------------------- Assignee: Erwan de FERRIERES > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-3381: -------------------------------------- Attachment: OFBIZ-3381.diff a new version of the patch > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff, OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-3381: -------------------------------------- Attachment: OFBIZ-3381.diff patch with modifications on party, fixedasset and facility geolocations. > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff, OFBIZ-3381.diff, OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798505#action_12798505 ] Bruno Busco commented on OFBIZ-3381: ------------------------------------ Erwan, I agree perfectly with the idea in the patch. Comments: 1) The FacilityLocationGeoLocation.ftl and PartyLocationGeoLocation.ftl should then be eliminated 2) What is "fa = delegator.findByPrimaryKey("FixedAsset", UtilMisc.toMap("fixedAssetId", fixedAssetId)); in FixedAssetGeoLocation.groovy" used for? 3) In partymgr on DemoCustomer1 clicking on https://localhost:8443/partymgr/control/PartyGeoLocation?partyId=DemoCustomer1 I get an error: org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://party/widget/partymgr/PartyScreens.xml#PartyGeoLocation]: java.lang.NullPointerException: Cannot get property 'latitude' on null object (Cannot get property 'latitude' on null object) I quickly applied the patch. I don't know if I did some mistake. Apart from this comments I agrre to have this committed. > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff, OFBIZ-3381.diff, OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800266#action_12800266 ] Erwan de FERRIERES commented on OFBIZ-3381: ------------------------------------------- 2) "fa = delegator.findByPrimaryKey("FixedAsset", UtilMisc.toMap("fixedAssetId", fixedAssetId)); is used to get the fixedAsset name, and then display it in the map link 3) I forgot one test, I will add it. > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff, OFBIZ-3381.diff, OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3381) Update of the geolocation screen in party
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3381. ------------------------------------- Resolution: Fixed Included at rev. 899560 > Update of the geolocation screen in party > ----------------------------------------- > > Key: OFBIZ-3381 > URL: https://issues.apache.org/jira/browse/OFBIZ-3381 > Project: OFBiz > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: OFBIZ-3381.diff, OFBIZ-3381.diff, OFBIZ-3381.diff > > > This will allow to use the new geoChart screen introduced by Bruno instead of the geoLocation screen, and then have less javascript calls. > I put this as a JIRA issue to have your comments and be sure that this meet OFBiz requirements. > if it's OK, I will then commit it to the trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |