[jira] Created: (OFBIZ-3425) Extend getPropertyNumber, Defualt Value

[Nicolas Malin (Jira)]

Extend getPropertyNumber, Defualt Value
---------------------------------------

                 Key: OFBIZ-3425
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Sascha Rodekamp
             Fix For: SVN trunk
         Attachments: getPropertyNumberDefaultValue.patch

Hi,

i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.

Have a nice Day
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3425:
-----------------------------------

    Attachment: getPropertyNumberDefaultValue.patch

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3425.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Sascha,

Your patch is in trunk at r903197  

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805006#action_12805006 ]

Sascha Rodekamp commented on OFBIZ-3425:
----------------------------------------

Thanks Jacques,

hava a nice day

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-3425:
------------------------------------


Hi Sascha,

Adam remarked on the dev ML that your patch was not well formatted and especially asked why you used a Double instead of a double as parameter?

For formatting have a look at coding conventions in [Contributors Best Practices|http://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]

In you case, mostly spaces after and before  if and {, but anyway read the document on [coding conventions|http://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions]

Then please submit another patch. Obviously I'd been easier for me to do it (and I could have done it when I commited your patch, if I had spotted them) but as says the proverb "It's better to learn somebody to fish then to give him a fish" ;)

Thanks

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3425:
-----------------------------------

    Attachment: OFBIZ-3425_getPropertyNumberDefaultValue.patch

Hi Jacques,

i updated my patch, sorry for the bad formatting, i missed the extra space :-(

Hopefully it fill fit the conventions now.

So long
Sascha

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3425.
----------------------------------

    Resolution: Fixed

Hi Sascha,

Actually your last patch (OFBIZ-3425_getPropertyNumberDefaultValue.patch) still miss the right spacing. But anyway, I had a look at the class and I formatted getPropertyNumber as is getPropertyValue.

This is still questionnable if you look at the Sun conventions. They do not allow exceptions with the "brackets around blocks rule". But in OFBiz you will see some places where it's actually done. Like for instance in getPropertyValue from where I copied the formatting to format getPropertyNumber. I have asked that, and the convention in the OFBiz community is to bypass this rule in low level tools, where you are sure nothing will change later. Some break it also elsewhere, but I'd not recommend it.

In other word, please read carefully the Sun coding conventions document when you get chances and try to follow them as much as possible. Most of the time you will find good examples around the code you are changing. For instance here, you would have just followed how getPropertyValue  was formatted.

Commited at r903571

Thanks for your effort

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805434#action_12805434 ]

Sascha Rodekamp commented on OFBIZ-3425:
----------------------------------------

Hi Jacques,

ok thanks. Next time i look twice to observe the rules!!

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805858#action_12805858 ]

Jacques Le Roux commented on OFBIZ-3425:
----------------------------------------


Sascha, FYI: finally Adam did it better at r903766

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805860#action_12805860 ]

Sascha Rodekamp commented on OFBIZ-3425:
----------------------------------------

Yep Jacques i saw, he really did, i hadn't thought of this problem.

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805928#action_12805928 ]

Jacques Le Roux commented on OFBIZ-3425:
----------------------------------------

Nor mine I must say. Adam is a real Java expert!

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805932#action_12805932 ]

Sascha Rodekamp commented on OFBIZ-3425:
----------------------------------------

thats good for me. so i have the best cahnges to learn from my mistakes

> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
>                 Key: OFBIZ-3425
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3425
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: getPropertyNumberDefaultValue.patch, OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods, maybe it can help.
> Have a nice Day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.