Allow to open a layer lookup from a layer lookup
------------------------------------------------ Key: OFBIZ-3446 URL: https://issues.apache.org/jira/browse/OFBIZ-3446 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Jacques Le Roux -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3446: ----------------------------------- Description: This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around Priority: Blocker (was: Major) > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Blocker > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841725#action_12841725 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- A good example (and maybe the sole, not sure yet) is LookupWorkEffort. I created a LookupWorkEffortPopup but LookupWorkEffort is used all around in OFBiz. (72 instances of "LookupWorkEffort") I also wonder if we should not implement something to call a lookup with the "component:..." syntax from target-form-name than handling that in controllers (duplications). Maybe it already works but I did not try nor find an example of usage in OFBiz, to be revisited... > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Blocker > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3446: ----------------------------------- Description: This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. was:This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Blocker > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray updated OFBIZ-3446: ------------------------------ Priority: Major (was: Blocker) Downgraded priority from Blocker to Major, this is not a blocker for the project (which is what the priority refers to). > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3446: ----------------------------------- Attachment: OFBIZ-3446_Lookup_in_Lookup.patch Hi Jacques, hi * here is a first proposal for this issue. Jacques your right, this wasn't the easiest bug, i had to rebuild/rethink the lookup layer model. I know there are a few bugs in the layout, i will fix it soon. This patch should only be for functional testing purposes, maybe someone can review it ;) So long Sascha > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845309#action_12845309 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- Hi Sascha, Be sure that I will review and test it as soon as I will get a chance. Also be sure that there will be no conflicts with Bilgin's recent works on aucompletion at OFBIZ-3555 With these both enhanced features (layered+autocompleter) the lookups will get a new life! > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847961#action_12847961 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- Hi Sascha, I have not be able to review/test this week as I planned. But 2 persons should begin to test this week and I expect to help also. We are not far from our goal and should release with 10.04(5?) > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848091#action_12848091 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- Hi Sascha, all, I just quicly tested because I found an issue in the current code when you have a calendar used in a lookup. IIRW before the faded background it was working. But it seems logical that the faded background could have introduced an issue since it "hiddes" all other things. By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup. I guess it's the same problem with other layered lookups called from a layered lookup. A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars and the Product Id lookup This suppose to have previously applied the patch at OFBIZ-3442 and then above patch. Atul, to allow to easily apply the above patch I have reverted the change introduced at r925632 (OFBIZ-3570). ie from if (fadeBackground != "false") { back to if (!fadeBackground != "false") { because Sascha also fixed this typo in the above patch Hope it's clear, sorry I have no time to help more right now > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849125#action_12849125 ] Sascha Rodekamp commented on OFBIZ-3446: ---------------------------------------- Hi Jacques, sorry for my late answer and thanks for the fix. I'm still working on this issue, i try to build a kind of window manager for the different Lookups. The registration works fine, but i have a few issus with identifying the lookup which is focused. I hope i find a solution this evening/ night when i'm back in my office. I will go on vacation at the end of the week (two weeks to the states :-)), so hopefully i can create a functional version of the lookups this night. Have a nice day Sascha > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3446: ----------------------------------- Attachment: OFBIZ-3446_Lookup_in_Lookup.patch Hey Jacques, here a new version, seems that it works now :-) Cheers Sascha > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849461#action_12849461 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- Thanks Sascha, I will have a look this weekend. Have a good trip Jacques > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849637#action_12849637 ] Sascha Rodekamp commented on OFBIZ-3446: ---------------------------------------- Thanks Jacques, Have a dive day Cheers Sascha > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3446. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Thanks Sascha, I commited your patch at r928292 It effectively fixes this issue. And to continue our progression I commited it. It does not fix the issue with calendar I reported. I will create a new Jira for that. Also it introduces a small drawback: you can't no longer close a layered lookup with the right left cross button. But Esc. is still working, so it's not a blocker. I will have a look at this and if needed will create a new Jira . > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850675#action_12850675 ] Sascha Rodekamp commented on OFBIZ-3446: ---------------------------------------- Hey Jacques, jep thanks for the commit, i noticed the issue with the cross (when you first click somewhere on the layer and then use the close button it works :-) thast it caused by the focusing mechanisem, i will fix it after my vacation!) Next step will be the calender issue, we will get it to work i thing! Greets from Washington DC have a nice day Sascha > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850702#action_12850702 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- Hi Sascha, Thanks for the tip > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850703#action_12850703 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- I just found another small issue: if you use the collapse button you finally get caught and can get back to the calling screen. Easy to reproduce on https://demo-trunk.ofbiz.apache.org/catalog/control/login/main?USERNAME=admin&PASSWORD=ofbiz if you select the "Edit Category with Category ID" lookup and then use this button > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850794#action_12850794 ] Ankit Jain commented on OFBIZ-3446: ----------------------------------- i just found a issue that value not reaching in the main screen field(AcroForm (PDF) Content ID) after using layer lookup from layer lookup "https://localhost:8443/content/control/FindSurvey" > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850811#action_12850811 ] Jacques Le Roux commented on OFBIZ-3446: ---------------------------------------- Yes, thanks Ankit. This is weird indeed, since the called lookup works ok and returns the values but then the 1st lookup does return any values. I will have a look. > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850927#action_12850927 ] Sascha Rodekamp commented on OFBIZ-3446: ---------------------------------------- morning guys, jep that is quiet confusing... maybe jacques you can figure out what happened there, if u haven"t time... i'll write it on my list :-) Cheers Sascha > Allow to open a layer lookup from a layer lookup > ------------------------------------------------ > > Key: OFBIZ-3446 > URL: https://issues.apache.org/jira/browse/OFBIZ-3446 > Project: OFBiz > Issue Type: Sub-task > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3446_Lookup_in_Lookup.patch, OFBIZ-3446_Lookup_in_Lookup.patch > > > This issue is really a blocker else we need to duplicate a lot of things. I began to work in this direction but after few hours on them I think I will preferably find a real solution than mucking around. > I was not quite sure this was possible, but as Calendars are also called from layered popups, it seems possible. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |