[jira] Created: (OFBIZ-3485) Error in updating party postal address if party has an EftAccount

[Nicolas Malin (Jira)]

Error in updating party postal address  if party has an EftAccount
------------------------------------------------------------------

                 Key: OFBIZ-3485
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
             Project: OFBiz
          Issue Type: Bug
            Reporter: Abdullah Shaikh


Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,

The Following Errors Occurred:

Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834780#action_12834780 ]

Abdullah Shaikh commented on OFBIZ-3485:
----------------------------------------

I have checked this issue, the error is because the seed data doesn't have nameOnAccount for EftAccount entity, and when the updatePaymentMethodAddress seca service is called when you update the party's postal address, in it turns calls the updateEftAccount service which has nameOnAccount set to optional="false", this results in error.

From business point of view is the  account name (nameOnAccount) of bank account (EftAccount) mandatory ?

If yes then we need to have nameOnAccount set in seed data and if no, then we need to make nameOnAccount field optional in updateEftAccount.

Let me know if nameOnAccount shoud be mandatory or not, so that I can provide a patch.

> Error in updating party postal address  if party has an EftAccount
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-3485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>
> Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,
> The Following Errors Occurred:
> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834786#action_12834786 ]

Scott Gray commented on OFBIZ-3485:
-----------------------------------

Hi Abdullah, thanks for reporting.  

Before worrying about a fix I'd like to add a unit test that can replicate this behavior, could you please provide the exact steps to reproduce (or at least mention which Postal Address record you are editing).

Thanks
Scott

> Error in updating party postal address  if party has an EftAccount
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-3485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>
> Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,
> The Following Errors Occurred:
> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834792#action_12834792 ]

Abdullah Shaikh commented on OFBIZ-3485:
----------------------------------------

Hi Scott,

The error can be reproduced by editing the postal address of any party which has an EftAccount.

You can edit the postal address of "company" party id which comes with seed data.

https://ofbiz-vm.apache.org:8443/partymgr/control/viewprofile?partyId=Company

Click on Update button for Postal Address, makes some changes to the address (optional), click on Save, you will get this error.

Thanks,
Abdullah

> Error in updating party postal address  if party has an EftAccount
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-3485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>
> Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,
> The Following Errors Occurred:
> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835395#action_12835395 ]

Scott Gray commented on OFBIZ-3485:
-----------------------------------

Thanks Abdullah, I've committed a test (disabled for now) which reproduces the problem in r911518

I'll get around to fixing the actual bug in the next couple of days unless someone beats me to it and then enable the test.

> Error in updating party postal address  if party has an EftAccount
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-3485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>
> Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,
> The Following Errors Occurred:
> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871365#action_12871365 ]

BJ Freeman commented on OFBIZ-3485:
-----------------------------------

here is the logs up to the problem
2010-05-25 18:27:32,176 (TP-Processor36) [ ServiceEcaRule.java:151:INFO
] Running Service ECA Service: updatePaymentMethodAddress, triggered by
rule on Service: updatePostalAddress
2010-05-25 18:27:32,199 (TP-Processor36)
[ServiceEcaCondition.java:155:WARN ] From Field (expMonth) is not found
in context for updateCreditCard, defaulting to null.
2010-05-25 18:27:32,200 (TP-Processor36) [ ServiceEcaRule.java:134:INFO
] For Service ECA [updateCreditCard] on [in-validate] got false for
condition: [expMonth][is-not-empty][true][String]
2010-05-25 18:27:32,261 (TP-Processor36) [ ServiceEcaRule.java:151:INFO
] Running Service ECA Service: verifyCreditCard, triggered by rule on
Service: updateCreditCard
2010-05-25 18:27:32,262 (TP-Processor36)
[PaymentGatewayServices.java:3144:INFO ] Running verifyCreditCard [
10002] for store: null
2010-05-25 18:27:32,264 (TP-Processor36)
[PaymentGatewayServices.java:3160:INFO ] Running credit card
verification [10002] (0) : payment.properties : UPDATE
2010-05-25 18:27:32,264 (TP-Processor36) [
ServiceDispatcher.java:599:INFO ] Sync service
[partymgr/updateCreditCard] finished in [65] milliseconds

> Error in updating party postal address  if party has an EftAccount
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-3485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>
> Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,
> The Following Errors Occurred:
> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871370#action_12871370 ]

BJ Freeman commented on OFBIZ-3485:
-----------------------------------

I think the whole process should be refactored so the CC  ins linked to one ofthe contactmechs
then if is changed in the normal process we don't have to go through and the ECA's

> Error in updating party postal address  if party has an EftAccount
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-3485
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3485
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Abdullah Shaikh
>
> Try to update the party Postal Address, which have an EftAccount, using the Update button in Profile's Contact Information section, you get the below error,
> The Following Errors Occurred:
> Error trying to begin transaction, could not process method: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service [updateEftAccount] threw an unexpected exception/errororg.ofbiz.service.ServiceValidationException: The following required parameter is missing: [updateEftAccount.nameOnAccount] (The following required parameter is missing: [updateEftAccount.nameOnAccount])

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.