Tomahawk Menu Loading
--------------------- Key: OFBIZ-3494 URL: https://issues.apache.org/jira/browse/OFBIZ-3494 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Sascha Rodekamp Fix For: SVN trunk Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch As Scott remarked the menu loading is a little bit lazy. Thats because the JavaScript starts creating the menu after the page is completely loaded. I think we can increase loading,by starting after creating the menu dom elements. So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. So long Sascha :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3494: ----------------------------------- Attachment: OFBIZ-3494_Tomahawk_Menu_load.patch > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3494. ------------------------------ Resolution: Invalid Hi Sascha, I did some work about this over the week end. This has been fixed in trunk rev 912269. > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836577#action_12836577 ] Sascha Rodekamp commented on OFBIZ-3494: ---------------------------------------- Hi Bruno, jep i saw your changes (good work so far), but you load the menu after the dom is loaded. When i go to the Webtools --> Service List. It take a lot of time until the menu is useable. If we load the menu directly after the menu/appbar elements we can display the menu much faster. So in my opinion we can move the menu loading to the appbarClose.ftl What do you think of it? > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-3494: -------------------------------- Assignee: Bruno Busco OK, so you mean this patch can be applyed on the latest trunk. This is good. I will try it ASAP. > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836595#action_12836595 ] Sascha Rodekamp commented on OFBIZ-3494: ---------------------------------------- OK Bruno, take your time ::) i think it's an good idea. Have a nice day sascha > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837817#action_12837817 ] Bruno Busco commented on OFBIZ-3494: ------------------------------------ Thank you Sascha, your patch is in trunk rev. 915812 > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3494. ------------------------------ Resolution: Fixed > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837890#action_12837890 ] Sascha Rodekamp commented on OFBIZ-3494: ---------------------------------------- Thanks Bruno Have nice day Sascha > Tomahawk Menu Loading > --------------------- > > Key: OFBIZ-3494 > URL: https://issues.apache.org/jira/browse/OFBIZ-3494 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3494_Tomahawk_Menu_load.patch > > > As Scott remarked the menu loading is a little bit lazy. > Thats because the JavaScript starts creating the menu after the page is completely loaded. > I think we can increase loading,by starting after creating the menu dom elements. > So i tried in this patch. Maybe someone can have a look at it and say if this is the right way to solve the issue. > So long > Sascha > :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |