[jira] Created: (OFBIZ-3525) Password Hint Message should be an event message, not error message

[Nicolas Malin (Jira)]

Password Hint Message should be an event message, not error message
-------------------------------------------------------------------

                 Key: OFBIZ-3525
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3525
             Project: OFBiz
          Issue Type: Improvement
    Affects Versions: Release Branch 9.04
            Reporter: Koon Sang
             Fix For: Release Branch 9.04


Hi,

When I change password from ecommerce, I got the following message which appears in red, meaning it is an error message.

The Following Errors Occurred:
The Password Hint is: xxxxx.

This is alarming to the user.  It should be an event message instead of an error message.  I have changed the code at line 162 and here is the patch.  I only change this line

request.setAttribute("_ERROR_MESSAGE_", errMsg);

to

request.setAttribute("_EVENT_MESSAGE_", errMsg);


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koon Sang updated OFBIZ-3525:
-----------------------------

    Attachment: LoginEvents.java

Change line 162

> Password Hint Message should be an event message, not error message
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-3525
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3525
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Koon Sang
>             Fix For: Release Branch 9.04
>
>         Attachments: LoginEvents.java
>
>
> Hi,
> When I change password from ecommerce, I got the following message which appears in red, meaning it is an error message.
> The Following Errors Occurred:
> The Password Hint is: xxxxx.
> This is alarming to the user.  It should be an event message instead of an error message.  I have changed the code at line 162 and here is the patch.  I only change this line
> request.setAttribute("_ERROR_MESSAGE_", errMsg);
> to
> request.setAttribute("_EVENT_MESSAGE_", errMsg);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839607#action_12839607 ]

Jacques Le Roux commented on OFBIZ-3525:
----------------------------------------

Hi Kon Sang,

Please provide a patch instead of a complete java file. See the [how to here|http://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]

> Password Hint Message should be an event message, not error message
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-3525
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3525
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Koon Sang
>             Fix For: Release Branch 9.04
>
>         Attachments: LoginEvents.java
>
>
> Hi,
> When I change password from ecommerce, I got the following message which appears in red, meaning it is an error message.
> The Following Errors Occurred:
> The Password Hint is: xxxxx.
> This is alarming to the user.  It should be an event message instead of an error message.  I have changed the code at line 162 and here is the patch.  I only change this line
> request.setAttribute("_ERROR_MESSAGE_", errMsg);
> to
> request.setAttribute("_EVENT_MESSAGE_", errMsg);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839609#action_12839609 ]

Jacques Le Roux commented on OFBIZ-3525:
----------------------------------------

BTW did you try only with R9.04? Ie, is it the same situation with the trunk? (I suppose it is)

> Password Hint Message should be an event message, not error message
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-3525
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3525
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Koon Sang
>             Fix For: Release Branch 9.04
>
>         Attachments: LoginEvents.java
>
>
> Hi,
> When I change password from ecommerce, I got the following message which appears in red, meaning it is an error message.
> The Following Errors Occurred:
> The Password Hint is: xxxxx.
> This is alarming to the user.  It should be an event message instead of an error message.  I have changed the code at line 162 and here is the patch.  I only change this line
> request.setAttribute("_ERROR_MESSAGE_", errMsg);
> to
> request.setAttribute("_EVENT_MESSAGE_", errMsg);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839617#action_12839617 ]

Jacques Le Roux commented on OFBIZ-3525:
----------------------------------------

OK, forget my comment, I have checked it's ok I will commit your change in trunk and R9.04

Thanks

> Password Hint Message should be an event message, not error message
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-3525
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3525
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Koon Sang
>             Fix For: Release Branch 9.04
>
>         Attachments: LoginEvents.java
>
>
> Hi,
> When I change password from ecommerce, I got the following message which appears in red, meaning it is an error message.
> The Following Errors Occurred:
> The Password Hint is: xxxxx.
> This is alarming to the user.  It should be an event message instead of an error message.  I have changed the code at line 162 and here is the patch.  I only change this line
> request.setAttribute("_ERROR_MESSAGE_", errMsg);
> to
> request.setAttribute("_EVENT_MESSAGE_", errMsg);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3525.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

But of course please next time follow the contributor best practices, TIA.

Fixed in trunk at r917435 , R9.04 r917436

> Password Hint Message should be an event message, not error message
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-3525
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3525
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Branch 9.04
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: LoginEvents.java
>
>
> Hi,
> When I change password from ecommerce, I got the following message which appears in red, meaning it is an error message.
> The Following Errors Occurred:
> The Password Hint is: xxxxx.
> This is alarming to the user.  It should be an event message instead of an error message.  I have changed the code at line 162 and here is the patch.  I only change this line
> request.setAttribute("_ERROR_MESSAGE_", errMsg);
> to
> request.setAttribute("_EVENT_MESSAGE_", errMsg);

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.