[jira] Created: (OFBIZ-353) formatting fix of companyheader.fo.ftl
Locked
[jira] Created: (OFBIZ-353) formatting fix of companyheader.fo.ftl
 
|
formatting fix of companyheader.fo.ftl
-------------------------------------- Key: OFBIZ-353 URL: http://issues.apache.org/jira/browse/OFBIZ-353 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: order Reporter: Chris Howe Priority: Minor Attachments: companyheader.fo.ftl.patch Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=all ]
Chris Howe updated OFBIZ-353: ----------------------------- Attachment: companyheader.fo.ftl.patch companyheader.fo.ftl.patch > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Priority: Minor > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=comments#action_12439461 ]
Jacques Le Roux commented on OFBIZ-353: --------------------------------------- Hi Chris, Why did you suppress "Tel:" ? > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Priority: Minor > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=comments#action_12439462 ]
Jacques Le Roux commented on OFBIZ-353: --------------------------------------- Sorry doing too much things in the same time. I see : redudancy with CommonTelephoneAbbr. > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Priority: Minor > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=all ]
Jacques Le Roux closed OFBIZ-353. --------------------------------- Fix Version/s: SVN trunk Resolution: Fixed Assignee: Jacques Le Roux Completed: At revision: 452439 Thanks Chris > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Reopened: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=all ]
Jacques Le Roux reopened OFBIZ-353: ----------------------------------- At David Jones's request, roll back of Chris Howe's patch. BTW I kept reduction of CommonTelephoneAbbr redundancy > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=all ]
Jacques Le Roux closed OFBIZ-353. --------------------------------- Resolution: Won't Fix > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=comments#action_12439510 ]
Chris Howe commented on OFBIZ-353: ---------------------------------- I suppose the real way of doing this would be through some global generic telephone formatting where the entire telephone string is concatenated and then formatted? > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=comments#action_12440173 ]
Eriks Dobelis commented on OFBIZ-353: ------------------------------------- I am sorry, but why this is Closed/Won't fix? We can discuss how it should be fixed, but the issue is really there as I see it. If there is no country code or there is no area code then hyphen appears, which really doesn't look right. > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Reopened: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=all ]
Jacques Le Roux reopened OFBIZ-353: ----------------------------------- You are right Eriks. It was closed when I commited first and after my roll back I forgot to reopen it. Thanks. > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-353) formatting fix of companyheader.fo.ftl
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-353?page=all ]
Jacopo Cappellato closed OFBIZ-353. ----------------------------------- Resolution: Fixed I've committed the (slightly modified) patch in rev. 453519 (I've not included the US specific formatting conventions). > formatting fix of companyheader.fo.ftl > -------------------------------------- > > Key: OFBIZ-353 > URL: http://issues.apache.org/jira/browse/OFBIZ-353 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: order > Reporter: Chris Howe > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: companyheader.fo.ftl.patch > > > Clean up of the phone number line of the companyheader.fo.ftl if the country code is not present then the hyphen between country code and area code should not print either. in addition makes a substring out of contact number for the first three digits - last digits. the freemarker plugin for eclipse doesn't like the format [3..] where the last index is omitted, however, it is correct. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |