OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

Associate Image functionality with ProductPromo using content driven
--------------------------------------------------------------------

Key: OFBIZ-3533
URL: https://issues.apache.org/jira/browse/OFBIZ-3533
Project: OFBiz
Issue Type: Improvement
Components: product
Affects Versions: SVN trunk
Reporter: Amit Sharma
Priority: Minor
Fix For: SVN trunk

Associate Image functionality with ProductPromo using content driven.

Following work will be covered: -

# Add new entity "ProductPromoContent" entity having composite primary key:
## productPromoId
## contentId
## productPromoContentTypeId
## fromDate
# CRUD services for ProductPromoContent Entity.
# Create wrapper ProductPromoContentWrapper
# Add content tab at catalog -> promo
# List and edit form for associating images to specific productPromoId.
# Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amit Sharma updated OFBIZ-3533:
-------------------------------

Attachment: OFBIZ-3533.patch

I am attaching patch for the same.

Please give your thoughts and suggestions.

Thanks & Regards,
Amit Sharma

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
> Key: OFBIZ-3533
> URL: https://issues.apache.org/jira/browse/OFBIZ-3533
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Amit Sharma
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3533.patch
>
>
> Associate Image functionality with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key:
> ## productPromoId
> ## contentId
> ## productPromoContentTypeId
> ## fromDate
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper ProductPromoContentWrapper
> # Add content tab at catalog -> promo
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841190#action_12841190 ]

Amit Sharma commented on OFBIZ-3533:
------------------------------------

Please create promo folder at location framework/images/webapp/images/products/
I am not able to create a blank folder with this patch.

--
Amit Sharma

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841198#action_12841198 ]

Amit Sharma commented on OFBIZ-3533:
------------------------------------

Before going testing please make sure promo blank folder in framework/images/webapp/images/products/promo

Testing steps : -

# Go to https://localhost:8443/catalog/control/main
# Press promo tab.
# Now select one promo (Ex. 9020)
# Press content tab.
# Upload image and click on create button.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841333#action_12841333 ]

Scott Gray commented on OFBIZ-3533:
-----------------------------------

Since this patch adds a new entity, I would suggest sending an email to the dev list in case this issue is missed and then waiting a couple of days for comment before anyone goes ahead and commits it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amit Sharma updated OFBIZ-3533:
-------------------------------

Attachment: OFBIZ-3533.patch

Here is the updated patch.

Added a logic so that if "promo" folder is not exists then it gets created automatically.

Regards,
Amit Sharma

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
> Key: OFBIZ-3533
> URL: https://issues.apache.org/jira/browse/OFBIZ-3533
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Amit Sharma
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch
>
>
> Associate Image functionality with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key:
> ## productPromoId
> ## contentId
> ## productPromoContentTypeId
> ## fromDate
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper ProductPromoContentWrapper
> # Add content tab at catalog -> promo
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3533:
------------------------------------------

Assignee: Ashish Vijaywargiya

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
> Key: OFBIZ-3533
> URL: https://issues.apache.org/jira/browse/OFBIZ-3533
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Amit Sharma
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch
>
>
> Associate Image functionality with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key:
> ## productPromoId
> ## contentId
> ## productPromoContentTypeId
> ## fromDate
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper ProductPromoContentWrapper
> # Add content tab at catalog -> promo
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843199#action_12843199 ]

Scott Gray commented on OFBIZ-3533:
-----------------------------------

Few comments:
- The entity packages should probably be org.ofbiz.product.promo instead of org.ofbiz.product.product
- I'm not sure about re-using the ProductContentType entity for representing productPromoContentTypeIds, does anyone have an opinion on this?
- What is the reason for calling updateContent within the ProductPromoContent CrUD services? Maybe the answer is obvious but I'm not fresh enough on the content stuff to know.

Thanks
Scott

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
> Key: OFBIZ-3533
> URL: https://issues.apache.org/jira/browse/OFBIZ-3533
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Amit Sharma
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch
>
>
> Associate Image functionality with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key:
> ## productPromoId
> ## contentId
> ## productPromoContentTypeId
> ## fromDate
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper ProductPromoContentWrapper
> # Add content tab at catalog -> promo
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amit Sharma updated OFBIZ-3533:
-------------------------------

Attachment: OFBIZ-3533.patch

Thanks Scott,

I have done improvement on patch for #1 and 3#.
#2 I have discussed this with Ashish & we didn't find any issue in this approach. That's why we have reused the existing entity instead of creating new one.

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
> Key: OFBIZ-3533
> URL: https://issues.apache.org/jira/browse/OFBIZ-3533
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Amit Sharma
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch, OFBIZ-3533.patch
>
>
> Associate Image functionality with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key:
> ## productPromoId
> ## contentId
> ## productPromoContentTypeId
> ## fromDate
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper ProductPromoContentWrapper
> # Add content tab at catalog -> promo
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3533) Associate Image functionality with ProductPromo using content driven

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3533.
--------------------------------------

Resolution: Fixed

Thanks Amit for the contribution - committed in r922506.
Thanks Scott for your valuable comments.

Except point #2 all the comments is being taken care by Amit. And for point # 2 please see my comments in Commit notification itself.

--
Ashish Vijaywargiya

> Associate Image functionality with ProductPromo using content driven
> --------------------------------------------------------------------
>
> Key: OFBIZ-3533
> URL: https://issues.apache.org/jira/browse/OFBIZ-3533
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk
> Reporter: Amit Sharma
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3533.patch, OFBIZ-3533.patch, OFBIZ-3533.patch
>
>
> Associate Image functionality with ProductPromo using content driven.
> Following work will be covered: -
> # Add new entity "ProductPromoContent" entity having composite primary key:
> ## productPromoId
> ## contentId
> ## productPromoContentTypeId
> ## fromDate
> # CRUD services for ProductPromoContent Entity.
> # Create wrapper ProductPromoContentWrapper
> # Add content tab at catalog -> promo
> # List and edit form for associating images to specific productPromoId.
> # Implement service addImageForProductPromo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.