[jira] Created: (OFBIZ-3541) Using Widgets html form templates in FTL files
Locked
12
12
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853193#action_12853193 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- I found another in of shared input field in appendorderitem.ftl (with quicklookup) Also there we have an use of <@ofbizContentUrl>/images/fieldlookup.gif</@ofbizContentUrl> but I think that this is now deprecated by the themes. Not quite sure at this stage though... > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3541: ----------------------------------- Attachment: OFBIZ-3541 Using Widgets html form templates in FTL files.patch Complete patch with the 2 issues I found with shared input (I marked them fix FIXME). I would appreciate reviews > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853201#action_12853201 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- Bilgin, Could you please update your patch because I have changed some things since then and unfortunately I forgot to apply your patch before, sorry :/ > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853206#action_12853206 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- Actually the last patch is not complete. I remember now that I forgot some other cases since I only treated some of the call_fieldlookup2 cases. There are still some * call_fieldlookup2 (17) * call_fieldlookup3 (5) * call_fieldlookup (2) > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853207#action_12853207 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- You have to be very careful with regexp, you always forget something ;) > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853245#action_12853245 ] Bilgin Ibryam commented on OFBIZ-3541: -------------------------------------- Jacques, In rev 930660 I committed my patch (I don't want it to get obsolete) and also updated yours (replaced ormrenderer.renderLookupField with htmlTemplate.lookupField) Also could you tell me why we need to replace targets in controllers? Can't we reuse existing requests? I can't see the related discussion about this change? > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: --------------------------------- Attachment: OFBIZ-3541 Using Widgets html form templates in FTL files.patch > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853248#action_12853248 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- Hi BIlgin, IIRW (I did not check) it's only beause of the decorators names, could be more reasons see OFBIZ-3442. Anyway this was mostly related to the testing phase. We should be able to simplify this and other points as we already discussed by setting the defaults in the renderer (I repeat: layer and topleft). For the moment actually there are only 4 points remaining: * cross button in header which does not close before you click inside the layer, not a big deal for now as there is a workaroud, Sascha will quickly fix this later he said * the minize button (+ -) has a problem, [we have an idea on how to fix that thanks to Ankit Jain|https://issues.apache.org/jira/browse/OFBIZ-3446?focusedCommentId=12851807&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12851807] * the lookups that call calendars should not be layered until we solve the issue with them. I think Sascha will be able to solve that when he will come back * 2 inputs fields in FTL are shared (see my comment above) and we will need to keep them as is as long as we don't find an answer for them. The only drawback is the button image in Tomahawk. So nothing is really blocking now and we should be ok to commit all soon. Thanks for commiting you patch and updating mine :) > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3541: ----------------------------------- Attachment: OFBIZ-3541 Using Widgets html form templates in FTL files.patch This last patch is complete. I'd appreciate reviews before commiting because I did a lot of (trivial) changes by hand and have my eyeballs a little tired. Anyway I should commit in 2 or 3 days... > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853924#action_12853924 ] Bilgin Ibryam commented on OFBIZ-3541: -------------------------------------- Jacques, I applied your patch, browsed a little bit and didn't notice anything wrong. Bilgin > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854019#action_12854019 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- Thanks for the help Bilgin, This weekend, I spent a little time on setting layer and topleft as default. I got an issue with the lookup from lookup case (which are working now if you pass the attribute values). I'm still investigating... > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3541. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Commited in trunk at r931854 > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855803#action_12855803 ] Blas Rodriguez Somoza commented on OFBIZ-3541: ---------------------------------------------- It seems that there is an error in /product/webapp/catalog/category/EditCategoryProducts.ftl Line 151 <@htmlTemplate.lookupField formName="addProductCategoryMemberForm" name="productId" id="productId" lookupFieldFormName="LookupProduct"/> AFAIK the last parameter should be fieldFormName instead lookupFieldFormName. From Catalog->Browse catalog->Products Macro lookupField has no such argument: lookupFieldFormName The problematic instruction: ---------- ==> macro lookupField [on line 22, column 1 in component://common/webcommon/includes/htmlTemplate.ftl] in user-directive htmlTemplate.lookupField [on line 151, column 25 in component://product/webapp/catalog/category/EditCategoryProducts.ftl] > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855856#action_12855856 ] Bilgin Ibryam commented on OFBIZ-3541: -------------------------------------- Thanks Blas, fixed in rev 933108 > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855904#action_12855904 ] Jacques Le Roux commented on OFBIZ-3541: ---------------------------------------- I also fixed 2 such wrong parameters names at r933145 > Using Widgets html form templates in FTL files > ---------------------------------------------- > > Key: OFBIZ-3541 > URL: https://issues.apache.org/jira/browse/OFBIZ-3541 > Project: OFBiz > Issue Type: Sub-task > Reporter: Bruno Busco > Assignee: Bruno Busco > Fix For: SVN trunk > > Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff > > > The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. > This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. > In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. > This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). > Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. > A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. > Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. > I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |