[jira] Created: (OFBIZ-3552) Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns

[Nicolas Malin (Jira)]

  Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns
----------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-3552
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3552
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: Divesh Dutta
             Fix For: SVN trunk


Problem Description:

1) When returns are received and  reason of return is "Defective Item" ,whether  inventoryItemType is serialized or non-serialized,   Initial Inventory Item Status is always saved as "INV_DEFECTIVE"

2) This should not be the case, value of Initial Inventory Item Status should be dependent on inventoryItemType.

3) i. e In Receive Return screen , when user selects inventoryItemType value of Initial Inventory Item Status should be changed dynamically .

4) So when inventoryItemType is non-serialized then value of Initial Inventory Item Status should be INV_NS_DEFECTIVE and if  inventoryItemType is serialized value of value of Initial Inventory Item Status should be INV_DEFECTIVE.

5) This is a real bug, which causes ATP inventory figures wrong when sales order is placed. This is so because when sales order is placed, defective inventory items are assigned to sales order.

6) Reason of #5 is when inventory reservations are done in case of non-serialized inventory, In reserveForInventoryItemInline simple-method of InventoryReserveServices.xml , checks are made on value of inventoryItem.statusId = "INV_NS_DEFECTIVE".
And as described in #1, Initial Inventory Item Status is always saved as "INV_DEFECTIVE". So this checks never gets satisfied.




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-3552:
--------------------------------

    Attachment: OFBiz-3552.patch

Steps for  testing this patch:

1) Create a sales order and complete it.
2) Then create a return from order detail page (Reason of return should be "Defective Item"),and  accept the return.
3) Then go to https://localhost:8443/facility/control/ReceiveReturn?facilityId=WebStoreWarehouse
4) Enter Return number and you will be landing Receive Return screen.
5) Here you need Firebug to observe the changes, you may see that inventoryItemType is non-serialized and Initial Inventory Item Status is INV_NS_DEFECTIVE.
6) Now when you change inventoryItemType to serialized, value of Initial Inventory Item Status will dynamically change to  INV_NS_DEFECTIVE.

>   Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3552
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3552.patch
>
>
> Problem Description:
> 1) When returns are received and  reason of return is "Defective Item" ,whether  inventoryItemType is serialized or non-serialized,   Initial Inventory Item Status is always saved as "INV_DEFECTIVE"
> 2) This should not be the case, value of Initial Inventory Item Status should be dependent on inventoryItemType.
> 3) i. e In Receive Return screen , when user selects inventoryItemType value of Initial Inventory Item Status should be changed dynamically .
> 4) So when inventoryItemType is non-serialized then value of Initial Inventory Item Status should be INV_NS_DEFECTIVE and if  inventoryItemType is serialized value of value of Initial Inventory Item Status should be INV_DEFECTIVE.
> 5) This is a real bug, which causes ATP inventory figures wrong when sales order is placed. This is so because when sales order is placed, defective inventory items are assigned to sales order.
> 6) Reason of #5 is when inventory reservations are done in case of non-serialized inventory, In reserveForInventoryItemInline simple-method of InventoryReserveServices.xml , checks are made on value of inventoryItem.statusId = "INV_NS_DEFECTIVE".
> And as described in #1, Initial Inventory Item Status is always saved as "INV_DEFECTIVE". So this checks never gets satisfied.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3552:
------------------------------------------

    Assignee: Ashish Vijaywargiya

>   Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3552
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Ashish Vijaywargiya
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3552.patch
>
>
> Problem Description:
> 1) When returns are received and  reason of return is "Defective Item" ,whether  inventoryItemType is serialized or non-serialized,   Initial Inventory Item Status is always saved as "INV_DEFECTIVE"
> 2) This should not be the case, value of Initial Inventory Item Status should be dependent on inventoryItemType.
> 3) i. e In Receive Return screen , when user selects inventoryItemType value of Initial Inventory Item Status should be changed dynamically .
> 4) So when inventoryItemType is non-serialized then value of Initial Inventory Item Status should be INV_NS_DEFECTIVE and if  inventoryItemType is serialized value of value of Initial Inventory Item Status should be INV_DEFECTIVE.
> 5) This is a real bug, which causes ATP inventory figures wrong when sales order is placed. This is so because when sales order is placed, defective inventory items are assigned to sales order.
> 6) Reason of #5 is when inventory reservations are done in case of non-serialized inventory, In reserveForInventoryItemInline simple-method of InventoryReserveServices.xml , checks are made on value of inventoryItem.statusId = "INV_NS_DEFECTIVE".
> And as described in #1, Initial Inventory Item Status is always saved as "INV_DEFECTIVE". So this checks never gets satisfied.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3552.
--------------------------------------

    Resolution: Fixed

Thanks Divesh & Pranay for the contribution - Done at r927744.

Small correction: I think the last sentence(6th one) would be:
>> Status will dynamically change to INV_NS_DEFECTIVE ;) :-).

--
Ashish Vijaywargiya

>   Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3552
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Ashish Vijaywargiya
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3552.patch
>
>
> Problem Description:
> 1) When returns are received and  reason of return is "Defective Item" ,whether  inventoryItemType is serialized or non-serialized,   Initial Inventory Item Status is always saved as "INV_DEFECTIVE"
> 2) This should not be the case, value of Initial Inventory Item Status should be dependent on inventoryItemType.
> 3) i. e In Receive Return screen , when user selects inventoryItemType value of Initial Inventory Item Status should be changed dynamically .
> 4) So when inventoryItemType is non-serialized then value of Initial Inventory Item Status should be INV_NS_DEFECTIVE and if  inventoryItemType is serialized value of value of Initial Inventory Item Status should be INV_DEFECTIVE.
> 5) This is a real bug, which causes ATP inventory figures wrong when sales order is placed. This is so because when sales order is placed, defective inventory items are assigned to sales order.
> 6) Reason of #5 is when inventory reservations are done in case of non-serialized inventory, In reserveForInventoryItemInline simple-method of InventoryReserveServices.xml , checks are made on value of inventoryItem.statusId = "INV_NS_DEFECTIVE".
> And as described in #1, Initial Inventory Item Status is always saved as "INV_DEFECTIVE". So this checks never gets satisfied.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850054#action_12850054 ]

Divesh Dutta commented on OFBIZ-3552:
-------------------------------------

Oh ! Thanks Ashish, it should be INV_DEFECTIVE . :)

>   Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3552
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Ashish Vijaywargiya
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3552.patch
>
>
> Problem Description:
> 1) When returns are received and  reason of return is "Defective Item" ,whether  inventoryItemType is serialized or non-serialized,   Initial Inventory Item Status is always saved as "INV_DEFECTIVE"
> 2) This should not be the case, value of Initial Inventory Item Status should be dependent on inventoryItemType.
> 3) i. e In Receive Return screen , when user selects inventoryItemType value of Initial Inventory Item Status should be changed dynamically .
> 4) So when inventoryItemType is non-serialized then value of Initial Inventory Item Status should be INV_NS_DEFECTIVE and if  inventoryItemType is serialized value of value of Initial Inventory Item Status should be INV_DEFECTIVE.
> 5) This is a real bug, which causes ATP inventory figures wrong when sales order is placed. This is so because when sales order is placed, defective inventory items are assigned to sales order.
> 6) Reason of #5 is when inventory reservations are done in case of non-serialized inventory, In reserveForInventoryItemInline simple-method of InventoryReserveServices.xml , checks are made on value of inventoryItem.statusId = "INV_NS_DEFECTIVE".
> And as described in #1, Initial Inventory Item Status is always saved as "INV_DEFECTIVE". So this checks never gets satisfied.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850052#action_12850052 ]

Ashish Vijaywargiya edited comment on OFBIZ-3552 at 3/26/10 9:44 AM:
---------------------------------------------------------------------

Thanks Divesh & Pranay for the contribution - Done at r927744.

Small correction: I think the last sentence(6th one) would be:
>> Status will dynamically change to INV_DEFECTIVE ;) :-).

--
Ashish Vijaywargiya

      was (Author: toashishvijay):
    Thanks Divesh & Pranay for the contribution - Done at r927744.

Small correction: I think the last sentence(6th one) would be:
>> Status will dynamically change to INV_NS_DEFECTIVE ;) :-).

--
Ashish Vijaywargiya
 

>   Initial Inventory Item Status is saved wrong in case of non-serialized inventory and when reason of return is "Defective Item", at the the time of receiving returns
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3552
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3552
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Ashish Vijaywargiya
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3552.patch
>
>
> Problem Description:
> 1) When returns are received and  reason of return is "Defective Item" ,whether  inventoryItemType is serialized or non-serialized,   Initial Inventory Item Status is always saved as "INV_DEFECTIVE"
> 2) This should not be the case, value of Initial Inventory Item Status should be dependent on inventoryItemType.
> 3) i. e In Receive Return screen , when user selects inventoryItemType value of Initial Inventory Item Status should be changed dynamically .
> 4) So when inventoryItemType is non-serialized then value of Initial Inventory Item Status should be INV_NS_DEFECTIVE and if  inventoryItemType is serialized value of value of Initial Inventory Item Status should be INV_DEFECTIVE.
> 5) This is a real bug, which causes ATP inventory figures wrong when sales order is placed. This is so because when sales order is placed, defective inventory items are assigned to sales order.
> 6) Reason of #5 is when inventory reservations are done in case of non-serialized inventory, In reserveForInventoryItemInline simple-method of InventoryReserveServices.xml , checks are made on value of inventoryItem.statusId = "INV_NS_DEFECTIVE".
> And as described in #1, Initial Inventory Item Status is always saved as "INV_DEFECTIVE". So this checks never gets satisfied.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.