[jira] Created: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
Allow to open a layered calendar from a layer lookup
----------------------------------------------------

                 Key: OFBIZ-3580
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
             Project: OFBiz
          Issue Type: Bug
          Components: ALL APPLICATIONS
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux
            Assignee: Jacques Le Roux
            Priority: Critical
             Fix For: SVN trunk


As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.

By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.

A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.

This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3580:
-----------------------------------

    Issue Type: Sub-task  (was: Bug)
        Parent: OFBIZ-3445

> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3580:
------------------------------

    Attachment: CalenderInLookupFix.patch

Hello Everybody,
here is the patch that fixes the issue,
previous code used to append calender's div at the end of the body tag, which was a cause for the layered lookup to close,
this patch modifies the code such that now the calender's div tag is appended just below the input field it is been called from.
there are some minor css changes too.

Thanks to Atul Vani for helping me in developing this patch. :)

> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854446#action_12854446 ]

Jacques Le Roux commented on OFBIZ-3580:
----------------------------------------

Thanks Ankit and Atul,

I just tried with Tomahawk and yes it looks better indeed. At least with your changes we are able to see the calendar which is any longer hidden behing the lookup. But there are still some issues:
* some parts of the calendar are hidden (see screenshots)
* if you 1st click on the button the position is ok (just below) but if you scroll before and then click the position is to low (seems to follow the scroll)

Also it's not related but I tried with other themes and I noticed others issues I will open new Jiras for them:
# in layer lookup with other themes than Tomahawk the buttons inside (loopup and calendar buttons) don't show
# In tomahawk the calendar button is actually the same than the lookup button (fieldlookup.png used instead of cal.png)

I will commit your patch since it's clearly a progress (it's operationnal with some drawbacks) on which you or/and others (including me ;o) can work

> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3580:
-----------------------------------

    Attachment: Some parts don't show.jpg

> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch, Some parts don't show.jpg
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3580:
-----------------------------------

    Attachment: Scroll issue.jpg

> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch, Scroll issue.jpg, Some parts don't show.jpg
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854455#action_12854455 ]

Jacques Le Roux commented on OFBIZ-3580:
----------------------------------------

Committed in trunk at r931523  


> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch, Scroll issue.jpg, Some parts don't show.jpg
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854476#action_12854476 ]

Ankit Jain commented on OFBIZ-3580:
-----------------------------------

thanks jacques,
we'll try to look into the issues.


> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch, Scroll issue.jpg, Some parts don't show.jpg
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3580) Allow to open a layered calendar from a layer lookup

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3580.
----------------------------------

    Resolution: Fixed

I have fixed the issue "some parts of the calendar are hidden" at r932563 and created OFBIZ-3667 for the trivial scroll issue

> Allow to open a layered calendar from a layer lookup
> ----------------------------------------------------
>
>                 Key: OFBIZ-3580
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3580
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: CalenderInLookupFix.patch, Scroll issue.jpg, Some parts don't show.jpg
>
>
> As explained in OFBIZ-3446 you can't select a date from a calendar opened from a layered lookup.
> By moving the layered lookup you can click/select the calendar. But then, as it's supposed to work, it closes the layered lookup.
> A good lookup to test is the Requirement Id lookup at the botton of https://localhost:8443/workeffort/control/EditWorkEffort. There you will find calendars.
> This suppose to have previously applied the patch at OFBIZ-3442.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira