[jira] Created: (OFBIZ-3586) application - manufacturing

[Nicolas Malin (Jira)]

application - manufacturing
---------------------------

                 Key: OFBIZ-3586
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Bob Morley




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3586:
------------------------------

    Attachment: OFBIZ-3586_ResolveWarningsManufacturing.patch

Rather large set of changes here; typically very minor things -- but there was some changes with the BOMTree which was taking a generic ArrayList and now takes a List<BOMNode>.  There were also a number of services that were not explicitly returning a success/error return code; so these were fixed as well.

> application - manufacturing
> ---------------------------
>
>                 Key: OFBIZ-3586
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3586_ResolveWarningsManufacturing.patch
>
>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856595#action_12856595 ]

Bob Morley commented on OFBIZ-3586:
-----------------------------------

Please hold off on this one -- I attached the patch as I was building / testing via ant and there were a few compilation issues related to generic checking (differences between Eclipse building and ant building).  Will resolve and provide a replacement attachment.

> application - manufacturing
> ---------------------------
>
>                 Key: OFBIZ-3586
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3586_ResolveWarningsManufacturing.patch
>
>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3586:
------------------------------

    Attachment: OFBIZ-3586_ResolveWarningsManufacturing.patch

Corrected patch.

> application - manufacturing
> ---------------------------
>
>                 Key: OFBIZ-3586
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3586_ResolveWarningsManufacturing.patch
>
>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3586:
------------------------------

    Attachment:     (was: OFBIZ-3586_ResolveWarningsManufacturing.patch)

> application - manufacturing
> ---------------------------
>
>                 Key: OFBIZ-3586
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3586_ResolveWarningsManufacturing.patch
>
>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Geisert reassigned OFBIZ-3586:
----------------------------------------

    Assignee: Christian Geisert

> application - manufacturing
> ---------------------------
>
>                 Key: OFBIZ-3586
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>            Assignee: Christian Geisert
>         Attachments: OFBIZ-3586_ResolveWarningsManufacturing.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908033#action_12908033 ]

Christian Geisert commented on OFBIZ-3586:
------------------------------------------

Bob,

one thing I noticed is that you added the line

      if  (!productionRunId.equals(mandatoryWorkEffort.getString("workEffortId"))) {

in the cancelProductionRun-method in ProductionRunServices.java

Was that on purpuose?

> application - manufacturing
> ---------------------------
>
>                 Key: OFBIZ-3586
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3586
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>            Assignee: Christian Geisert
>         Attachments: OFBIZ-3586_ResolveWarningsManufacturing.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.