OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3609) XHTML validation errors (product)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3609) XHTML validation errors (product)

XHTML validation errors (product)
---------------------------------

Key: OFBIZ-3609
URL: https://issues.apache.org/jira/browse/OFBIZ-3609
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Reporter: Blas Rodriguez Somoza
Priority: Trivial
Fix For: SVN trunk

XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be
<table cellspacing="0" class="basic-table">
</td>
</tr>
</table>
Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3609:
-----------------------------------------

Description:
XHTML validation errors

* Unclosed INPUT or IMG
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be
<table cellspacing="0" class="basic-table">
</td>
</tr>
</table>
Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.

FindProductPromoCode.ftl
Wrong markup at Line 27. Duplicated </span>

EditProductConfigItemContent.ftl
Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
<table cellspacing="0" class="basic-table">
<input type="hidden" name="configItemId" value="${configItemId?if_exists}">

Updated patch attached (v2)

was:
XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be
<table cellspacing="0" class="basic-table">
</td>
</tr>
</table>
Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.

Patch attached

> XHTML validation errors (product)
> ---------------------------------
>
> Key: OFBIZ-3609
> URL: https://issues.apache.org/jira/browse/OFBIZ-3609
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3609_product_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT or IMG
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be
> <table cellspacing="0" class="basic-table">
> </td>
> </tr>
> </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
> <table cellspacing="0" class="basic-table">
> <input type="hidden" name="configItemId" value="${configItemId?if_exists}">
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (product)
> ---------------------------------
>
> Key: OFBIZ-3609
> URL: https://issues.apache.org/jira/browse/OFBIZ-3609
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3609_product_xhtml.diff, OFBIZ-3609_product_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT or IMG
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be
> <table cellspacing="0" class="basic-table">
> </td>
> </tr>
> </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
> <table cellspacing="0" class="basic-table">
> <input type="hidden" name="configItemId" value="${configItemId?if_exists}">
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (product)
> ---------------------------------
>
> Key: OFBIZ-3609
> URL: https://issues.apache.org/jira/browse/OFBIZ-3609
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3609_product_xhtml.diff, OFBIZ-3609_product_xhtml_v2.diff, OFBIZ-3609_product_xhtml_v3.diff
>
>
> XHTML validation errors
> * Unclosed INPUT or IMG
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be
> <table cellspacing="0" class="basic-table">
> </td>
> </tr>
> </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
> <table cellspacing="0" class="basic-table">
> <input type="hidden" name="configItemId" value="${configItemId?if_exists}">
> Updated patch attached (v2)
> Updated patch to (v3) due to conflict with 929503

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3609:
-----------------------------------------

Description:
XHTML validation errors

* Unclosed INPUT or IMG
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be
<table cellspacing="0" class="basic-table">
</td>
</tr>
</table>
Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.

FindProductPromoCode.ftl
Wrong markup at Line 27. Duplicated </span>

EditProductConfigItemContent.ftl
Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
<table cellspacing="0" class="basic-table">
<input type="hidden" name="configItemId" value="${configItemId?if_exists}">

Updated patch attached (v2)

Updated patch to (v3) due to conflict with 929503

was:
XHTML validation errors

* Unclosed INPUT or IMG
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

EditKeywordThesaurus.ftl
Lines 44-84. When keywordThesauruses is empty the resulting markup will be
<table cellspacing="0" class="basic-table">
</td>
</tr>
</table>
Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.

FindProductPromoCode.ftl
Wrong markup at Line 27. Duplicated </span>

EditProductConfigItemContent.ftl
Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
<table cellspacing="0" class="basic-table">
<input type="hidden" name="configItemId" value="${configItemId?if_exists}">

Updated patch attached (v2)

> XHTML validation errors (product)
> ---------------------------------
>
> Key: OFBIZ-3609
> URL: https://issues.apache.org/jira/browse/OFBIZ-3609
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3609_product_xhtml.diff, OFBIZ-3609_product_xhtml_v2.diff, OFBIZ-3609_product_xhtml_v3.diff
>
>
> XHTML validation errors
> * Unclosed INPUT or IMG
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be
> <table cellspacing="0" class="basic-table">
> </td>
> </tr>
> </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
> <table cellspacing="0" class="basic-table">
> <input type="hidden" name="configItemId" value="${configItemId?if_exists}">
> Updated patch attached (v2)
> Updated patch to (v3) due to conflict with 929503

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reassigned OFBIZ-3609:
----------------------------------

Assignee: Bruno Busco

> XHTML validation errors (product)
> ---------------------------------
>
> Key: OFBIZ-3609
> URL: https://issues.apache.org/jira/browse/OFBIZ-3609
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3609_product_xhtml.diff, OFBIZ-3609_product_xhtml_v2.diff, OFBIZ-3609_product_xhtml_v3.diff
>
>
> XHTML validation errors
> * Unclosed INPUT or IMG
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be
> <table cellspacing="0" class="basic-table">
> </td>
> </tr>
> </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
> <table cellspacing="0" class="basic-table">
> <input type="hidden" name="configItemId" value="${configItemId?if_exists}">
> Updated patch attached (v2)
> Updated patch to (v3) due to conflict with 929503

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3609) XHTML validation errors (product)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-3609.
------------------------------

Resolution: Fixed

Thank you Blas,
your patch is in trunk at rev 931700

> XHTML validation errors (product)
> ---------------------------------
>
> Key: OFBIZ-3609
> URL: https://issues.apache.org/jira/browse/OFBIZ-3609
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3609_product_xhtml.diff, OFBIZ-3609_product_xhtml_v2.diff, OFBIZ-3609_product_xhtml_v3.diff
>
>
> XHTML validation errors
> * Unclosed INPUT or IMG
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> EditKeywordThesaurus.ftl
> Lines 44-84. When keywordThesauruses is empty the resulting markup will be
> <table cellspacing="0" class="basic-table">
> </td>
> </tr>
> </table>
> Which is obviously wrong. Added an <#if to guard against wrong table markup when keywordThesauruses is empty.
> FindProductPromoCode.ftl
> Wrong markup at Line 27. Duplicated </span>
> EditProductConfigItemContent.ftl
> Wrong markup at line 99. Input can't be directly inside table. In this file the input can be one line before table tag without functional changes
> <table cellspacing="0" class="basic-table">
> <input type="hidden" name="configItemId" value="${configItemId?if_exists}">
> Updated patch attached (v2)
> Updated patch to (v3) due to conflict with 929503

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.