[jira] Created: (OFBIZ-3622) XHTML validation errors (framework excluding widget)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3622) XHTML validation errors (framework excluding widget)

Nicolas Malin (Jira)
XHTML validation errors (framework excluding widget)
----------------------------------------------------

                 Key: OFBIZ-3622
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3622
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Blas Rodriguez Somoza
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: OFBIZ_3622-framework_nowidget_xhtml.diff

XHTML validation errors

    * Unclosed INPUT
    * attributes without values (checked, selected, disabled, etc)
    * attribute values without "
    * Uppercase tags or attributes.
    * Unencoded ampersands in urls.

Other errors:

showPortalPage.ftl
Wrong markup in line 23. td with pure numeric id and nonexistent name attribute
...... id="${portalPageColumn.columnSeqId}" name="portalColumn">
Wrong markup in line 30. div with pure numeric id and nonexistent name attribute
<div id="${portlet_index}" name="portalPortlet" class="noClass">

Solution: make id = name value + id value and remove name

xmlsdsdump.ftl
Line 105 to 122 generates
<table>
<tr>
</tr>
But xhtml don't like an empty tr.

Solution: changing line 110 from  <#if entCount % 3 == 0> to <#if entCount % 3 == 0 && entCount != 0> solves the problem

SearchLabels.ftl
Wrong markup at line 22. Text can't be directly inside tr.
<tr>${uiLabelMap.WebtoolsLabelManagerTemporarySearchTitle}</tr>

Solution: added <td>...</td>

serviceResult.ftl
Wrong markup in line 43. Entity without final ;
<td>&nbsp</td>

threads.ftl
Wrong markup at line 61 and 62. Unclosed p tags.

Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3622) XHTML validation errors (framework excluding widget)

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3622:
-----------------------------------------

    Attachment: OFBIZ_3622-framework_nowidget_xhtml.diff

> XHTML validation errors (framework excluding widget)
> ----------------------------------------------------
>
>                 Key: OFBIZ-3622
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3622
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ_3622-framework_nowidget_xhtml.diff
>
>
> XHTML validation errors
>     * Unclosed INPUT
>     * attributes without values (checked, selected, disabled, etc)
>     * attribute values without "
>     * Uppercase tags or attributes.
>     * Unencoded ampersands in urls.
> Other errors:
> showPortalPage.ftl
> Wrong markup in line 23. td with pure numeric id and nonexistent name attribute
> ...... id="${portalPageColumn.columnSeqId}" name="portalColumn">
> Wrong markup in line 30. div with pure numeric id and nonexistent name attribute
> <div id="${portlet_index}" name="portalPortlet" class="noClass">
> Solution: make id = name value + id value and remove name
> xmlsdsdump.ftl
> Line 105 to 122 generates
> <table>
> <tr>
> </tr>
> But xhtml don't like an empty tr.
> Solution: changing line 110 from  <#if entCount % 3 == 0> to <#if entCount % 3 == 0 && entCount != 0> solves the problem
> SearchLabels.ftl
> Wrong markup at line 22. Text can't be directly inside tr.
> <tr>${uiLabelMap.WebtoolsLabelManagerTemporarySearchTitle}</tr>
> Solution: added <td>...</td>
> serviceResult.ftl
> Wrong markup in line 43. Entity without final ;
> <td>&nbsp</td>
> threads.ftl
> Wrong markup at line 61 and 62. Unclosed p tags.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3622) XHTML validation errors (framework excluding widget)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-3622:
----------------------------------

    Assignee: Adrian Crum

> XHTML validation errors (framework excluding widget)
> ----------------------------------------------------
>
>                 Key: OFBIZ-3622
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3622
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Adrian Crum
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ_3622-framework_nowidget_xhtml.diff
>
>
> XHTML validation errors
>     * Unclosed INPUT
>     * attributes without values (checked, selected, disabled, etc)
>     * attribute values without "
>     * Uppercase tags or attributes.
>     * Unencoded ampersands in urls.
> Other errors:
> showPortalPage.ftl
> Wrong markup in line 23. td with pure numeric id and nonexistent name attribute
> ...... id="${portalPageColumn.columnSeqId}" name="portalColumn">
> Wrong markup in line 30. div with pure numeric id and nonexistent name attribute
> <div id="${portlet_index}" name="portalPortlet" class="noClass">
> Solution: make id = name value + id value and remove name
> xmlsdsdump.ftl
> Line 105 to 122 generates
> <table>
> <tr>
> </tr>
> But xhtml don't like an empty tr.
> Solution: changing line 110 from  <#if entCount % 3 == 0> to <#if entCount % 3 == 0 && entCount != 0> solves the problem
> SearchLabels.ftl
> Wrong markup at line 22. Text can't be directly inside tr.
> <tr>${uiLabelMap.WebtoolsLabelManagerTemporarySearchTitle}</tr>
> Solution: added <td>...</td>
> serviceResult.ftl
> Wrong markup in line 43. Entity without final ;
> <td>&nbsp</td>
> threads.ftl
> Wrong markup at line 61 and 62. Unclosed p tags.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3622) XHTML validation errors (framework excluding widget)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-3622.
------------------------------

    Resolution: Fixed

Fixed, rev 930701. Thanks Blas!


> XHTML validation errors (framework excluding widget)
> ----------------------------------------------------
>
>                 Key: OFBIZ-3622
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3622
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Adrian Crum
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ_3622-framework_nowidget_xhtml.diff
>
>
> XHTML validation errors
>     * Unclosed INPUT
>     * attributes without values (checked, selected, disabled, etc)
>     * attribute values without "
>     * Uppercase tags or attributes.
>     * Unencoded ampersands in urls.
> Other errors:
> showPortalPage.ftl
> Wrong markup in line 23. td with pure numeric id and nonexistent name attribute
> ...... id="${portalPageColumn.columnSeqId}" name="portalColumn">
> Wrong markup in line 30. div with pure numeric id and nonexistent name attribute
> <div id="${portlet_index}" name="portalPortlet" class="noClass">
> Solution: make id = name value + id value and remove name
> xmlsdsdump.ftl
> Line 105 to 122 generates
> <table>
> <tr>
> </tr>
> But xhtml don't like an empty tr.
> Solution: changing line 110 from  <#if entCount % 3 == 0> to <#if entCount % 3 == 0 && entCount != 0> solves the problem
> SearchLabels.ftl
> Wrong markup at line 22. Text can't be directly inside tr.
> <tr>${uiLabelMap.WebtoolsLabelManagerTemporarySearchTitle}</tr>
> Solution: added <td>...</td>
> serviceResult.ftl
> Wrong markup in line 43. Entity without final ;
> <td>&nbsp</td>
> threads.ftl
> Wrong markup at line 61 and 62. Unclosed p tags.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.