OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3623) XHTML validation errors (framework/widget)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

13 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3623) XHTML validation errors (framework/widget)

XHTML validation errors (framework/widget)
------------------------------------------

Key: OFBIZ-3623
URL: https://issues.apache.org/jira/browse/OFBIZ-3623
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Blas Rodriguez Somoza
Priority: Trivial
Fix For: SVN trunk

XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

htmlFormMacroLibrary.ftl
Line 452. img tag must have src and alt attributes.
<img />

htmlScreenMacroLibrary.ftl
Wrong markup at Line 143. Entity without final ;
>&nbsp</a></li>

Changes in java classes:

MacroFormRenderer.java (renderSortField)
The sort URL must use encoded ampersands.

HtmlFormRenderer.java (renderDisplayField)
The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)

HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.

ModelMenu.java (public int passConditionCount)
New method to get how many menu items pass the condition.

ModelMenuItem (public boolean passCondition)
New method to get if the menu item pass the condition.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3623) XHTML validation errors (framework/widget)

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3623:
-----------------------------------------

Description:
XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

htmlFormMacroLibrary.ftl
Line 452. img tag must have src and alt attributes.
<img />

htmlScreenMacroLibrary.ftl
Wrong markup at Line 143. Entity without final ;
>&nbsp</a></li>

Changes in java classes:

MacroFormRenderer.java (renderSortField)
The sort URL must use encoded ampersands.

HtmlFormRenderer.java (renderDisplayField)
The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)

HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.

ModelMenu.java (public int passConditionCount)
New method to get how many menu items pass the condition.

ModelMenuItem (public boolean passCondition)
New method to get if the menu item pass the condition.

Patch attached

was:
XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

htmlFormMacroLibrary.ftl
Line 452. img tag must have src and alt attributes.
<img />

htmlScreenMacroLibrary.ftl
Wrong markup at Line 143. Entity without final ;
>&nbsp</a></li>

Changes in java classes:

MacroFormRenderer.java (renderSortField)
The sort URL must use encoded ampersands.

HtmlFormRenderer.java (renderDisplayField)
The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)

HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.

ModelMenu.java (public int passConditionCount)
New method to get how many menu items pass the condition.

ModelMenuItem (public boolean passCondition)
New method to get if the menu item pass the condition.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-3623:
----------------------------------

Assignee: Adrian Crum

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851253#action_12851253 ]

Adrian Crum commented on OFBIZ-3623:
------------------------------------

Blas,

Thank you for all the work you did on this. There are a couple of items in your patch that need attention:

1. In MacroFormRenderer.java, can we run the contents of autoCompleterTarget through UtilHttp.encodeAmpersands to encode the ampersands?

2. In HtmlFormRenderer.java you check for: "modelFormField.getWidgetStyle().length() > 0" - that check was done three lines up. Your second check is not needed.

3. Could we give modelMenu.passConditionCount a better name? Like displayedMenuItemCount? Or something similar? I know this seems trivial, but it would make more sense to others looking at the code. I struggle with giving methods meaningful names myself, so maybe others could help out here. We need to name a method that takes all available menu items, and only returns the count of the ones that pass a set of conditions.

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851362#action_12851362 ]

Blas Rodriguez Somoza commented on OFBIZ-3623:
----------------------------------------------

Thanks

1.- No yo can't, because UtilHttp only encode ampersands it if is not already encoded, if it is encoded (&) it does nothing. An here you need doubly encoded ampresands (&amp;)

2.- The condition three lines up is an OR condition which can evaluate to true with an empty modelFormField.getWidgetStyle()
if (UtilValidate.isNotEmpty(modelFormField.getWidgetStyle()) || modelFormField.shouldBeRed(context))

Anyway the check can be removed as " alert" (with a space before) is valid as class attribute, so the following is valid:
if (modelFormField.shouldBeRed(context)) {
str.append(" alert");
}

3-.OK, I changed it to rendererMenuItemCount, I use rendered instead of displayed because it seems more appropriate here. I changed also the ModelMenuItem method to "shouldBeRendered"

I added a new patch file updated with those changes.

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-3623.
------------------------------

Resolution: Fixed

Fixed, rev 929173. Thanks Blas!

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853247#action_12853247 ]

Bilgin Ibryam commented on OFBIZ-3623:
--------------------------------------

Blas,

in rev 930670 I removed double ampersands from autoCompleterTarget because it was breaking the lookup autocompleter.
Why do we need double ampersands there in case that autoCompleterTarget is not a real url, but part of javscript code?

Bilgin

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853284#action_12853284 ]

Blas Rodriguez Somoza edited comment on OFBIZ-3623 at 4/5/10 12:08 PM:
-----------------------------------------------------------------------

Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&)

was (Author: brsomoza):
Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853284#action_12853284 ]

Blas Rodriguez Somoza edited comment on OFBIZ-3623 at 4/5/10 12:09 PM:
-----------------------------------------------------------------------

Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&amp;)

was (Author: brsomoza):
Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&)

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3623) XHTML validation errors (framework/widget)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853284#action_12853284 ]

Blas Rodriguez Somoza edited comment on OFBIZ-3623 at 4/5/10 12:09 PM:
-----------------------------------------------------------------------

Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&amp; )

was (Author: brsomoza):
Hello Bilgin

Excuse me, I don't notice the problem.

The double ampersand is needed because every entity in the markup file must be encoded, even if it is inside javascript code.

I'll review the autocompleter code to look for a solution, it should work with encoded and not encoded ampersands.

DONE: The patch attached to issue OFBIZ-3637 contains the solution, it modifies ajaxAutoCompleter to be able to work with ampersands unencoded or encoded (&amp;)

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
> Key: OFBIZ-3623
> URL: https://issues.apache.org/jira/browse/OFBIZ-3623
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Adrian Crum
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <img />
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.