[jira] Created: (OFBIZ-3626) XHTML validation erros (framework/widget) Buggy render of fieldgroups in ModelForm

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3626) XHTML validation erros (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)
XHTML validation erros (framework/widget) Buggy render of fieldgroups in ModelForm
----------------------------------------------------------------------------------

                 Key: OFBIZ-3626
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Blas Rodriguez Somoza
            Priority: Minor
             Fix For: SVN trunk


The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>


The same happen in:

Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store


Patch attached.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation erros (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Attachment: OFBIZ-3626_framework_widget_xhtml.diff

> XHTML validation erros (framework/widget) Buggy render of fieldgroups in ModelForm
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Summary: XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm  (was: XHTML validation erros (framework/widget) Buggy render of fieldgroups in ModelForm)

> XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Description:
The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>


The same happen in:

Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store


Patch attached.

Don't use this patch, there are one page that still generates bad html. I'll post a new one when I solve the remaining issue.



  was:
The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>


The same happen in:

Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store


Patch attached.




> XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.
> Don't use this patch, there are one page that still generates bad html. I'll post a new one when I solve the remaining issue.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Description:
The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>


The same happen in:

Workeffort->Communications
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store

Patch attached.

Don't use the first patch, there is one page that still generates bad html.
Workeffort->Workeffort

Solved. Updated patch attached


  was:
The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>


The same happen in:

Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store


Patch attached.

Don't use this patch, there are one page that still generates bad html. I'll post a new one when I solve the remaining issue.




> XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml.diff, OFBIZ-3626_framework_widget_xhtml_v2.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.
> Don't use the first patch, there is one page that still generates bad html.
> Workeffort->Workeffort
> Solved. Updated patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Attachment: OFBIZ-3626_framework_widget_xhtml_v2.diff

> XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml.diff, OFBIZ-3626_framework_widget_xhtml_v2.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.
> Don't use the first patch, there is one page that still generates bad html.
> Workeffort->Workeffort
> Solved. Updated patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Attachment: OFBIZ-3626_framework_widget_xhtml_v3.diff

> XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml.diff, OFBIZ-3626_framework_widget_xhtml_v2.diff, OFBIZ-3626_framework_widget_xhtml_v3.diff
>
>
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> Patch attached.
> Don't use the first patch, there is one page that still generates bad html.
> Workeffort->Workeffort
> Solved. Updated patch attached

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Description:
Errors in ModelForm in fieldgroups and itemrows

**** The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>

The same happen in:

Workeffort->Communications
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store

** Rendering of itemrows can have duplicated <\td> when rendering links


Updated patch attached (v3)

  was:
Errors in ModelForm in fieldgroups and itemrows

The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>

The same happen in:

Workeffort->Communications
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store

In itemrows can be duplicated <\td> when rendering links

Updated patch attached (v3)


> XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml_v3.diff
>
>
> Errors in ModelForm in fieldgroups and itemrows
> **** The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> ** Rendering of itemrows can have duplicated <\td> when rendering links
> Updated patch attached (v3)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Description:
Errors in ModelForm in fieldgroups and itemrows

The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>

The same happen in:

Workeffort->Communications
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store

In itemrows can be duplicated <\td> when rendering links

Updated patch attached (v3)

  was:
The rendering of fieldgroups in ModelForm is wrong

As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)

<!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->

<form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
    <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
    <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
    <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
    <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
    <div class="fieldgroup" id="_G2_">
        <div class="fieldgroup-title-bar">
        </div>
            <div id="_G2__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">Enter existing Communication Event Id below</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G3_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G3__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
                    <tr>
                        <td class="label">Communication Event Id    </td>
                        <td colspan="4">
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                                ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
                            </script>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <table width="100%">
            <tr>
                <td align="left">
                    <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
                </td>
            </tr>
        </table>
        <div class="fieldgroup" id="_G4_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G4__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
---------------> The following tr close is wrong
                    </tr>
                    <tr>
                        <td class="label">Description    </td>
                        <td colspan="4">
                            <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
                        </td>
----------------> Here must be a tr close
                </table>
            </div>
        </div>
        <div class="fieldgroup" id="_G1_">
            <div class="fieldgroup-title-bar">
            </div>
            <div id="_G1__body" class="fieldgroup-body" >
                <table cellspacing="0" class="basic-table">
----------------> Here must be a tr open
                        <td class="label">Parent Comm Event Id    </td>
                        <td>
                            <div class="field-lookup">
                                <ul>
                                    <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
                                    <li>
                                        <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
                                            <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
                                        </a>
                                    </li>
                                </ul>
                            </div>
                            <script language="JavaScript" type="text/javascript">
                            ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
                            </script>
                        </td>


The same happen in:

Workeffort->Communications
Workeffort->Requirements
Projects->project->mailing lists
Party->Communications->Overview
Party->My Communications
Catalog->Stores->Shipping estimates
Catalog->Stores->Store

Patch attached.

Don't use the first patch, there is one page that still generates bad html.
Workeffort->Workeffort

Solved. Updated patch attached


        Summary: XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)  (was: XHTML validation errors (framework/widget) Buggy render of fieldgroups in ModelForm)

> XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml_v3.diff
>
>
> Errors in ModelForm in fieldgroups and itemrows
> The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> In itemrows can be duplicated <\td> when rendering links
> Updated patch attached (v3)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Attachment:     (was: OFBIZ-3626_framework_widget_xhtml.diff)

> XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml_v3.diff
>
>
> Errors in ModelForm in fieldgroups and itemrows
> **** The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> ** Rendering of itemrows can have duplicated <\td> when rendering links
> Updated patch attached (v3)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3626) XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3626:
-----------------------------------------

    Attachment:     (was: OFBIZ-3626_framework_widget_xhtml_v2.diff)

> XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml_v3.diff
>
>
> Errors in ModelForm in fieldgroups and itemrows
> **** The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> ** Rendering of itemrows can have duplicated <\td> when rendering links
> Updated patch attached (v3)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3626) XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-3626.
------------------------------

      Assignee: Bruno Busco
    Resolution: Fixed

Thank you Blas,
your slightly changed patch is in trunk at revision 932840

> XHTML validation errors (framework/widget) Bugs in ModelForm (fieldgroups, itemrows with links)
> -----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3626
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Bruno Busco
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3626_framework_widget_xhtml_v3.diff
>
>
> Errors in ModelForm in fieldgroups and itemrows
> **** The rendering of fieldgroups in ModelForm is wrong
> As an example, the beginning of the generated html for AddWorkEffortCommEvent in the page workeffort->communications is (the places where there are mistakes are marked with -----> comments)
> <!-- Begin  Form Widget - Form Element  component://workeffort/widget/WorkEffortCommEventForms.xml#AddWorkEffortCommEvent -->
> <form method="post" action="/workeffort/control/createCommunicationEvent" id="AddWorkEffortCommEvent" class="basic-form" onsubmit="javascript:submitFormDisableSubmits(this)" name="AddWorkEffortCommEvent">
>     <input type="hidden" name="workEffortId" value="9202" id="AddWorkEffortCommEvent_workEffortId"/>
>     <input type="hidden" name="action" id="AddWorkEffortCommEvent_action"/>
>     <input type="hidden" name="my" id="AddWorkEffortCommEvent_my"/>
>     <input type="hidden" name="messageId" id="AddWorkEffortCommEvent_messageId"/>
>     <div class="fieldgroup" id="_G2_">
>         <div class="fieldgroup-title-bar">
>         </div>
>             <div id="_G2__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">Enter existing Communication Event Id below</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G3_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G3__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
>                     <tr>
>                         <td class="label">Communication Event Id    </td>
>                         <td colspan="4">
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="communicationEventId" size="25" id="AddWorkEffortCommEvent_communicationEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.communicationEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_communicationEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                                 ajaxAutoCompleter('AddWorkEffortCommEvent_communicationEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=communicationEventId');
>                             </script>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <table width="100%">
>             <tr>
>                 <td align="left">
>                     <div class="tabletext">OR add new Communication Event data below to create new entity (leave Communication Event Id empty)</div>
>                 </td>
>             </tr>
>         </table>
>         <div class="fieldgroup" id="_G4_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G4__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ---------------> The following tr close is wrong
>                     </tr>
>                     <tr>
>                         <td class="label">Description    </td>
>                         <td colspan="4">
>                             <textarea name="description" cols="60" rows="3" id="AddWorkEffortCommEvent_description"></textarea>
>                         </td>
> ----------------> Here must be a tr close
>                 </table>
>             </div>
>         </div>
>         <div class="fieldgroup" id="_G1_">
>             <div class="fieldgroup-title-bar">
>             </div>
>             <div id="_G1__body" class="fieldgroup-body" >
>                 <table cellspacing="0" class="basic-table">
> ----------------> Here must be a tr open
>                         <td class="label">Parent Comm Event Id    </td>
>                         <td>
>                             <div class="field-lookup">
>                                 <ul>
>                                     <li><input type="text" name="parentCommEventId" size="25" id="AddWorkEffortCommEvent_parentCommEventId" autocomplete="off"/></li>
>                                     <li>
>                                         <a href="javascript:call_fieldlookup2(document.AddWorkEffortCommEvent.parentCommEventId,'LookupCommEvent');">
>                                             <span id="AddWorkEffortCommEvent_parentCommEventId_indicator" style="display: none" class="indicator"><img src="" alt=""/></span>
>                                         </a>
>                                     </li>
>                                 </ul>
>                             </div>
>                             <script language="JavaScript" type="text/javascript">
>                             ajaxAutoCompleter('AddWorkEffortCommEvent_parentCommEventId,/workeffort/control/LookupCommEvent,ajaxLookup=Y&amp;searchValueField=parentCommEventId');
>                             </script>
>                         </td>
> The same happen in:
> Workeffort->Communications
> Workeffort->Requirements
> Projects->project->mailing lists
> Party->Communications->Overview
> Party->My Communications
> Catalog->Stores->Shipping estimates
> Catalog->Stores->Store
> ** Rendering of itemrows can have duplicated <\td> when rendering links
> Updated patch attached (v3)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira