[jira] Created: (OFBIZ-3631) Badly formed from-field values (mis-matched curly braces)

[Nicolas Malin (Jira)]

Badly formed from-field values (mis-matched curly braces)
---------------------------------------------------------

                 Key: OFBIZ-3631
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3631
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Bob Morley


We were doing a scan of the Screen/Form xml files looking for badly formed usage of ${} in form-field (and others).  Can across a number of examples where there is only a trailing ending brace '}' which looks wrong.

If you do a regular expression search across xml files in the project using "[^"{]*} you should be able to find a number of these issues.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3631:
------------------------------

    Attachment: OFBIZ-3631_FixMismatchedBracets.patch

Very minor change -- there were six instances we came across where there were mis-match braces around typical uel expressions.  Five these of these were missing the starting brace and one of them was a from-field that had an ending brace.

Should be very low risk fix.

> Badly formed from-field values (mis-matched curly braces)
> ---------------------------------------------------------
>
>                 Key: OFBIZ-3631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3631
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3631_FixMismatchedBracets.patch
>
>
> We were doing a scan of the Screen/Form xml files looking for badly formed usage of ${} in form-field (and others).  Can across a number of examples where there is only a trailing ending brace '}' which looks wrong.
> If you do a regular expression search across xml files in the project using "[^"{]*} you should be able to find a number of these issues.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3631:
------------------------------

    Attachment: OFBIZ-3631_FixMismatchedBracets_Accounting.patch

NOTE: Additional Patch

Found another very minor issue with this text attribute:

text="${fixedAssetId} ${fixedAssetName ${instanceOfProductId} ${fixedAssetTypeId} "

I added the missing closing } on the fixedAssetName.

> Badly formed from-field values (mis-matched curly braces)
> ---------------------------------------------------------
>
>                 Key: OFBIZ-3631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3631
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3631_FixMismatchedBracets.patch, OFBIZ-3631_FixMismatchedBracets_Accounting.patch
>
>
> We were doing a scan of the Screen/Form xml files looking for badly formed usage of ${} in form-field (and others).  Can across a number of examples where there is only a trailing ending brace '}' which looks wrong.
> If you do a regular expression search across xml files in the project using "[^"{]*} you should be able to find a number of these issues.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES reassigned OFBIZ-3631:
-----------------------------------------

    Assignee: Erwan de FERRIERES

> Badly formed from-field values (mis-matched curly braces)
> ---------------------------------------------------------
>
>                 Key: OFBIZ-3631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3631
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Erwan de FERRIERES
>         Attachments: OFBIZ-3631_FixMismatchedBracets.patch, OFBIZ-3631_FixMismatchedBracets_Accounting.patch
>
>
> We were doing a scan of the Screen/Form xml files looking for badly formed usage of ${} in form-field (and others).  Can across a number of examples where there is only a trailing ending brace '}' which looks wrong.
> If you do a regular expression search across xml files in the project using "[^"{]*} you should be able to find a number of these issues.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin updated OFBIZ-3631:
-------------------------

    Patch Info: [Patch Available]

> Badly formed from-field values (mis-matched curly braces)
> ---------------------------------------------------------
>
>                 Key: OFBIZ-3631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3631
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Erwan de FERRIERES
>         Attachments: OFBIZ-3631_FixMismatchedBracets.patch, OFBIZ-3631_FixMismatchedBracets_Accounting.patch
>
>
> We were doing a scan of the Screen/Form xml files looking for badly formed usage of ${} in form-field (and others).  Can across a number of examples where there is only a trailing ending brace '}' which looks wrong.
> If you do a regular expression search across xml files in the project using "[^"{]*} you should be able to find a number of these issues.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-3631.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Done at rev 930202, thanks Bob.

> Badly formed from-field values (mis-matched curly braces)
> ---------------------------------------------------------
>
>                 Key: OFBIZ-3631
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3631
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3631_FixMismatchedBracets.patch, OFBIZ-3631_FixMismatchedBracets_Accounting.patch
>
>
> We were doing a scan of the Screen/Form xml files looking for badly formed usage of ${} in form-field (and others).  Can across a number of examples where there is only a trailing ending brace '}' which looks wrong.
> If you do a regular expression search across xml files in the project using "[^"{]*} you should be able to find a number of these issues.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.