[jira] Created: (OFBIZ-3633) Minimum order quantity
Locked
12
12
[jira] Created: (OFBIZ-3633) Minimum order quantity
 
|
Minimum order quantity
---------------------- Key: OFBIZ-3633 URL: https://issues.apache.org/jira/browse/OFBIZ-3633 Project: OFBiz Issue Type: New Feature Components: order, specialpurpose/ecommerce Reporter: Rishi Solanki Fix For: SVN trunk It will work as follows; We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. To achieve the above ; write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3633) Minimum order quantity
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-3633: -------------------------------- Attachment: OFBIZ-3633.patch Here is the patch for describe functionality. I have added data for product id WG-5569. Thanks to Rishi Solanki. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-3633: -------------------------------- Attachment: OFBIZ-3633.patch No changes , Only remove test variable declaration. { List test = new LinkedList();} > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853077#action_12853077 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- With reference to user list discussion here are our (Deepak and mine) thoughts; - We have posted the both solution on the list and elected to go with price constraints due to following reasons; 1) Here we do not need to change the existing entity definition, which is not a big deal if we add minimumOrderQuantiy field to Product entity. 2) If we want to add minimum order quantity for any product then we set the price which is of special type 'MINIMUM_ORDER_QUANTITY'. 3) In case of adding the field in product entity we need to check whether it will reflect on every UI of product related screens, in the current patch the Product Price screen already have support to add a special type of price. 4) For the ProductStore thing i.e the ProductStore may want different minimum order quantity for different stores, this will handle in the same way it will handle for adding product entity field. Here I mean to say that; it is not available for Product specific configuration as well ProductPrice specific configuration in either case we need to work on that. Finally we will accept the community decision, and upload the patch in a way which will be finalize by community. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853078#action_12853078 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- With reference to BJ comment; - The calculation done is considering that company want a Product to sell for minimum amount say $100.00 for a particular product P1 which has following prices - Special Promo - $5.00 Default Price - $10.00 List Price - $10.00 - Now the calculation result in this case 100/5 => 20 products, which is exactly pressing the $100.00 constraints. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853077#action_12853077 ] Rishi Solanki edited comment on OFBIZ-3633 at 4/3/10 5:22 AM: -------------------------------------------------------------- With reference to user list discussion here are our (Deepak and mine) thoughts; - We have posted the both solution on the list and elected to go with price constraints due to following reasons; 1) Here we do not need to change the existing entity definition, which is not a big deal if we add minimumOrderQuantiy field to Product entity. 2) If we want to add minimum order quantity for any product then we set the price which is of special type 'MINIMUM_ORDER_QUANTITY'. 3) In case of adding the field in product entity we need to check whether it will reflect on every UI of product related screens, in the current patch the Product Price screen already have support to add a special type of price. 4) For the ProductStore thing i.e the ProductStore may want different minimum order quantity for different stores, this will handle in the same way it will handle for adding product entity field. Here I mean to say that; it is not available for Product specific configuration as well ProductPrice specific configuration in either case we need to work on that. - Finally we will accept the community decision, and upload the patch in a way which will be finalize by community. was (Author: rishisolankii): With reference to user list discussion here are our (Deepak and mine) thoughts; - We have posted the both solution on the list and elected to go with price constraints due to following reasons; 1) Here we do not need to change the existing entity definition, which is not a big deal if we add minimumOrderQuantiy field to Product entity. 2) If we want to add minimum order quantity for any product then we set the price which is of special type 'MINIMUM_ORDER_QUANTITY'. 3) In case of adding the field in product entity we need to check whether it will reflect on every UI of product related screens, in the current patch the Product Price screen already have support to add a special type of price. 4) For the ProductStore thing i.e the ProductStore may want different minimum order quantity for different stores, this will handle in the same way it will handle for adding product entity field. Here I mean to say that; it is not available for Product specific configuration as well ProductPrice specific configuration in either case we need to work on that. Finally we will accept the community decision, and upload the patch in a way which will be finalize by community. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Issue Comment Edited: (OFBIZ-3633) Minimum order quantity
|
|
It seems to me that the restrictions as indicated are already modeled on the SupplierProduct entity. I believe this is the correct location; anyone that supplies that particular product would have those restrictions including minimumQuantity, quantityIncrement, etc. And generally speaking, all orders have a supplier -- for a sales order the supplier is simply the owner of those inventory items; OOB that would be the internal organization party named "Company".
Moreover, I would hope that the ShoppingCart / its related events and services would handle application of SupplierProduct to a WiP cart in a consistent manner. That is to say if you setup a sales order and your Company had this record, it should properly apply those rules to that cartitem line. I would speculate, however, this application is likely being made for orderType = PO. This is all from memory (I am not on my development machine) but I could envision a facility on the SupplierProduct entity. That would allow you to model the supplier that has multiple facilities with different rules. Consider the 3rd party supplier that has different rules for their Toledeo vs. Syracuse facilities. Similarly, your internal organization may have different rules based on one inventory facility vs. another. Would using the SupplierProduct for this purpose resolve your issue? There would likely be some business logic changes to ensure that they are being applied to OrderType = SO but hopefully no immediate model changes. |
Re: [jira] Issue Comment Edited: (OFBIZ-3633) Minimum order quantity
Administrator
|
Bob,
For the sake of history and searches, I think it would be better if you keep the comment in the Jira issue Thanks Jacques From: "Bob Morley" <[hidden email]> > > It seems to me that the restrictions as indicated are already modeled on the > SupplierProduct entity. I believe this is the correct location; anyone that > supplies that particular product would have those restrictions including > minimumQuantity, quantityIncrement, etc. And generally speaking, all orders > have a supplier -- for a sales order the supplier is simply the owner of > those inventory items; OOB that would be the internal organization party > named "Company". > > Moreover, I would hope that the ShoppingCart / its related events and > services would handle application of SupplierProduct to a WiP cart in a > consistent manner. That is to say if you setup a sales order and your > Company had this record, it should properly apply those rules to that > cartitem line. I would speculate, however, this application is likely being > made for orderType = PO. > > This is all from memory (I am not on my development machine) but I could > envision a facility on the SupplierProduct entity. That would allow you to > model the supplier that has multiple facilities with different rules. > Consider the 3rd party supplier that has different rules for their Toledeo > vs. Syracuse facilities. Similarly, your internal organization may have > different rules based on one inventory facility vs. another. > > Would using the SupplierProduct for this purpose resolve your issue? There > would likely be some business logic changes to ensure that they are being > applied to OrderType = SO but hopefully no immediate model changes. > -- > View this message in context: http://n4.nabble.com/jira-Created-OFBIZ-3633-Minimum-order-quantity-tp1749165p1750083.html > Sent from the OFBiz - Dev mailing list archive at Nabble.com. > |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853132#action_12853132 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- With respect to Bob's comment on dev list; Bob, I really like the idea of using the SupplierProduct entity for this functionality. If it looks fine to everyone then will look after it. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853137#action_12853137 ] Jacques Le Roux commented on OFBIZ-3633: ---------------------------------------- Here is Bob's comment on dev ML {quote} It seems to me that the restrictions as indicated are already modeled on the SupplierProduct entity. I believe this is the correct location; anyone that supplies that particular product would have those restrictions including minimumQuantity, quantityIncrement, etc. And generally speaking, all orders have a supplier -- for a sales order the supplier is simply the owner of those inventory items; OOB that would be the internal organization party named "Company". Moreover, I would hope that the ShoppingCart / its related events and services would handle application of SupplierProduct to a WiP cart in a consistent manner. That is to say if you setup a sales order and your Company had this record, it should properly apply those rules to that cartitem line. I would speculate, however, this application is likely being made for orderType = PO. This is all from memory (I am not on my development machine) but I could envision a facility on the SupplierProduct entity. That would allow you to model the supplier that has multiple facilities with different rules. Consider the 3rd party supplier that has different rules for their Toledeo vs. Syracuse facilities. Similarly, your internal organization may have different rules based on one inventory facility vs. another. Would using the SupplierProduct for this purpose resolve your issue? There would likely be some business logic changes to ensure that they are being applied to OrderType = SO but hopefully no immediate model changes. {quote} > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853724#action_12853724 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- Hi Team, Please let us know whether we need to go as we have following options; 1) Achieve this ProductPrice entity patch is attached with Jira. 2) Add a field to Product entity and go from that way. 3) Achieve this thru SupplierProduct entity. I personally like all the ways of achieving minimum order quantity, all has some pros and cons. Better if community finalize the way to achieve the functionality so that we can submit the patch. Thanks to all for their valuable suggestion. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
+1 for #3 - I think that follows the intended use from the data model
On Apr 6, 2010, at 12:10 AM, Rishi Solanki (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853724 > #action_12853724 ] > > Rishi Solanki commented on OFBIZ-3633: > -------------------------------------- > > Hi Team, > Please let us know whether we need to go as we have following options; > 1) Achieve this ProductPrice entity patch is attached with Jira. > 2) Add a field to Product entity and go from that way. > 3) Achieve this thru SupplierProduct entity. > > I personally like all the ways of achieving minimum order quantity, > all has some pros and cons. Better if community finalize the way to > achieve the functionality so that we can submit the patch. Thanks to > all for their valuable suggestion. > >> Minimum order quantity >> ---------------------- >> >> Key: OFBIZ-3633 >> URL: https://issues.apache.org/jira/browse/OFBIZ-3633 >> Project: OFBiz >> Issue Type: New Feature >> Components: order, specialpurpose/ecommerce >> Reporter: Rishi Solanki >> Fix For: SVN trunk >> >> Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch >> >> >> It will work as follows; >> We will set the special type price as 'MINIMUM_ORDER_PRICE' for a >> Product in ProductPrice entity. On the basis of it we will get the >> minimum order quantity of the product on the basis of this price >> and sale price. >> Will get the minimum order quantity for product by division. For >> example we have selling price of product P1 is $10.00 and its >> MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the >> product will be --> 100/10 ==> 10. >> To achieve the above ; >> write a getMinimumOrderQuantity() method in ShoppingCart.java which >> takes the itemBasePrice and productId as in parameter, and call it >> where we add, update the cart items and change the quantity to >> minmumOrderQuantity if it is less then minimum. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854320#action_12854320 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- Robert Morley comment on dev ML: - +1 for #3 - I think that follows the intended use from the data model > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854321#action_12854321 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- Me too agree on #3, but like to wait for Scott, Jacques, and other members comments on this. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854324#action_12854324 ] Scott Gray commented on OFBIZ-3633: ----------------------------------- Hi Rishi, {quote} 1) Achieve this ProductPrice entity patch is attached with Jira. {quote} The attached patch doesn't seem to make any changes to the ProductPrice entity? At this stage I'm in favor of one simply because it doesn't change the entity model and still achieves (in theory) the current requirements. If we go for a different approach furhter down the track at least we won't have to deal with deprecating any entity fields. I don't see how SupplierProduct could be used without it being fairly messy. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854329#action_12854329 ] Rishi Solanki commented on OFBIZ-3633: -------------------------------------- Yes Scott, in case of ProductPrice we do not need to change any entity definition. In case of SupplierProduct entity as Bob specified the 'partyId' will be 'company' i.e the party which owns the product store. And we need to add code for the Sales Order as done for Purchase Order. Please add some value to this, will go thru the way which will be finalized. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854338#action_12854338 ] Scott Gray commented on OFBIZ-3633: ----------------------------------- Currently ProductPrice is used for selling goods and SupplierProduct is used for purchasing goods, I don't like the idea of blurring the lines between the two unnecessarily. Using that entity just because it happens to have a minimum quantity field on it seems like a bit of a stretch to me. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854342#action_12854342 ] Deepak Dixit commented on OFBIZ-3633: ------------------------------------- Thanks Scott, That means we are fine with #1 (Achieve through ProductPrice).So we can proceed with the attached patch. Thanks for help in concluding. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
You are right this may be a stretch, but how it is currently used should not dictate how things should be properly modeled. From my perspective, SupplierProduct was a relationship between a Party (the person supplying products) and a product. From a sales order perspective, the supplier for products in that order is generally the inventory item order (the Company). It did not seem a massive stretch to suggest that Orders use SupplierProduct consistently regardless if they are of type PO or SO. Having said that, I still do not content it is absolutely the right solution -- only it should be considered as one. Not looking at e-commerce, but how would one sell a product that I have to buy a minimum of 100 of in quantities of 25. Once you add your minimum quantity support I am sure increment comes next ... :) Is there something in ProductFeature that fits? (Gift Card demo data with selectable amounts just came to mind). |
[jira] Commented: (OFBIZ-3633) Minimum order quantity
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854372#action_12854372 ] Jacques Le Roux commented on OFBIZ-3633: ---------------------------------------- I agree with Scott, and actually with Deepak and Rishi's 1st intent. Only code change, if possible and not convoluted, is always better IMO. > Minimum order quantity > ---------------------- > > Key: OFBIZ-3633 > URL: https://issues.apache.org/jira/browse/OFBIZ-3633 > Project: OFBiz > Issue Type: New Feature > Components: order, specialpurpose/ecommerce > Reporter: Rishi Solanki > Fix For: SVN trunk > > Attachments: OFBIZ-3633.patch, OFBIZ-3633.patch > > > It will work as follows; > We will set the special type price as 'MINIMUM_ORDER_PRICE' for a Product in ProductPrice entity. On the basis of it we will get the minimum order quantity of the product on the basis of this price and sale price. > Will get the minimum order quantity for product by division. For example we have selling price of product P1 is $10.00 and its MINIMUM_ORDER_PRICE is $100.00 then minimum order quantity for the product will be --> 100/10 ==> 10. > To achieve the above ; > write a getMinimumOrderQuantity() method in ShoppingCart.java which takes the itemBasePrice and productId as in parameter, and call it where we add, update the cart items and change the quantity to minmumOrderQuantity if it is less then minimum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |