[jira] Created: (OFBIZ-367) orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown

[Nicolas Malin (Jira)]

orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
--------------------------------------------------------------------------------------------------

                 Key: OFBIZ-367
                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: order
            Reporter: Chris Howe
            Priority: Trivial


On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-367?page=all ]

Chris Howe updated OFBIZ-367:
-----------------------------

    Attachment: orderheader.ftl.patch

orderheader.ftl.patch

takes the shipgroup.contactMechId for the order and forces it to be selected and makes the blank one disabled (shows it when there are additional options, but is not selectable)

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>            Priority: Trivial
>         Attachments: orderheader.ftl.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12440843 ]
           
Jacques Le Roux commented on OFBIZ-367:
---------------------------------------

Hi Chris,

There is no more applications/order/webapp/ordermgr/order/orderheader.ftl file in repository (see
http://svn.apache.org/repos/asf/incubator/ofbiz/trunk/applications/order/webapp/ordermgr/order/) (you are using a revision 450674)

Now content of your file seems more related to applications/order/webapp/ordermgr/order/ordershippinginfo.ftl.

This comment from Jacopo's commit (rev 452766) is the clue :

Break up of orderheader templates (for order confirm and order view screens) and the showPromotions template with multiple screenlets: this should improve the template readability and also make the customization much more simple.
Really thanks to Chris Howe for this work (OFBIZ-68): I had to manually apply the patch (many templates were changed after the patch was submitted, and in the patch there were some issues) and so I did something different from Chris' patch, however his work is now finally committed.
I've also removed some unused resources from the ecommerce component (a few entries in the controller, a screen definition and a template).

You may send a new patch and I will review it but please be carefull about revison when submiting, thanks.

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>            Priority: Trivial
>         Attachments: orderheader.ftl.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12450807 ]
           
Si Chen commented on OFBIZ-367:
-------------------------------

Chris, if you can submit an updated patch it would speed things along.

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: orderheader.ftl.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-367?page=all ]

Si Chen reassigned OFBIZ-367:
-----------------------------

    Assignee: Si Chen

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: orderheader.ftl.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-367?page=all ]

Chris Howe updated OFBIZ-367:
-----------------------------

    Attachment: ordershipping.patch

patch redone against more recent revision

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: orderheader.ftl.patch, ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-367?page=all ]

Jacopo Cappellato updated OFBIZ-367:
------------------------------------

    Attachment:     (was: orderheader.ftl.patch)

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12458268 ]
           
Jacques Le Roux commented on OFBIZ-367:
---------------------------------------

Chris,

Your patch seems good and I wanted to apply it. But I did not reproduce your problem have you an use case please ?

Thanks

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12458280 ]
           
Chris Howe commented on OFBIZ-367:
----------------------------------

Unfortunately I'm using this patch in my development setup, so I can't verify explicitly what the problem was, but if I remember correctly, if you changed the shipping location, and submitted the change the default text in the dropdown options would be blank.

A)<option value="100">Current Place</option
B)<option value="100"></option
C)<option value="101">Some Other Place</option

since the value = 100 it would display B as default instead of A as expected.

This may have just been a firefox issue, either way this prevents the blank line from being selectable and still keeps the separation of the current value from the possible values.

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12458291 ]
           
Jacques Le Roux commented on OFBIZ-367:
---------------------------------------

Thanks Chris,

I will try tomorrow...

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12458293 ]
           
Jacques Le Roux commented on OFBIZ-367:
---------------------------------------

Mmm, I quicly tried (created a new shipping address for democustomer, changed to it in ordre view, reloaded order)  : I can't reproduce (Client on Win2K Firefox 1.5, Server Ubuntu Hoary)

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12458301 ]
           
Chris Howe commented on OFBIZ-367:
----------------------------------

I guess I don't remember what specifically the issue was then.  In any event, I would imagine one would prefer the user not be able to select the blank line as there is a bit of ambiguity as to it's result and the patch would still be beneficial.

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12458920 ]
           
Jacques Le Roux commented on OFBIZ-367:
---------------------------------------

I agree Chris,

Your patch is in OFBiz revision 487654  

Thanks

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-367?page=comments#action_12459169 ]
           
Chris Howe commented on OFBIZ-367:
----------------------------------

Can we close this issue now?

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Si Chen
>            Priority: Trivial
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-367?page=all ]

Jacques Le Roux closed OFBIZ-367.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: Jacques Le Roux  (was: Si Chen)

Sorry Chris,

I missed it, done !

> orderview dropdown of destination addresses sometimes doesn't show information as text in dropdown
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-367
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-367
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: ordershipping.patch
>
>
> On occasion (when orderview is reloaded) the text in the selected dropdown box for the is blank.  Blank gives the same value as what should be showing, but displays it blank.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira