Pass Accounting label to Common Label
------------------------------------- Key: OFBIZ-3694 URL: https://issues.apache.org/jira/browse/OFBIZ-3694 Project: OFBiz Issue Type: Improvement Components: accounting, framework Affects Versions: SVN trunk Reporter: nicolas malin Priority: Minor Fix For: SVN trunk I pass two generic label from accounting component to common component: AccountingNoResultFound -> CommonNoResultFound AccountingNotAssign -> CommonNotAssign Nicolas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3694: --------------------------------- Attachment: accountingToCommonLabel.patch > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-3694: ----------------------------------------- Assignee: Erwan de FERRIERES > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856811#action_12856811 ] Erwan de FERRIERES commented on OFBIZ-3694: ------------------------------------------- Nicolas, thanks for the patch, committed at r933890. I'm not closing this issue as some NoRecordFound can be found in webtools and ecommerce > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3694: --------------------------------- Attachment: accountingToCommonLabel-pass2.patch NoRecorsFound : It's no exaclty the same label ;) but I correct ecommerce and webtools also I take ecommerce traduction on Common because it's contains more language > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857096#action_12857096 ] Jacques Le Roux commented on OFBIZ-3694: ---------------------------------------- Nicolas, Erwan, I wonder if we should remove them. Can another commiter give his opinion? > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862300#action_12862300 ] nicolas malin commented on OFBIZ-3694: -------------------------------------- Just on up, an other commiter can give his opinion ? tks by advance ;) Nicolas > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862554#action_12862554 ] Jacques Le Roux commented on OFBIZ-3694: ---------------------------------------- My opinion is just because we have a little loss of information ("for the entity") in Webtools. So I wonder if we should not keep WebtoolsNoRecordsFound, not a big deal anyway... Any other opinions? > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865718#action_12865718 ] Nicolas Malin commented on OFBIZ-3694: -------------------------------------- Ok jacques, It's possible to rename WebtoolsNoRecordsFound to WebtoolsNoEntityRecordsFound ? > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865721#action_12865721 ] Jacques Le Roux commented on OFBIZ-3694: ---------------------------------------- Hi Nicolas, Yes sure, go ahead Thanks > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-3694: --------------------------------- Attachment: OFBIZ-3694.patch Pass WebtoolsNoRecordFound to WebtoolsNoEntityRecordFound > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch, OFBIZ-3694.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3694. ---------------------------------- Resolution: Fixed Thanks Nicolas, Your last patch is in trunk at r942818 > Pass Accounting label to Common Label > ------------------------------------- > > Key: OFBIZ-3694 > URL: https://issues.apache.org/jira/browse/OFBIZ-3694 > Project: OFBiz > Issue Type: Improvement > Components: accounting, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch, OFBIZ-3694.patch > > > I pass two generic label from accounting component to common component: > AccountingNoResultFound -> CommonNoResultFound > AccountingNotAssign -> CommonNotAssign > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
thanks too jacques for your review ;)
Jacques Le Roux (JIRA) a écrit : > [ https://issues.apache.org/jira/browse/OFBIZ-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Jacques Le Roux closed OFBIZ-3694. > ---------------------------------- > > Resolution: Fixed > > Thanks Nicolas, > > Your last patch is in trunk at r942818 > > > >> Pass Accounting label to Common Label >> ------------------------------------- >> >> Key: OFBIZ-3694 >> URL: https://issues.apache.org/jira/browse/OFBIZ-3694 >> Project: OFBiz >> Issue Type: Improvement >> Components: accounting, framework >> Affects Versions: SVN trunk >> Reporter: Nicolas Malin >> Assignee: Erwan de FERRIERES >> Priority: Minor >> Fix For: SVN trunk >> >> Attachments: accountingToCommonLabel-pass2.patch, accountingToCommonLabel.patch, OFBIZ-3694.patch >> >> >> I pass two generic label from accounting component to common component: >> AccountingNoResultFound -> CommonNoResultFound >> AccountingNotAssign -> CommonNotAssign >> Nicolas >> > > |
Free forum by Nabble | Edit this page |