[jira] Created: (OFBIZ-3706) updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record

[Nicolas Malin (Jira)]

updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record
---------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-3706
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3706
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Divesh Dutta
            Priority: Minor
             Fix For: SVN trunk


updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record. This should be dependent on context variable statusId

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-3706:
--------------------------------

    Attachment: OFBiz-3706.patch

Attached patch resolve the issue described in description.

> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3706
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3706
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3706.patch
>
>
> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record. This should be dependent on context variable statusId

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858089#action_12858089 ]

Pranay Pandey commented on OFBIZ-3706:
--------------------------------------

Thanks for the contribution Divesh. I reviewed your patch and it looks good to me.

> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3706
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3706
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3706.patch
>
>
> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record. This should be dependent on context variable statusId

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3706:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3706
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3706
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3706.patch
>
>
> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record. This should be dependent on context variable statusId

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3706.
--------------------------------------

    Resolution: Fixed

Thanks Divesh & Pranay for the contribution - Committed at r935123.

--
Ashish Vijaywargiya

> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3706
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3706
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Divesh Dutta
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz-3706.patch
>
>
> updateOrderPaymentPreference service should not be dependent on flag cancelThis to cancel status of OrderPaymentPreference record. This should be dependent on context variable statusId

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira