OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3747) ProductStore missing field title help

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

25 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3747) ProductStore missing field title help

ProductStore missing field title help
-------------------------------------

Key: OFBIZ-3747
URL: https://issues.apache.org/jira/browse/OFBIZ-3747
Project: OFBiz
Issue Type: Sub-task
Components: product
Affects Versions: Release Candidate Branch 10.04, SVN trunk
Reporter: chris snow
Fix For: Release Candidate Branch 10.04, SVN trunk
Attachments: productStoreFieldDescriptions.patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3747) ProductStore missing field title help

> ProductStore missing field title help
> -------------------------------------
>
> Key: OFBIZ-3747
> URL: https://issues.apache.org/jira/browse/OFBIZ-3747
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Candidate Branch 10.04, SVN trunk
> Reporter: chris snow
> Fix For: Release Candidate Branch 10.04, SVN trunk
>
> Attachments: productStoreFieldDescriptions.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862214#action_12862214 ]

chris snow commented on OFBIZ-3747:
-----------------------------------

The attached patch only adds field description text and does not make any other structural changes to the ofbiz code base.

Would any dev's be happy to commit? BTW, am I being too pushy again?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862222#action_12862222 ]

Jacques Le Roux commented on OFBIZ-3747:
----------------------------------------

At 1st glance, I'm not sure we want to have the labels as you done for isImmediatelyFulfilled, checkInventory, storeCreditAccountEnumId, etc. I think we should better follow the format we used so far for all labels. Only my opinions though, maybe not a big deal.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862226#action_12862226 ]

chris snow commented on OFBIZ-3747:
-----------------------------------

Hi Jacques, were you expecting to see a different 'value' for the label, or were you expecting to see a different key name?

{code}
<property key="FieldDescription.ProductStore.isImmediatelyFulfilled">
<value xml:lang="en">
Should an order be immediately fulfilled through system-generated processes
in the Warehouse, Accounting, Shipping, Inventory and/or other segments of the business. If the fulfillment process is
held for a manual or credit review and approval of the order first, this answer should be No. In fact, the only likely
time this would be set to Yes is for a POS operation (Point Of Sale) where the item is only sold off the shelf and
handed directly to the customer or the customer 'shops' the store then pays at a checkout station.
</value>
</property>
{code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862229#action_12862229 ]

Adrian Crum commented on OFBIZ-3747:
------------------------------------

Chris,

From my perspective, descriptions like that border on online help. The line between a tooltip and a more comprehensive online help system is being blurred.

In my opinion (take it for what it is worth) a tooltip should be somewhere between a terse field label and full help text. In you example above, the tooltip would be the first sentence only. If the user needs more information, they can click the Help link and find the rest of your text.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862230#action_12862230 ]

Jacques Le Roux commented on OFBIZ-3747:
----------------------------------------

I spoke only about the format and the fact that the lines are wrapped and the 1st does not begin just after value xml:lang="en"> and the last does not include </value>
Actually should be only one line, even if long, but this point may be discussed. Did you intend to have multi lines in the tooltip? Because this depends actually from the browser and its context.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862233#action_12862233 ]

Jacques Le Roux commented on OFBIZ-3747:
----------------------------------------

I did not saw Adrian's comment, I thought also afterward that the lentght of tooltips is limited and browser dependent...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862235#action_12862235 ]

chris snow commented on OFBIZ-3747:
-----------------------------------

Jacques,

I only wrapped it to make it easier to read in the file as multiple lines rather than one really long line. I'll change it to one line, and set my editor to wrap when modifying the property file.

Many thanks,

Chris

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862247#action_12862247 ]

Jacques Le Roux commented on OFBIZ-3747:
----------------------------------------

Chris,

Like Adrian I think we should not try to put to much information in tooltips, the main reason for me is that their lenght is limited or the duration to read it. We could then use something else for tooltips (there are CSS tips and JS scripts) but I'm not sure we want that... Did you try to look at some long helps you wrote in different browers?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862254#action_12862254 ]

chris snow commented on OFBIZ-3747:
-----------------------------------

Jacques/Adrian,

It's like we need three levels of help:

1) short field description tooltips -max one line (e.g. 80 chars)
2) longer field descriptions (if necessary)
3) detailed help describing workflow, etc

I think level 2 help would be useful to get a full field description without going to the help system. We could have level 2 help by say right clicking on the field title and using a javascript popup. Is there a way to ensure every form page includes a javascript library like Tooltips.js?

Many thanks for your feedback!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862261#action_12862261 ]

Jacques Le Roux commented on OFBIZ-3747:
----------------------------------------

Yes, just put it in GlobalDecorator

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862262#action_12862262 ]

Adrian Crum commented on OFBIZ-3747:
------------------------------------

Chris,

A JavaScript popup sounds like a good compromise. One more bit of advice - try to find a way to extract the popup text from the online help file - even if that means the online help system needs to be redesigned a little. The reason I suggest that is because I can foresee two help systems with contradictory information or one system that is kept updated while the other isn't.

I global JavaScript file can be loaded in the GlobalDecorator.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

chris snow-2

Re: [jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

Where is the global decorator? Is

On 29 Apr 2010 18:14, "Jacques Le Roux (JIRA)" <[hidden email]> wrote:

[
https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862261#action_12862261]

Jacques Le Roux commented on OFBIZ-3747:
----------------------------------------
Yes, just put it in GlobalDecorator

> ProductStore missing field title help
> -------------------------------------
>
> ...

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-3747) ProductStore missing field title help

Administrator

Just look for GlobalDecorator in *een*.xml files...

Jacques

From: "chris snow" <[hidden email]>

> Where is the global decorator? Is
>
> On 29 Apr 2010 18:14, "Jacques Le Roux (JIRA)" <[hidden email]> wrote:
>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862261#action_12862261]
>
>
> Jacques Le Roux commented on OFBIZ-3747:
> ----------------------------------------
> Yes, just put it in GlobalDecorator
>
>
>> ProductStore missing field title help
>> -------------------------------------
>>
>> ...
>

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-3747:
------------------------------

Attachment: productStoreFieldDescriptions2.patch

productStoreFieldDescriptions2.patch addresses the issues raised by Jacques and Adrian regarding tooltip title length and format of messages. It would be good to get it applied and get some feedback from the wider user base.

I am investigating using javascript for improved help popups, but that improvement can be done under a separate issue. In the meantime the attached patch can still be applied.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862993#action_12862993 ]

Bruno Busco commented on OFBIZ-3747:
------------------------------------

+1 on having a sort of "structured" help page in the help file that would allow to extract the "short description" and show it in the tooltip.
Clicking in the tooltip the complete help page could be shown (in the help window) with the full field description.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863036#action_12863036 ]

chris snow commented on OFBIZ-3747:
-----------------------------------

Hi Bruno, that's my goal - I've much to learn about prototype yet, I've got some stuff working with tooltips.js and popup.js - but still need to do more experimenting...

> ProductStore missing field title help
> -------------------------------------
>
> Key: OFBIZ-3747
> URL: https://issues.apache.org/jira/browse/OFBIZ-3747
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 10.04, SVN trunk
> Reporter: chris snow
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: productStoreFieldDescriptions.patch, productStoreFieldDescriptions2.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863336#action_12863336 ]

chris snow commented on OFBIZ-3747:
-----------------------------------

Hi Devs, anyone interested in committing this for 10.04 and trunk?

This will be the first step in providing actual field help tooltips, starting with the ProductStore entity. It's going to be a long journey to get all the help text extracted from the reference guides (below) for all the other entities, so I'm keen to get this process started!

https://cwiki.apache.org/confluence/pages/viewpageattachments.action?pageId=8192153&metadataLink=true#

Many thanks,

Chris

> ProductStore missing field title help
> -------------------------------------
>
> Key: OFBIZ-3747
> URL: https://issues.apache.org/jira/browse/OFBIZ-3747
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 10.04, SVN trunk
> Reporter: chris snow
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: productStoreFieldDescriptions2.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3747) ProductStore missing field title help

In reply to this post by Nicolas Malin (Jira)

> ProductStore missing field title help
> -------------------------------------
>
> Key: OFBIZ-3747
> URL: https://issues.apache.org/jira/browse/OFBIZ-3747
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 10.04, SVN trunk
> Reporter: chris snow
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: productStoreFieldDescriptions2.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.