Mini Patch of Party Component
----------------------------- Key: OFBIZ-376 URL: http://issues.apache.org/jira/browse/OFBIZ-376 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: party Affects Versions: SVN trunk Environment: Linux(CentOS)/Windows XP,Firefox Reporter: Ashish Vijaywargiya Priority: Minor Attachments: Party_Comm_Small_Change_Oct_14.patch.zip Hi, This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. And I have made small change in SecurityForm.xml. Can anybody of commit my patch ??? Regards Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ http://issues.apache.org/jira/browse/OFBIZ-376?page=all ]
Ashish Vijaywargiya updated OFBIZ-376: -------------------------------------- Attachment: Party_Comm_Small_Change_Oct_14.patch.zip > Mini Patch of Party Component > ----------------------------- > > Key: OFBIZ-376 > URL: http://issues.apache.org/jira/browse/OFBIZ-376 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Linux(CentOS)/Windows XP,Firefox > Reporter: Ashish Vijaywargiya > Priority: Minor > Attachments: Party_Comm_Small_Change_Oct_14.patch.zip > > > Hi, > This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). > Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. > And I have made small change in SecurityForm.xml. > Can anybody of commit my patch ??? > Regards > Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-376?page=comments#action_12442334 ]
Jacques Le Roux commented on OFBIZ-376: --------------------------------------- Hi Ashish, I'm not sure this is a good idea in the way you propose. Because if we do so we will loose the "CommEvent" "Purposes" "Roles" "WorkEfforts" and "Content" buttons. Why did you suppress them in your patch ? Thanks > Mini Patch of Party Component > ----------------------------- > > Key: OFBIZ-376 > URL: http://issues.apache.org/jira/browse/OFBIZ-376 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Linux(CentOS)/Windows XP,Firefox > Reporter: Ashish Vijaywargiya > Priority: Minor > Attachments: Party_Comm_Small_Change_Oct_14.patch.zip > > > Hi, > This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). > Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. > And I have made small change in SecurityForm.xml. > Can anybody of commit my patch ??? > Regards > Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-376?page=comments#action_12442340 ]
Ashish Vijaywargiya commented on OFBIZ-376: ------------------------------------------- Thx Jacques for your comment, I didn't suppress anything in my patch.I just added <container></container> block at the bottom of <include> tag. Actually the code for button's that you specified is shifted from the original lines. You just try my patch.You will not loose any of previous code. After applying and testing my patch you will find what I was trying to change in this patch. Please let me know if you won't get statisfied with my patch after testing it. Don't worry the button you specified will remain in their place. Regards Ashish Vijaywargiya > Mini Patch of Party Component > ----------------------------- > > Key: OFBIZ-376 > URL: http://issues.apache.org/jira/browse/OFBIZ-376 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Linux(CentOS)/Windows XP,Firefox > Reporter: Ashish Vijaywargiya > Priority: Minor > Attachments: Party_Comm_Small_Change_Oct_14.patch.zip > > > Hi, > This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). > Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. > And I have made small change in SecurityForm.xml. > Can anybody of commit my patch ??? > Regards > Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-376?page=all ]
Ashish Vijaywargiya updated OFBIZ-376: -------------------------------------- Attachment: CommunicationEvent.png Jacques Please see the attached image. I hope you will get satisfied after viewing this screenshot. Regards Ashish Vijaywargiya > Mini Patch of Party Component > ----------------------------- > > Key: OFBIZ-376 > URL: http://issues.apache.org/jira/browse/OFBIZ-376 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Linux(CentOS)/Windows XP,Firefox > Reporter: Ashish Vijaywargiya > Priority: Minor > Attachments: CommunicationEvent.png, Party_Comm_Small_Change_Oct_14.patch.zip > > > Hi, > This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). > Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. > And I have made small change in SecurityForm.xml. > Can anybody of commit my patch ??? > Regards > Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-376?page=all ]
Jacques Le Roux closed OFBIZ-376. --------------------------------- Fix Version/s: SVN trunk Resolution: Fixed Assignee: Jacques Le Roux Ashish, Sorry I tried you patch and quickly compared with https://test.opentravelsystem.org/partymgr/control/ListPartyCommEvents?partyId=admin that it has not been recently updated. I should have been further to see that ListPartyCommEvents it's not the screen you changed but EditCommunicationEvent. Your patch is now in OFBiz, revision 464114. Thanks for your help and tenacity ;o) ! > Mini Patch of Party Component > ----------------------------- > > Key: OFBIZ-376 > URL: http://issues.apache.org/jira/browse/OFBIZ-376 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Linux(CentOS)/Windows XP,Firefox > Reporter: Ashish Vijaywargiya > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: CommunicationEvent.png, Party_Comm_Small_Change_Oct_14.patch.zip > > > Hi, > This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). > Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. > And I have made small change in SecurityForm.xml. > Can anybody of commit my patch ??? > Regards > Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-376?page=comments#action_12442388 ]
Ashish Vijaywargiya commented on OFBIZ-376: ------------------------------------------- Thx Jacques. You and others are very supportive. Thx for your support. Regards Ashish Vijaywargiya > Mini Patch of Party Component > ----------------------------- > > Key: OFBIZ-376 > URL: http://issues.apache.org/jira/browse/OFBIZ-376 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Linux(CentOS)/Windows XP,Firefox > Reporter: Ashish Vijaywargiya > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: CommunicationEvent.png, Party_Comm_Small_Change_Oct_14.patch.zip > > > Hi, > This is the mini patch to standarise the Communication tab with the other tab in Edit Profile(of Party Component). > Now it will include the Billing Account,Orders,New Orders,Payment Sent,Payment Recieved buttons as those comes under other tabs. > And I have made small change in SecurityForm.xml. > Can anybody of commit my patch ??? > Regards > Ashish Vijaywargiya -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |