OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3764) Storing supplier relationship sub-class & two related fixes

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3764) Storing supplier relationship sub-class & two related fixes

Storing supplier relationship sub-class & two related fixes
-----------------------------------------------------------

Key: OFBIZ-3764
URL: https://issues.apache.org/jira/browse/OFBIZ-3764
Project: OFBiz
Issue Type: Bug
Components: party, product
Reporter: Bob Morley
Fix For: SVN trunk
Attachments: OFBIZ-3764_SupplierRel.patch

Despite how much I typed; this is really a very small patch. :)

This patch adds a new entity "SupplierRel" which is a sub-class of "PartyRelationship" (as well as a view-entity for convenience). It provides a new field "accountNumber" that can be used to store the long-term account number assigned to the relationship between the Company and its Supplier. The life of this account number is longer than any agreement between the two, so it has been put on this informal relationship. Moreover, it is possible to have an informal relationship between a company and a supplier with out an explicit binding agreement -- this was discussed most recently in this thread:

http://ofbiz.135035.n4.nabble.com/Storing-supplier-provided-account-number-td2076162.html#a2076162

ALSO -- this patch fixes two problems that I encountered when attempting to create a party relationship.

a) It did not look right to have an empty dropdown for status -- I created the standard "Created" status under the PARTY_REL_STATUS type so that we show the only applicable status. There does not appear to be any specific logic looking for party relationships with a blank status, so creating ones with this status should not cause any issues.

b) When creating the PartyRelationship the response in the controller was of type "view-last" which was a problem because the last controller request was typically the ajax one to "FindPartyName" which was used as part of the party lookup field in that form. The net result, was that on success it would render the PartyName instead of replaying the EditPartyRelationships. Changed form "view-last" to "view" to resolve this issue.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3764) Storing supplier relationship sub-class & two related fixes

[ https://issues.apache.org/jira/browse/OFBIZ-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3764:
------------------------------

Attachment: OFBIZ-3764_SupplierRel.patch

Quick note: generally I would create individual patches for this; but because they were so small I included them in a single patch file. Feel free to split up the "two minor fixes" from the enhancement if so desired.

> Storing supplier relationship sub-class & two related fixes
> -----------------------------------------------------------
>
> Key: OFBIZ-3764
> URL: https://issues.apache.org/jira/browse/OFBIZ-3764
> Project: OFBiz
> Issue Type: Bug
> Components: party, product
> Reporter: Bob Morley
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3764_SupplierRel.patch
>
>
> Despite how much I typed; this is really a very small patch. :)
> This patch adds a new entity "SupplierRel" which is a sub-class of "PartyRelationship" (as well as a view-entity for convenience). It provides a new field "accountNumber" that can be used to store the long-term account number assigned to the relationship between the Company and its Supplier. The life of this account number is longer than any agreement between the two, so it has been put on this informal relationship. Moreover, it is possible to have an informal relationship between a company and a supplier with out an explicit binding agreement -- this was discussed most recently in this thread:
> http://ofbiz.135035.n4.nabble.com/Storing-supplier-provided-account-number-td2076162.html#a2076162
> ALSO -- this patch fixes two problems that I encountered when attempting to create a party relationship.
> a) It did not look right to have an empty dropdown for status -- I created the standard "Created" status under the PARTY_REL_STATUS type so that we show the only applicable status. There does not appear to be any specific logic looking for party relationships with a blank status, so creating ones with this status should not cause any issues.
> b) When creating the PartyRelationship the response in the controller was of type "view-last" which was a problem because the last controller request was typically the ajax one to "FindPartyName" which was used as part of the party lookup field in that form. The net result, was that on success it would render the PartyName instead of replaying the EditPartyRelationships. Changed form "view-last" to "view" to resolve this issue.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3764) Storing supplier relationship sub-class & two related fixes

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865023#action_12865023 ]

Jacques Le Roux commented on OFBIZ-3764:
----------------------------------------

This looks good to me, though I did not check the PartyTypeData issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.