[jira] Created: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
Locked
[jira] Created: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
 
|
Use CustumMethod for select order, quote and invoice hook to resolve id
----------------------------------------------------------------------- Key: OFBIZ-3765 URL: https://issues.apache.org/jira/browse/OFBIZ-3765 Project: OFBiz Issue Type: Improvement Components: accounting, order Affects Versions: SVN trunk Reporter: nicolas malin Fix For: SVN trunk Attachments: hookByPartyAcctgPreference.patch Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. The patch contains : * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation * Add service enforced ans restart define previously by enumeration * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context * Add error message if PartyAcctgPreference not define. * Apply on invoice, quote an order To test just ant clean-all && ant run-install and create quote, order and invoice Thanks to Leila Mekika for the help Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3765: --------------------------------- Attachment: hookByPartyAcctgPreference.patch > Use CustumMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865182#action_12865182 ] Bob Morley commented on OFBIZ-3765: ----------------------------------- I like this concept a lot. However, I wonder if it can be implemented by making use of the overriding nature of services rather than an entity model change? Similar to what you have done, pull out the implementation into a "getNextInvoiceId", "getNextOrderId", and "getNextQuoteId" and have the create service invoke this regardless. Then if you have your own custom implementation, you would just redefine the service definition in your hot-deploy component to point to your new implementation. Services are (generally) in a global space so this overriding behaviour is based on the load sequence dictated by component type (framework, application, special purpose, hot-deploy) and from with-in there the ordering in the component-load.xml file (may have to double check that last statement). :) Would think that the "getNextInvoiceId" would use the acctg preferences to vector off to the "enforced" and "restart" service if you want to keep those two implementations separated (which is a good idea). > Use CustumMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865716#action_12865716 ] nicolas malin commented on OFBIZ-3765: -------------------------------------- Thanks bob for your return :) I think, use a service surchage to define a specifc customer resolve Id will be a good idea if you have only one society on your OBiz instance. But with tenant, you will can many society on one OFbiz instance. So if you have a service list to resolve id in your components, you need manage it in database. Nicolas > Use CustumMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865788#action_12865788 ] Bob Morley commented on OFBIZ-3765: ----------------------------------- Ahh yes that is an excellent point. Unless you can determine the implementation from the enumeration on acctg preference, you certainly have to do it this way. > Use CustumMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustumMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866516#action_12866516 ] Erwan de FERRIERES commented on OFBIZ-3765: ------------------------------------------- Any news on this issue ? > Use CustumMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-3765: ------------------------------------- Summary: Use CustomMethod for select order, quote and invoice hook to resolve id (was: Use CustumMethod for select order, quote and invoice hook to resolve id) > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874942#action_12874942 ] Jacques Le Roux commented on OFBIZ-3765: ---------------------------------------- Hi Erwan, From who are you expecting news? Commiters reviews of Nicolas? > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874998#action_12874998 ] Erwan de FERRIERES commented on OFBIZ-3765: ------------------------------------------- Hi Jacques, Waiting for comments from devs, and waiting for Nicolas to make the tests pass ! Cheers, > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875025#action_12875025 ] Nicolas Malin commented on OFBIZ-3765: -------------------------------------- Erwan given me an error on test process generate by the patch. I check it asap to close this jira Nicolas > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-3765: --------------------------------- Attachment: OFBIZ-3765.patch Test are now OK. When we enter in getNext fonction, I just alerte by log if party not have a partyAcctgPreference. During tests when a purchase invoice was created, the function chexk supplier, not customer. I will propose an improvment in a next jira. > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch, OFBIZ-3765.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-3765. -------------------------------- Resolution: Fixed Tks erwan for the commit at revision 954388 > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch, OFBIZ-3765.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878560#action_12878560 ] Erwan de FERRIERES commented on OFBIZ-3765: ------------------------------------------- Yeah, thanks for closing it... Forgot to do it ! > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch, OFBIZ-3765.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-3765: ----------------------------------------- Assignee: Erwan de FERRIERES > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch, OFBIZ-3765.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889706#action_12889706 ] Scott Gray commented on OFBIZ-3765: ----------------------------------- Was this tested properly? Sales orders created with OOTB settings now take the form WSCO1 instead of WSCO10000. > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch, OFBIZ-3765.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890048#action_12890048 ] Erwan de FERRIERES commented on OFBIZ-3765: ------------------------------------------- Corrected at rev. 965638. Thanks Scott > Use CustomMethod for select order, quote and invoice hook to resolve id > ----------------------------------------------------------------------- > > Key: OFBIZ-3765 > URL: https://issues.apache.org/jira/browse/OFBIZ-3765 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: hookByPartyAcctgPreference.patch, OFBIZ-3765.patch > > > Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration. > I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function. > The patch contains : > * Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation > * Add service enforced ans restart define previously by enumeration > * Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context > * Add error message if PartyAcctgPreference not define. > * Apply on invoice, quote an order > To test just ant clean-all && ant run-install and create quote, order and invoice > Thanks to Leila Mekika for the help > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |