[jira] Created: (OFBIZ-3786) First Visit is never been called
Locked
[jira] Created: (OFBIZ-3786) First Visit is never been called
 
|
First Visit is never been called
-------------------------------- Key: OFBIZ-3786 URL: https://issues.apache.org/jira/browse/OFBIZ-3786 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Sascha Rodekamp Fix For: SVN trunk Attachments: OFBIZ-3786_RequestHandler.java.patch I noticed that the first visist element in a controller.xml is never been called. Here is a proposal patch to solve this issue. Now everytime when a session is created, the first visit element will be called. I don't now if this is the best solution, but maybe we can discuss So long Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3786) First Visit is never been called
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3786: ----------------------------------- Attachment: OFBIZ-3786_RequestHandler.java.patch > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874473#action_12874473 ] Sascha Rodekamp commented on OFBIZ-3786: ---------------------------------------- So have nobody an opinion to this issue? > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875315#action_12875315 ] Jacques Le Roux commented on OFBIZ-3786: ---------------------------------------- But Sascha, this is already hanlded by the VisitHandler.java and it does not depend only on a session created. What are you trying to achieve? > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876569#action_12876569 ] Sascha Rodekamp commented on OFBIZ-3786: ---------------------------------------- Hi Jacques i'll try to explain what's in my mind controller.xml specialpurpose/ecommerce {code:xml} <!-- Events run from here for the first hit in a visit --> <firstvisit> <event name="autoLoginCheck" type="java" path="org.ofbiz.webapp.control.LoginWorker" invoke="autoLoginCheck"/> <event name="checkTrackingCodeCookies" type="java" path="org.ofbiz.marketing.tracking.TrackingCodeEvents" invoke="checkTrackingCodeCookies"/> <event name="setDefaultStoreSettings" type="java" path="org.ofbiz.product.product.ProductEvents" invoke="setDefaultStoreSettings"/> </firstvisit> {code} The Code in firstVisit is never used, because of the wrong if-statement in the RequestHandler. {code} if (this.trackVisit(request) && session.getAttribute("visit") == null) { ... } {code} session.getAttribute("visit") is never null. It is set in the ControlServlet before. (VisitHandler.getVisitId(session); ) > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-3786: -------------------------------------- Assignee: Jacques Le Roux > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893986#action_12893986 ] Arun Patidar commented on OFBIZ-3786: ------------------------------------- Thanks Sascha, Your patch is working fine for me. I think It should be committed in trunk to fix bug. Thanks & Regards --- Arun Patidar > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893994#action_12893994 ] Scott Gray commented on OFBIZ-3786: ----------------------------------- I don't see a better approach but a couple of small comments on the patch: - Why bother setting firstVisit when the session is created? We will know if it is the first visit anyway because of an absence of the value - If the visit has already been created then there is no point in leaving behind the call to VisitHandler.getVisit(...) under the condition > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893998#action_12893998 ] Sascha Rodekamp commented on OFBIZ-3786: ---------------------------------------- Hi Arun, Hi Scott, Atul thanks for testing. Scott, i know this is really not the best solution, but it was necassary in our project. * idon't think that you know about the first visit when looking on the absence of the value, because the value is set in the context filter * i agree on you're second point maybe there is a better solution :-) But i think at the moment it's a better solution. Cheers Sascha > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-3786: --------------------------------- Assignee: Scott Gray (was: Jacques Le Roux) Hi Sascha, Sorry maybe I didn't do a good job at explaining my feedback, instead of trying again I'll just commit what I was talking about and you can see what I mean :-) > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Scott Gray > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray closed OFBIZ-3786. ----------------------------- Resolution: Fixed Thanks Sascha, fixed (and tested) in revs: trunk - 980747 10.04 - 980764 > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Scott Gray > Fix For: SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray updated OFBIZ-3786: ------------------------------ Fix Version/s: Release Branch 10.04 > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Scott Gray > Fix For: Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3786) First Visit is never been called
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894032#action_12894032 ] Sascha Rodekamp commented on OFBIZ-3786: ---------------------------------------- Hey Thanks Scott. And hava a good Weekend!! > First Visit is never been called > -------------------------------- > > Key: OFBIZ-3786 > URL: https://issues.apache.org/jira/browse/OFBIZ-3786 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Sascha Rodekamp > Assignee: Scott Gray > Fix For: Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-3786_RequestHandler.java.patch > > > I noticed that the first visist element in a controller.xml is never been called. > Here is a proposal patch to solve this issue. > Now everytime when a session is created, the first visit element will be called. > I don't now if this is the best solution, but maybe we can discuss > So long > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |