OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

27 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12443833 ]

Anil K Patel commented on OFBIZ-379:
------------------------------------

Jacopo,
I have partially implemented fix, Something came up (Dewali fastival) so did not get chance to work in last two days. In another two/three days I send a patch.

> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444246 ]

Jacopo Cappellato commented on OFBIZ-379:
-----------------------------------------

Anil, Si, David, all,

I thought a lot about this issue this Sunday (while I was driving my car to Florence for the football match :-) because I'd really like to find the best way to fix the screen: in fact it is a central screen for the facility application and it is very common to have in warehouse thousands of products... and so it is very easy to get error messages from the screen... and this could make people think that OFBiz is unstable (and it isn't, isn't it?).

The best thing we can do is probably this:
remove the call to the "getInventoryAvailableByFacility" service and get the total QOH and ATP adding a member entity for "InventoryItem" to the dynamic view in the script, something like this:

prodView.addMemberEntity("IITE", "InventoryItem");
prodView.addViewLink("PRFA", "IITE", Boolean.FALSE, ModelKeyMap.makeKeyMapList("productId", "facilityId"));
prodView.addAlias("IITE", "totalQuantityOnHandTotal", "quantityOnHandTotal", null, null, null, "sum");
prodView.addAlias("IITE", "totalAvailableToPromiseTotal", "availableToPromiseTotal", null, null, null, "sum");
if (hasOffsetQOH) {
//condition: (totalQuantityOnHandTotal - minimumStock) > offsetQOH
// QUESTION: is it possible to add a condition like this?
}
if (hasOffsetATP) {
//condition: (totalAvailableToPromiseTotal - minimumStock) > offsetATP
// QUESTION: is it possible to add a condition like this?
}

I need help here: is it possible to specify a condition based on the difference of two fields (e.g. totalAvailableToPromiseTotal - minimumStock > 10)?
This will solve all the pagination and performace issues, but there are two cons:

a) the virtual inventory for marketing packages will no more be supported in this screen
b) the serialized inventory could be a problem (since it is not guaranteed that the qoh and atp fields are set for serialized items)

In my opinion they are minor issues that could be solved in the following way:

for a) we could keep the original version of the screen and move it in the reports menu of the facility application
for b) : I'm not sure who is using the serialized stuff (there are a few bugs here and there) but it would be nice to always set qoh/atp for serialized inventory too (I remember that Si already proposed something like this some time ago).

What do you think?

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]

Jacopo Cappellato updated OFBIZ-379:
------------------------------------

Attachment: viewproduct.patch

Anil, anyone interested,

in the attached patch (viewproduct.patch) I've refactored the script that prepares data for the screen.
It should work as before but without performance issues.
Please test it (also applying filters by product name by qty offset etc... ) and let me know if you find problems.

Before committing it I'd like to hear what do you (Si, David, all) think of the mkt package counting (that is not implemented in this last version).

> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444413 ]

Anil K Patel commented on OFBIZ-379:
------------------------------------

Jacopo,
Thanks for you time. This patch looks good to me.

> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444463 ]

Ashish Vijaywargiya commented on OFBIZ-379:
-------------------------------------------

+1.
Everything is working fine for me too.
Really nice work Jacopo.
Thanks for your precious time.

Regards
Ashish Vijaywargiya

> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=all ]

Jacopo Cappellato closed OFBIZ-379.
-----------------------------------

Resolution: Fixed

I've committed the mods in svn rev. 467444 (see the commit log for details).
The original script (with its pros -support for mkt pkg - and cons - slowness) is still available and used by the almost identical screen under the report menu.

> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-379) Facility-->Inventory screen is very slow, returns error if there are 10,000 products

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-379?page=comments#action_12444791 ]

Ashish Vijaywargiya commented on OFBIZ-379:
-------------------------------------------

Hi Jacopo,

Can you please take a look at this issue : http://issues.apache.org/jira/browse/OFBIZ-407
Inventory Item screen is not working and returning Java Heap Memory error.

Regards
Ashish Vijaywargiya

> Facility-->Inventory screen is very slow, returns error if there are 10,000 products
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-379
> URL: http://issues.apache.org/jira/browse/OFBIZ-379
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: product
> Reporter: Anil K Patel
> Assigned To: Jacopo Cappellato
> Attachments: FacilityInventoryWithFTL.patch.zip, ViewFacilityInventoryByProduct.zip, viewproduct.patch
>
>
> Response time of Find inventory screen in Product/Facility component is very high if there are about 10,000 products and If search criteria is covers all or most of the products, i.e if user did not fill any information in FindFacilityInventoryByProduct.