[jira] Created: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
Locked
[jira] Created: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
 
|
Inventory reservation is lost from orders when items are cancelled
------------------------------------------------------------------ Key: OFBIZ-380 URL: http://issues.apache.org/jira/browse/OFBIZ-380 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby Reporter: Ray Barlow Priority: Critical After going through the following process inventory reservations are being dropped from an open order: 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: GZ-1000 - Tiny Gizmo GZ-1001 - Nan Gizmo 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! At this point the order can't be processed to completion as packing will fail. As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443284 ]
Ray Barlow commented on OFBIZ-380: ---------------------------------- Reviewing changes to : org/ofbiz/order/order/OrderServices.java r442234 has changes to reserveInventory for drop shipping, so this looks like a good place to start digging: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?r1=442140&r2=442234 > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443296 ]
Jacopo Cappellato commented on OFBIZ-380: ----------------------------------------- Ray, in rev. 465290 I've committed a small change to the OrderServices.java class that hopefully could fix this issue: could you please test if ti works? Thanks > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443353 ]
Ray Barlow commented on OFBIZ-380: ---------------------------------- Thanks for the quick response Jacopo but unfortunately it still fails on the simple test above. I'll keep digging as well but I appreciate any help you can give. Ray > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443440 ]
Ray Barlow commented on OFBIZ-380: ---------------------------------- Jacopo, I've found the cause now to be the base work done in r439995 but the killer blow is in r440018, where the eca for the processOrderPayments has been activated for cancelOrderItem. OrderServices.processOrderPayments calls "loadCartForUpdate" and the second thing that method does is remove all the existing inventory reservations. This is OK as the save "saveUpdatedCartToOrder" recreates those reservations as it's last job but the processOrderPayments doesn't call "saveUpdatedCartToOrder". Couple of options I see: 1) add a call to "saveUpdatedCartToOrder" - not sure on the full consequencies of this, does it need calling anyway to save the payment changes?! 2) change the "loadCartForUpdate" to support the optional removal of the reservations and/or a new "loadCartForPaymentUpdate" Appreciate any and all comments on this so we can fix it asap. Thanks, Ray > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443737 ]
Jacopo Cappellato commented on OFBIZ-380: ----------------------------------------- Ray, thanks for your comments. I feel a bit guilty here, since many of the revisions you are referring to were contributed by me :-( I've disabled the problematic seca in rev. 466024: this should simply bring things back to the status prior to the mods I did in r439995 and so it is a temp fix. I that revision I've reimplemented the cancelOrderItem event with service/seca calls: with this last change everything should work as before my mods. Jacopo > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443848 ]
Ray Barlow commented on OFBIZ-380: ---------------------------------- No need to feel guilty. By virtue of the amount of good work you do for the project and the complexity of areas like this the occassional mistake will get through, as do misakes from all involved in submitting changes. Thanks, Ray > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12443872 ]
Jacques Le Roux commented on OFBIZ-380: --------------------------------------- Yes ! Thanks Jacopo for your good work ! > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12444012 ]
Jacopo Cappellato commented on OFBIZ-380: ----------------------------------------- Ray, did you get a chance to test the last mod? Is the issue about lost reservations solved? It would be great if you could see if there are some new issues (with payments) now that the processOrderPayments is no more called after the call to "cancelOrderItem". If you find something wrong, it would be nice to close this issue and open a new one (with a lower priority) to record this. Again, thanks. > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12444067 ]
Ray Barlow commented on OFBIZ-380: ---------------------------------- Jacopo, Sorry forgot to post a reply. Yes the SVN commit fixed this specific issue (it was the same method I used to test my theory), what I can't answer with any authority is whether it has broken anything else. We don't currently use OFBiz to handle payments and I don't have that much knowledge about what processOrderPayments is trying to achieve so hard to do any real testing. If I get the chance later in the week I will see if anything else obvious around the payment section looks odd. IMHO this removal of ALL inventory reservations against the order when editting the order has got to stop, it kills the FIFO principle of allocation. Ray > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Critical > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=all ]
Jacopo Cappellato updated OFBIZ-380: ------------------------------------ Priority: Minor (was: Critical) > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Minor > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12450805 ]
Si Chen commented on OFBIZ-380: ------------------------------- I agree about changing the reservations. Should we open a new issue? Is this issue basically fixed as is? > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Priority: Minor > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Assigned: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=all ]
Si Chen reassigned OFBIZ-380: ----------------------------- Assignee: Si Chen > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Assigned To: Si Chen > Priority: Minor > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=comments#action_12450825 ]
Jacopo Cappellato commented on OFBIZ-380: ----------------------------------------- Si, I have a fix for this that I'll commit soon. > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Assigned To: Si Chen > Priority: Minor > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-380) Inventory reservation is lost from orders when items are cancelled
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-380?page=all ]
Jacopo Cappellato closed OFBIZ-380. ----------------------------------- Resolution: Fixed This should be fixed by rev. 476251; here is the commit log: The "processOrderPaymets" service now internally gets a ShoppingCart instance by calling the "loadCartFromOrder" service instead of the "loadCartForUpdate" method. The latter is a dangerous method, since it removes all the order reservations (I've added a comment to explain how it should be used). With this change, I've reactivated the seca that calls the "processOrderPaymets" service when items are cancelled (that has been disabled to avoid the loss of reservations). > Inventory reservation is lost from orders when items are cancelled > ------------------------------------------------------------------ > > Key: OFBIZ-380 > URL: http://issues.apache.org/jira/browse/OFBIZ-380 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Environment: N/A - Tested on clean SVN Win2K JDK 1.5.0_06-b05 Derby > Reporter: Ray Barlow > Assigned To: Si Chen > Priority: Minor > > After going through the following process inventory reservations are being dropped from an open order: > 1) Starting from a clean demo data install I used the order entry to create an order for admin with two items in the order: > GZ-1000 - Tiny Gizmo > GZ-1001 - Nan Gizmo > 2) Push through the order creation process entering a delivery address and payment offline to keep it simple, until the order is created, I didn't bother approving it. You can see the order has invertory reservations and it all looks OK. > At this point I shut down my app server cleared the log and started up again so I could get a clear list of log actions. > 3) In the order manager bring up the order and click on "edit items". Then choose one of the products and click "Cancel" at the line level, after which the redrawn screen will show one item cancelled with no allocation (fine) but the other item, still in created state, has also lost it's allocation - major problem!! > At this point the order can't be processed to completion as packing will fail. > As a desperate work around you can manually run the "reserveStoreInventory" service through the webtools which will create a new reservation OK. Not really useable when you have lots of line items through! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |