[jira] Created: (OFBIZ-3844) Splitting CommonRate and CommonProductRating

[Nicolas Malin (Jira)]

Splitting CommonRate and CommonProductRating
--------------------------------------------

                 Key: OFBIZ-3844
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
             Project: OFBiz
          Issue Type: Improvement
          Components: framework, product
    Affects Versions: Release 09.04
         Environment: irrelevant, only XML and FTL changes
            Reporter: Carsten Schinzer
            Priority: Minor
             Fix For: Release Branch 09.04


The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.

The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.

Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-3844:
------------------------------------

    Attachment: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
                OFBIZ-3844_Splitting CommonRate and CommonProductRating_part2.patch

Uploading both patches

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch, OFBIZ-3844_Splitting CommonRate and CommonProductRating_part2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Schinzer updated OFBIZ-3844:
------------------------------------

    Attachment:     (was: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part2.patch)

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890602#action_12890602 ]

Jacques Le Roux commented on OFBIZ-3844:
----------------------------------------

Hi Carsten,

I can see only one patch...

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890602#action_12890602 ]

Jacques Le Roux edited comment on OFBIZ-3844 at 7/21/10 4:01 AM:
-----------------------------------------------------------------

Hi Carsten,

I can see only one patch... Also why should this go only in R9.04?

      was (Author: jacques.le.roux):
    Hi Carsten,

I can see only one patch...
 

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890610#action_12890610 ]

Carsten Schinzer commented on OFBIZ-3844:
-----------------------------------------

I removed the second patch, because more updates to CommonUiLabels.xml (including the minor changes required here) have been submitted in OFBIZ-3868. Apologies for the confusion.

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3844:
--------------------------------------

    Assignee: Jacques Le Roux

> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
>                 Key: OFBIZ-3844
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3844
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, product
>    Affects Versions: Release 09.04
>         Environment: irrelevant, only XML and FTL changes
>            Reporter: Carsten Schinzer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04
>
>         Attachments: OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.