[jira] Created: (OFBIZ-3859) Convert parameters before using entity-engine

[Nicolas Malin (Jira)]

Convert parameters before using entity-engine
---------------------------------------------

                 Key: OFBIZ-3859
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
             Project: OFBiz
          Issue Type: Bug
          Components: manufacturing
    Affects Versions: SVN trunk
            Reporter: matthieu bollot


Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

matthieu bollot updated OFBIZ-3859:
-----------------------------------

    Attachment: ofbiz-3859.patch

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887778#action_12887778 ]

Adrian Crum commented on OFBIZ-3859:
------------------------------------

I don't think the attached patch addresses the real issue. In RoutingSimpleServices.xml, the line:

{code}
<set-nonpk-fields map="parameters" value-field="newEntity"/>
{code}

should do the conversion. If it doesn't, we should look into it further.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888762#action_12888762 ]

matthieu bollot commented on OFBIZ-3859:
----------------------------------------

will you or anyone have some times to take a look ?
Are you sure it is about set-nonpk-fields and not make-value ?
May be we could close this issue and create a new one in framework.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888932#action_12888932 ]

Scott Gray commented on OFBIZ-3859:
-----------------------------------

After looking at createCalendarExceptionDay, I see two problems:
1.  The service definition types exceptionCapacity as a BigDecimal but the entity definition types it as a double, hence the mismatch
2.  set-nonpk-fields ultimately just calls GenericEntity.set(String, Object), once upon a time this method would print (not throw) an exception if a mismatch occurred but would then convert it to the correct type but this doesn't appear to happen anymore.

I would check the svn history and reinstate whatever logic was in place before the conversion framework took over.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889860#action_12889860 ]

Adrian Crum commented on OFBIZ-3859:
------------------------------------

Scott,

I'm not sure what you mean by #2. The original code is still there (SqlJdbcUtil, starting at line 770) and I don't see where a ClassCastException is being caught and used to perform a data type conversion. I can't find where the conversion framework affected GenericEntity either.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890020#action_12890020 ]

Scott Gray commented on OFBIZ-3859:
-----------------------------------

Yeah you're right, I didn't look closely enough and made a few incorrect assumptions.

The mismatch is no longer reported in GenericEntity.set() but it doesn't throw an exception and it has never performed an automatic type conversion in that method (for some reason I thought it did).

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890283#action_12890283 ]

Adrian Crum commented on OFBIZ-3859:
------------------------------------

The correct data type for the exceptionCapacity and usedCapacity fields is numeric (fixed point). So, the entity definition should be changed, not the service definition.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890618#action_12890618 ]

matthieu bollot commented on OFBIZ-3859:
----------------------------------------

If I've understood, changing floating-point to numeric changes from Double to Long, so the error remaines as it now needs to convert from BigDecimal to Long

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890742#action_12890742 ]

Adrian Crum commented on OFBIZ-3859:
------------------------------------

Oops, I meant to say: The correct data type for the exceptionCapacity and usedCapacity fields is fixed-point.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

matthieu bollot updated OFBIZ-3859:
-----------------------------------

    Attachment: ofbiz-3859-2.patch

new patch according to comments

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859-2.patch, ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891206#action_12891206 ]

matthieu bollot commented on OFBIZ-3859:
----------------------------------------

It works pretty well with fixed-point, I've also replaced a timestamp with date as it is what is used in entity, service, and form.

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>         Attachments: ofbiz-3859-2.patch, ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-3859:
----------------------------------

    Assignee: Adrian Crum

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>            Assignee: Adrian Crum
>         Attachments: ofbiz-3859-2.patch, ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-3859.
------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Fixed, rev 978939. Thanks Matthieu!

> Convert parameters before using entity-engine
> ---------------------------------------------
>
>                 Key: OFBIZ-3859
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3859
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: matthieu bollot
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: ofbiz-3859-2.patch, ofbiz-3859.patch
>
>
> Now, values need to be converted before using entity-engine. I'll provide a patch corresponding to this selenium test :
> http://selenium.neogia.org/ofbiz/tests/ManufacturingCreateCalendarAndWeek.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.