[jira] Created: (OFBIZ-3860) ofbizUrl not transform "&" correctly on checkoutoption page for ordermgr.

[Nicolas Malin (Jira)]

ofbizUrl not transform "&" correctly on checkoutoption page for ordermgr.
------------------------------------------------------------------------------

                 Key: OFBIZ-3860
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 10.04, SVN trunk
            Reporter: Deepak Dixit
            Priority: Minor
             Fix For: Release Branch 10.04, SVN trunk




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-3860:
--------------------------------

    Attachment: OFBIZ-3860.patch

Here is the patch for this issue.

> ofbizUrl not transform "&" correctly on checkoutoption page for ordermgr.
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887730#action_12887730 ]

Hans Bakker commented on OFBIZ-3860:
------------------------------------

it looks like this is happening pretty often within ofbiz......which means a lot of <@ofbizUrl> need to be enclosed on CDATA statements, not a really nice solution....

examples:
FinAccountTrans.ftl
EditCustomTimePeriod.ftl
applications/accounting/webapp/accounting/main.ftl
CMSSites.ftl
EditSurveyQuestions.ftl (12 matches)

and many more.....

> ofbizUrl not transform "&amp;" correctly on checkoutoption page for ordermgr.
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887732#action_12887732 ]

Deepak Dixit commented on OFBIZ-3860:
-------------------------------------

Thanks Hans,
But if we use <@ofbizUrl> in form action and pass parameters using &amp; in action attribute then this create problem in parsing &amp; and if we use it in <a href=.... then it woks fine.

> ofbizUrl not transform "&amp;" correctly on checkoutoption page for ordermgr.
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-3860:
--------------------------------

    Attachment: OFBIZ-3860.patch

Here is the updated patch that cover some more file for ordermgr component.

> ofbizUrl not transform "&amp;" correctly on checkoutoption page for ordermgr.
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-3860:
--------------------------------

    Summary: ofbizUrl not transform "&amp;" correctly.  (was: ofbizUrl not transform "&amp;" correctly on checkoutoption page for ordermgr. )

> ofbizUrl not transform "&amp;" correctly.
> -----------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3860:
---------------------------------

    Assignee: Scott Gray

> ofbizUrl not transform "&amp;" correctly.
> -----------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888126#action_12888126 ]

Scott Gray commented on OFBIZ-3860:
-----------------------------------

Hans, here's the discussion from the user list if you want to understand the issue a little better: http://ofbiz.markmail.org/thread/7jo2k44nfbvcvhmy

> ofbizUrl not transform "&amp;" correctly.
> -----------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888132#action_12888132 ]

Hans Bakker commented on OFBIZ-3860:
------------------------------------

happy to see it is not that bad!

Regards,
Hans

> ofbizUrl not transform "&amp;" correctly.
> -----------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-3860.
-----------------------------

    Resolution: Fixed

Agreed, theres nothing worse than a bad fix.

Anyways thanks Deepak, committed in:
trunk - r963915
10.04 - r963917

> ofbizUrl not transform "&amp;" correctly.
> -----------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888179#action_12888179 ]

Deepak Dixit commented on OFBIZ-3860:
-------------------------------------

Thanks Scott.

> ofbizUrl not transform "&amp;" correctly.
> -----------------------------------------
>
>                 Key: OFBIZ-3860
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3860
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3860.patch, OFBIZ-3860.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.