[jira] Created: (OFBIZ-3863) selectall.js jquery transformation
Locked
123
123
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch hey, here is a patch for the "ajax submit form update area" function Chgeers Sascha > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897766#action_12897766 ] Jacques Le Roux commented on OFBIZ-3863: ---------------------------------------- Hi Sascha, Rupert (Howel) said that the the autocomplete still appears to refer back to old javascripts: it's still pointing back to ajaxAutoCompleteDropDown in old selectAll.js code and not working. He is working on it to make it plain jQuery... Just to avoid duplicate effort... > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898152#action_12898152 ] Sascha Rodekamp commented on OFBIZ-3863: ---------------------------------------- Hi Jacques, jep there can be direct calls from ftl's which i have missed. I think i still changes the macro renderer for now. > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: OFBIZ-3863_selectallUpdate.txt Here a patch which updates a few prototype based methods in the selectall.js file and convert them to jQuery! Cheers > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.txt, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: OFBIZ-3863_selectallUpdate.patch > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: (was: OFBIZ-3863_selectallUpdate.txt) > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: OFBIZ-3863_selectallUpdate.patch > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Erwan de FERRIERES > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-3863: -------------------------------------- Assignee: Jacques Le Roux (was: Erwan de FERRIERES) > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900235#action_12900235 ] Jacques Le Roux commented on OFBIZ-3863: ---------------------------------------- Hi Erwan, I have assigned to me. I should work on this today... > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900235#action_12900235 ] Jacques Le Roux edited comment on OFBIZ-3863 at 8/19/10 5:50 AM: ----------------------------------------------------------------- Hi Erwan, I have assigned to me. I should work on this today... Then I will re-assign to you... was (Author: jacques.le.roux): Hi Erwan, I have assigned to me. I should work on this today... > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902378#action_12902378 ] Jacques Le Roux commented on OFBIZ-3863: ---------------------------------------- Hi Sacha, I have applied your last patch (OFBIZ-3863_selectallUpdate.patch). I was able to test (mostly on FF 3.6.8), here is the WIP so far: * setUserLayoutPreferences works well * the quick product access in main catalog page (you enter a productId and then choose the page you want to go) does not work (not sure to what it's related at this stage), not in Opera 10.61 * ajaxUpdateArea is not working in FF (this is maybe due to my environment, many plugins) see https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000, ok in Opera for the add and update but not the delete, same in Chrome. All work well on trunk demo * I may have missed something but I did not find any use cases for ajaxUpdateAreaPeriodic OOTB (did not find any use of autoUpdateLink but in templates) * nor for ajaxSubmitRequestUpdateAreas * nor for submitFormInBackground * nor for setSelection * setLookDescription seems to work week since it used by lookupDescriptionLoaded in fieldlookup.js and there seems to be no pb there * for ajaxAutoCompleteDropDown, Rupert will give me his patch, and I will see if it can be applied (he said it could break the Dependent Dropdowns stuff, and I'd not like that for something that is even not used OOTB) BTW when we will remove we will need to find a replacement for flotr and adapt the work done OOTB with it, ie https://localhost:8443/example/control/ExampleBarChart More to come... > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902382#action_12902382 ] Sascha Rodekamp commented on OFBIZ-3863: ---------------------------------------- Hi Jacques, ok i will have a look this evening to the open points. Jep i found somethink similar to flotr which uses jQuery, but hadn't the time to integrate it yet: [http://code.google.com/p/flot/] comes soon ... :) > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902378#action_12902378 ] Jacques Le Roux edited comment on OFBIZ-3863 at 8/25/10 7:57 AM: ----------------------------------------------------------------- Hi Sacha, I have applied your last patch (OFBIZ-3863_selectallUpdate.patch). I was able to test (mostly on FF 3.6.8), here is the WIP so far: * setUserLayoutPreferences works well * the quick product access in main catalog page (you enter a productId and then choose the page you want to go) does not work (not sure to what it's related at this stage), not in Opera 10.61 * ajaxUpdateArea is not working in FF (this is maybe due to my environment, many plugins) see https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000, ok in Opera for the add and update but not the delete, same in Chrome. All work well on trunk demo * I may have missed something but I did not find any use cases for ajaxUpdateAreaPeriodic OOTB (did not find any use of autoUpdateLink but in templates) * nor for ajaxSubmitRequestUpdateAreas * nor for submitFormInBackground * nor for setSelection * setLookDescription seems to work well since it used by lookupDescriptionLoaded in fieldlookup.js and there seems to be no pb there * for ajaxAutoCompleteDropDown, Rupert will give me his patch, and I will see if it can be applied (he said it could break the Dependent Dropdowns stuff, and I'd not like that for something that is even not used OOTB) BTW when we will remove we will need to find a replacement for flotr and adapt the work done OOTB with it, ie https://localhost:8443/example/control/ExampleBarChart More to come... ========Edit: FIXED a TYPO=========== was (Author: jacques.le.roux): Hi Sacha, I have applied your last patch (OFBIZ-3863_selectallUpdate.patch). I was able to test (mostly on FF 3.6.8), here is the WIP so far: * setUserLayoutPreferences works well * the quick product access in main catalog page (you enter a productId and then choose the page you want to go) does not work (not sure to what it's related at this stage), not in Opera 10.61 * ajaxUpdateArea is not working in FF (this is maybe due to my environment, many plugins) see https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000, ok in Opera for the add and update but not the delete, same in Chrome. All work well on trunk demo * I may have missed something but I did not find any use cases for ajaxUpdateAreaPeriodic OOTB (did not find any use of autoUpdateLink but in templates) * nor for ajaxSubmitRequestUpdateAreas * nor for submitFormInBackground * nor for setSelection * setLookDescription seems to work week since it used by lookupDescriptionLoaded in fieldlookup.js and there seems to be no pb there * for ajaxAutoCompleteDropDown, Rupert will give me his patch, and I will see if it can be applied (he said it could break the Dependent Dropdowns stuff, and I'd not like that for something that is even not used OOTB) BTW when we will remove we will need to find a replacement for flotr and adapt the work done OOTB with it, ie https://localhost:8443/example/control/ExampleBarChart More to come... > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: OFBIZ-3863_selectallUpdate.patch Hi Jacques i fixed the issues. The main point was, that .load sends GET Requests when it get a normal parameter String (name=val&name2=val2 ...) it only uses POST when it gets a (JSON) Object. That isn't possible because the method is on some points called with form.serialize() which creates the normal parameter string and no object. So i created a "normal" Ajax Request with the same functionallity but sending the it via POST... works! Cheers :) And thanks for testing > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902551#action_12902551 ] Jacques Le Roux commented on OFBIZ-3863: ---------------------------------------- Thanks Sacha, The ajaxUpdateArea has still some issues. Did you succeed? I was not able to correctly Add and Update either in FF, Opera or Chrome. If you use another action on the screen, it updates the whole and you might get it working. But it's not really working properly when you click on the Add or Update button. For the parts where I have no use cases, I will commit as is as your changes looks good to me, but I'd add a failure case for ajaxUpdateArea, and actually any such cases... (ie where there is a waitSpinnerHide(); is used in success) So I will wait your review of ajaxUpdateArea using the link I provided and Rupert's patch... Ha... it's good to have it with jQuery but I did not understand the issue for submitProductJump, we should not have any conflicts and Prototype is still there, why did it not work? > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3863: ----------------------------------- Attachment: OFBIZ-3863_selectallUpdate.patch Good morning Jacques, jep i made a Type so he can't find the variable. Sorry for that. here is a corrected version. Cheers > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902752#action_12902752 ] Sascha Rodekamp commented on OFBIZ-3863: ---------------------------------------- To the product jump issue. jQuery and Prototype have a slightly different API. for example Prototype gets a value by simply use the .value method, jQuery in case uses .attr('value') or val(). Another point was, that the script try to reach the input field by ID, but the IDs for Lookups and autocomplete fields are auto generated, so i had to change the way how the input field is called. That was the case why it was not working. I just changed the > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902818#action_12902818 ] Jacques Le Roux commented on OFBIZ-3863: ---------------------------------------- Hi Sascha, I have commited a slightly modified patch at revision: 989599 You forgot the keywordsearchbox.ftl file, but it was easy to fix I have also added the errors handling (same than failure in Prototype) For the parts where there are no use cases, I commited as is, your changes looks good to me Also I crossed again an issue I have for a long time in FF with application/x-json, and I guess application/json as well (I'm on Windows but I don't think it's the reason). When I press the Add or Update button when editing a facility at https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000, the FF download popup window surges and I'm trapped there. Even if the action is correctly executed underneath (I can see it if I refresh the page). I did not find any good solution either using https://addons.mozilla.org/en-US/firefox/addon/10869/ or http://www.spasche.net/openinbrowser/ because they only allow to see the file. I did not find yet a way to bypass the dowload popup window I don't close the issue as there are still some Prototype stuff in selectall.js, notably a patch from Rupert Howell for the dropdown autocomplete stuff, but also some other (easily spotted looking for $) > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902832#action_12902832 ] Sascha Rodekamp commented on OFBIZ-3863: ---------------------------------------- Hey Jacques, thank you, good work! Don't know why i forgot the keywordsearch.ftl but today it's very hectic and i'm jumping around between the chairs :-D. Thank you for committing and have a good day .. speak to you tomorrow. cheers Sascha > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3863) selectall.js jquery transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902843#action_12902843 ] Jacques Le Roux commented on OFBIZ-3863: ---------------------------------------- One thing I like much in jQuery is how it handles function composition, for instance I wrote jQuery('#productJumpForm input[name=productId]').val(jQuery('#productJumpForm input[name=productId]').val().replace(" ","")); it remains me the time I was writing in [APL|http://en.wikipedia.org/wiki/APL_%28programming_language%29], one liner syndrom sorry :/ > selectall.js jquery transformation > ---------------------------------- > > Key: OFBIZ-3863 > URL: https://issues.apache.org/jira/browse/OFBIZ-3863 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch > > > Hi, > i started to change the selectall.js methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |