[jira] Created: (OFBIZ-3863) selectall.js jquery transformation

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903241#action_12903241 ]

Sascha Rodekamp commented on OFBIZ-3863:
----------------------------------------

Haha Jacques you're right. This way of notation is bad to read but have some performance advanteages.
Normally jQuery itself passes internally only references and don't have to create the jQuery object everytime.


So today i will start with the jquery plotter implementation. Let us see how that works ;)

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903286#action_12903286 ]

Jacques Le Roux commented on OFBIZ-3863:
----------------------------------------

Interesting detail, thanks Sascha. I think I will continue to abuse then :/ Actually we do the same in Java...

No I joke, I will avoid it :)

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903287#action_12903287 ]

Jacques Le Roux commented on OFBIZ-3863:
----------------------------------------

Also Sascha,

As I said above there are still some Prototype in selectall.js. Anyway, I think I will handle them when I will put Rupert's work in.

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3863:
-----------------------------------

    Attachment: OFBIZ-3863_selectallUpdate.patch

Hi Jacques, the collapse and expandAll function didn't work correctly ... here is the patch, i also replaced the $ with jQuery. Now there should be only the stuff from Rubert missing.

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903421#action_12903421 ]

Jacques Le Roux commented on OFBIZ-3863:
----------------------------------------

Great, thanks Sascha,

I wil hopefully have a look today...

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903812#action_12903812 ]

Jacques Le Roux commented on OFBIZ-3863:
----------------------------------------

Thanks Sascha,

Your patch is commited at r990338  

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3863.
----------------------------------

    Resolution: Fixed

I closet this issue because the auto-complete for dropdowns is delayed. It introduces issues with current Dependent Dropdown mechanism. I have created a new subtask for it.

Also I wonder if there are not too much unrelated things in in selectall.js...

> selectall.js jquery transformation
> ----------------------------------
>
>                 Key: OFBIZ-3863
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3863
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: errorjQuery.png, jeditable.zip, OFBIZ-3863_ajaxSubmitFormUpdateAreas.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete.patch, OFBIZ-3863_autocomplete_inplaceedit.patch, OFBIZ-3863_dateTimeField.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_selectallUpdate.patch, OFBIZ-3863_toggleScreenlet.patch
>
>
> Hi,
> i started to change the selectall.js methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.