[jira] Created: (OFBIZ-3894) Refactor Ecommerce and Order
Locked
[jira] Created: (OFBIZ-3894) Refactor Ecommerce and Order
 
|
Refactor Ecommerce and Order
---------------------------- Key: OFBIZ-3894 URL: https://issues.apache.org/jira/browse/OFBIZ-3894 Project: OFBiz Issue Type: Improvement Components: order, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: BJ Freeman Priority: Minor Fix For: SVN trunk with the addition of the Website for each component 1) create product store for Order entry, or use the B2C product store. 2) move the email widgets from ecommerce to order compontent. 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to note: as I go through the different items this is turning out to be a bigger project than I first anticipated. so consider this so far just ideas. Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901230#action_12901230 ] Scott Gray commented on OFBIZ-3894: ----------------------------------- The product store is selectable at the start of order entry, which in turn determines what email templates are available (among many other things). How does that differ from what you are proposing here? > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901233#action_12901233 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- your are correct but only the productstore loaded. under seed there is no product store for the orderentry or any other component. My original focus was to pull emails back into orders from ecommerce as far as widgets, then change the seed for ecommerce to use the widgets for emails. secondarily the B2C productstore has no emails defined for it in demo data. I have not looked at the others. further under the Setup this should be added. That is when I decided this is more than a simple refactor. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901327#action_12901327 ] Bruno Busco commented on OFBIZ-3894: ------------------------------------ How the productstore and the email templates are linked together is just something I was looking at. I have found the "EmailTemplateSetting" entity defined in the framework common component and the "ProductStoreEmailSetting" defined in the product component. The "ProductStoreEmailSetting" entity is a copy of the "EmailTemplateSetting" since many fields are duplicated and it is used for instance in the "sendCreatePartyEmailNotification" service to send an email to newly added parties while "sendMailFromTemplateSetting" should have been used. As a result of all this we have that the party component (where the "sendCreatePartyEmailNotification" is defined) depends on the product component (where the "ProductStoreEmailSetting" is defined). Could we think to reuse the "EmailTemplateSetting" instead of duplicating it in the "ProductStoreEmailSetting" and then having the services defined in party only use the "EmailTemplateSetting" so to avoid dependence on the product component ? I am still looking at having only the party and content (and a better myportal) components distributed with the framework and this would help. Any ideas? > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901332#action_12901332 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- Actually the Productstoreemail was first, and is legacy. i am not sure having a template entity in framework does not pose a inter dependence from framework to applications. you still need the productstoreemail to define specifics like who the email is from and the customize subject line. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901333#action_12901333 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- there are many places where the emails are hard coded into the java. one of the refactors was to use the procuctstoreemail and the services that support it the default. now if we can resolve the dependency issue of EmailTemplateSetting and expand it to handle multiple productstore, and or partiies then it might work. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901337#action_12901337 ] Bruno Busco commented on OFBIZ-3894: ------------------------------------ BJ, the <entity entity-name="EmailTemplateSetting" package-name="org.ofbiz.common.email" is already defined in common and it should be used for every base email sending service. I mean for example for system notifications, mailing list, new user confirmation. Then the product component should have extended this entity adding all needed fields. The way it is done right now does not seem really clean to me. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901456#action_12901456 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- now that I have my cup of coffee. I am not disputing that moving to EmailTemplateSetting is a good goal. what I am saying is there are a lot of productions servers that use the legacy system. for instance 9.04 does not define EmailTemplateSetting or the services in common. to upgrade from 9.04 to trunk require migration code. it would be a major task just to do the migration for any production server that upgardes. it is not something I would blindly change code to do. any new functionality would use EmailTemplateSetting, I agree. That is a no brainer. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901507#action_12901507 ] Bruno Busco commented on OFBIZ-3894: ------------------------------------ If we want to preserve compatibility we will never get the framework independence. We can create a branch where those major changes happen. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901512#action_12901512 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- clarification I am not saying support compatibility as I am saying provide a migration path. It does not make user comfortable to know they investment will cost them considerable to upgrade. It should be the responsibility of the designers to make sure the users upgrade is a painless as possible. that is why people don't move from one application to another. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901514#action_12901514 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- and I don't see how framework Independence is effected by this operation. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901525#action_12901525 ] Jacques Le Roux commented on OFBIZ-3894: ---------------------------------------- Hi, I did not look intot the details yet, but I agree with BJ that keeping the upgrade path as simple as possible should be one of our concerns. For instance, I was unpleasantly surprised when I saw how Dojo recenlty handled its Tree upgrade. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Ecommerce and Order
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901669#action_12901669 ] Scott Gray commented on OFBIZ-3894: ----------------------------------- @Bruno Now we're getting into a topic that is more interesting. EmailTemplateSetting was indeed added long after ProductStoreEmailSetting and is an entity much better suited for general reuse. IMO the best way to use it with a ProductStore would be with a join table that would ultimately replace ProductStoreEmailSetting, something like: emailTemplateSettingId * productStoreId * emailTypeId * fromDate * thruDate Additionally one thing that I don't like about either of those existing entity definitions is the lack of Content support. You cannot at run-time alter the contents of the email templates or create new ones. Additionally the subject field doesn't really lend itself to internationalization. All of these issues could be resolved by modeling the actual contents of the email templates against the Content data model. A join between EmailTemplateSetting and Content could enable this: EmailTemplateSettingContent emailTemplateSettingId * contentId * emailTemplateContentTypeId * fromDate * thruDate EmailTemplateContentType emailTemplateContentTypeId * description Seed data for EmailTemplateContentType: <EmailContentTemplateType emailTemplateContentTypeId="SUBJECT" description="Subject"/> <EmailContentTemplateType emailTemplateContentTypeId="BODY" description="Email Body"/> <EmailContentTemplateType emailTemplateContentTypeId="ATTACHMENT_PDF" description="PDF Attachment"/> I dream of a day when users can create new email templates in a WYSIWG editor with the ability to pick from a list of known variables that represents the freemarker data model that will be available during rendering, possibly even providing a sample freemarker data model so that they can see a live preview of the output with variables such as firstName, lastName, etc. prefilled with sample data. > Refactor Ecommerce and Order > ---------------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: order, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3894) Refactor Email handling
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-3894: ------------------------------ Summary: Refactor Email handling (was: Refactor Ecommerce and Order) Component/s: ALL COMPONENTS (was: specialpurpose/ecommerce) (was: order) since the discussion had taken on a broader scope changed title and the targets. > Refactor Email handling > ----------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Email handling
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901773#action_12901773 ] Bruno Busco commented on OFBIZ-3894: ------------------------------------ I perfectly agree on having a content based email data model similar to the one that you suggest. A set of screens in the content (?) component could allow the user to browse between the available email templates and define new ones. > Refactor Email handling > ----------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3894) Refactor Email handling
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903485#action_12903485 ] BJ Freeman commented on OFBIZ-3894: ----------------------------------- thanks Scott will look at a migration per your suggestion. first stage for refactor is identify all the code that needs to modified and make a task for each. If someone wants to create task and patch for the content type that would be great also. > Refactor Email handling > ----------------------- > > Key: OFBIZ-3894 > URL: https://issues.apache.org/jira/browse/OFBIZ-3894 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS > Affects Versions: SVN trunk > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Original Estimate: 1344h > Remaining Estimate: 1344h > > with the addition of the Website for each component > 1) create product store for Order entry, or use the B2C product store. > 2) move the email widgets from ecommerce to order compontent. > 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to > note: as I go through the different items this is turning out to be a bigger project than I first anticipated. > so consider this so far just ideas. > Maybe break down in to small tasks as I have time to do something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-3894) Refactor Email handling
|
|
Hi All:
This isn't really a re-factor of "Email handling". It is more closely described as a re-factor of "handling order notifications". It just so happens that that email Services are called on to do this. Hopefully, no "email" Service will be harmed in the making of this change ;-) Just my 2 cents. Ruth BJ Freeman (JIRA) wrote: > [ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903485#action_12903485 ] > > BJ Freeman commented on OFBIZ-3894: > ----------------------------------- > > thanks Scott will look at a migration per your suggestion. > first stage for refactor is identify all the code that needs to modified and make a task for each. > If someone wants to create task and patch for the content type that would be great also. > > >> Refactor Email handling >> ----------------------- >> >> Key: OFBIZ-3894 >> URL: https://issues.apache.org/jira/browse/OFBIZ-3894 >> Project: OFBiz >> Issue Type: Improvement >> Components: ALL COMPONENTS >> Affects Versions: SVN trunk >> Reporter: BJ Freeman >> Priority: Minor >> Fix For: SVN trunk >> >> Original Estimate: 1344h >> Remaining Estimate: 1344h >> >> with the addition of the Website for each component >> 1) create product store for Order entry, or use the B2C product store. >> 2) move the email widgets from ecommerce to order compontent. >> 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to >> note: as I go through the different items this is turning out to be a bigger project than I first anticipated. >> so consider this so far just ideas. >> Maybe break down in to small tasks as I have time to do something. >> > > |
Re: [jira] Commented: (OFBIZ-3894) Refactor Email handling
|
|
the goal is remove the hard coded and java email handling and use the
email services in the framework/common. Also to move the configuration that is in productstoreemail entity to the new one as describe in the jira all the work will be supported by migration code and screens for anything manual. I hope to set a new best practices how changes are done so productions system have the least human foot print for changes. hope you chime in on the documentation or some screens. ========================= BJ Freeman <http://bjfreeman.elance.com> Strategic Power Office with Supplier Automation <http://www.businessesnetwork.com/automation/viewforum.php?f=52> Specialtymarket.com <http://www.specialtymarket.com/> Systems Integrator-- Glad to Assist Chat Y! messenger: bjfr33man Ruth Hoffman sent the following on 8/27/2010 10:12 AM: > Hi All: > This isn't really a re-factor of "Email handling". It is more closely > described as a re-factor of "handling order notifications". It just so > happens that that email Services are called on to do this. Hopefully, no > "email" Service will be harmed in the making of this change ;-) > > Just my 2 cents. > Ruth > > BJ Freeman (JIRA) wrote: >> [ >> https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903485#action_12903485 >> ] >> BJ Freeman commented on OFBIZ-3894: >> ----------------------------------- >> >> thanks Scott will look at a migration per your suggestion. >> first stage for refactor is identify all the code that needs to >> modified and make a task for each. If someone wants to create task and >> patch for the content type that would be great also. >> >>> Refactor Email handling >>> ----------------------- >>> >>> Key: OFBIZ-3894 >>> URL: https://issues.apache.org/jira/browse/OFBIZ-3894 >>> Project: OFBiz >>> Issue Type: Improvement >>> Components: ALL COMPONENTS >>> Affects Versions: SVN trunk >>> Reporter: BJ Freeman >>> Priority: Minor >>> Fix For: SVN trunk >>> >>> Original Estimate: 1344h >>> Remaining Estimate: 1344h >>> >>> with the addition of the Website for each component 1) create product >>> store for Order entry, or use the B2C product store. >>> 2) move the email widgets from ecommerce to order compontent. >>> 3) modify the seed data so that Order entry has it own emails from >>> order component.this would be to add emails to note: as I go through >>> the different items this is turning out to be a bigger project than I >>> first anticipated. >>> so consider this so far just ideas. >>> Maybe break down in to small tasks as I have time to do something. >> > |
Re: [jira] Commented: (OFBIZ-3894) Refactor Email handling
Administrator
|
In reply to this post by Ruth Hoffman-2
Always better to comment in the Jira: for history sake it's easier...
Thanks Jacques From: "Ruth Hoffman" <[hidden email]> > Hi All: > This isn't really a re-factor of "Email handling". It is more closely described as a re-factor of "handling order notifications". > It just so happens that that email Services are called on to do this. Hopefully, no "email" Service will be harmed in the making > of this change ;-) > > Just my 2 cents. > Ruth > > BJ Freeman (JIRA) wrote: >> [ >> https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903485#action_12903485 ] >> BJ Freeman commented on OFBIZ-3894: >> ----------------------------------- >> >> thanks Scott will look at a migration per your suggestion. >> first stage for refactor is identify all the code that needs to modified and make a task for each. If someone wants to create >> task and patch for the content type that would be great also. >> >> >>> Refactor Email handling >>> ----------------------- >>> >>> Key: OFBIZ-3894 >>> URL: https://issues.apache.org/jira/browse/OFBIZ-3894 >>> Project: OFBiz >>> Issue Type: Improvement >>> Components: ALL COMPONENTS >>> Affects Versions: SVN trunk >>> Reporter: BJ Freeman >>> Priority: Minor >>> Fix For: SVN trunk >>> >>> Original Estimate: 1344h >>> Remaining Estimate: 1344h >>> >>> with the addition of the Website for each component 1) create product store for Order entry, or use the B2C product store. >>> 2) move the email widgets from ecommerce to order compontent. >>> 3) modify the seed data so that Order entry has it own emails from order component.this would be to add emails to note: as I go >>> through the different items this is turning out to be a bigger project than I first anticipated. >>> so consider this so far just ideas. >>> Maybe break down in to small tasks as I have time to do something. >>> >> >> > |
Re: [jira] Commented: (OFBIZ-3894) Refactor Email handling
|
|
+1
Thanks & Regards -- Pranay Pandey www.hotwaxmedia.com On Aug 28, 2010, at 3:24 AM, Jacques Le Roux wrote: > Always better to comment in the Jira: for history sake it's easier... > > Thanks > > Jacques > > From: "Ruth Hoffman" <[hidden email]> >> Hi All: >> This isn't really a re-factor of "Email handling". It is more >> closely described as a re-factor of "handling order notifications". >> It just so happens that that email Services are called on to do >> this. Hopefully, no "email" Service will be harmed in the making of >> this change ;-) >> >> Just my 2 cents. >> Ruth >> >> BJ Freeman (JIRA) wrote: >>> [ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903485 >>> #action_12903485 ] >>> BJ Freeman commented on OFBIZ-3894: >>> ----------------------------------- >>> >>> thanks Scott will look at a migration per your suggestion. >>> first stage for refactor is identify all the code that needs to >>> modified and make a task for each. If someone wants to create task >>> and patch for the content type that would be great also. >>> >>> >>>> Refactor Email handling >>>> ----------------------- >>>> >>>> Key: OFBIZ-3894 >>>> URL: https://issues.apache.org/jira/browse/ >>>> OFBIZ-3894 >>>> Project: OFBiz >>>> Issue Type: Improvement >>>> Components: ALL COMPONENTS >>>> Affects Versions: SVN trunk >>>> Reporter: BJ Freeman >>>> Priority: Minor >>>> Fix For: SVN trunk >>>> >>>> Original Estimate: 1344h >>>> Remaining Estimate: 1344h >>>> >>>> with the addition of the Website for each component 1) create >>>> product store for Order entry, or use the B2C product store. >>>> 2) move the email widgets from ecommerce to order compontent. >>>> 3) modify the seed data so that Order entry has it own emails >>>> from order component.this would be to add emails to note: as I go >>>> through the different items this is turning out to be a bigger >>>> project than I first anticipated. >>>> so consider this so far just ideas. >>>> Maybe break down in to small tasks as I have time to do something. >>>> >>> >>> > > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |