[jira] Created: (OFBIZ-3919) Order Application Mirgrated

[Nicolas Malin (Jira)]

Order Application Mirgrated
---------------------------

                 Key: OFBIZ-3919
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
             Project: OFBiz
          Issue Type: Sub-task
          Components: order
    Affects Versions: jQuery
            Reporter: Sascha Rodekamp
             Fix For: jQuery
         Attachments: OFBIZ-3919_orderApplication.patch, validate.zip

Hi everybody,

i took the order application and migrate all the Prototype JS Scripts to jQuery.

I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.

Please have a look.
To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.

So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3919:
-----------------------------------

    Attachment: validate.zip
                OFBIZ-3919_orderApplication.patch

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3919:
-----------------------------------

    Attachment: OFBIZ-3919_orderApplication.patch

Update the file against the latest trunk

Cheers and a good WE

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3919:
--------------------------------------

    Assignee: Jacques Le Roux

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3919:
-----------------------------------

    Attachment: OFBIZ-3919_orderApplication.patch

New patch sync against the latest trunk

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913966#action_12913966 ]

Jacques Le Roux commented on OFBIZ-3919:
----------------------------------------

Thanks Sascha,

This time I will try to review and especially integrate before it's obsolete ;) I already reviewed most part so it should be soon.

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3919:
-----------------------------------

    Attachment: OFBIZ-3919_orderApplication.patch

Updata patch against the latest trunk

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915069#action_12915069 ]

Jacques Le Roux commented on OFBIZ-3919:
----------------------------------------

Hi Sascha,

Here are some comments so far:
geoAutoCompleter.js:
* labels harcoded, we should try to follow Adam's advice at http://markmail.org/message/q4sgy6uvzwzygkf5
* I'd like to simplify it (by using something more generic and unique in OFBiz) but I'm not quire sure yet it's worth the try.
* in the modal box to create address the contry/states stuff does not work

Else the code sounds to have any issues but I did not test it all

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915134#action_12915134 ]

Sascha Rodekamp commented on OFBIZ-3919:
----------------------------------------

Good morning Jacques, ok i will try to refactor the code and try to make it more simple.

Have a good weekstart
Sascha

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3919:
-----------------------------------

    Attachment: OFBIZ-3919_OrderApplicationNewAddressLookup.patch

Hi,
here is the fix for the add address dialog and the country/state autocomplete. It was a little big which regards to a renamed field id which was only renamed in the ftl not in the js file.

Cheers

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_OrderApplicationNewAddressLookup.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3919.
----------------------------------

    Resolution: Fixed

Thanks Sascha,

Your patch is committed at r1002558. I will open a Jira for the localization point

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_OrderApplicationNewAddressLookup.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916115#action_12916115 ]

Sascha Rodekamp commented on OFBIZ-3919:
----------------------------------------

thanks Jacques,
jep that would be great, i'm working on the i18n stuff. Tomorrow you will get a lot of patches :-)

Cheers

> Order Application Mirgrated
> ---------------------------
>
>                 Key: OFBIZ-3919
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3919
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: jQuery
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: jQuery
>
>         Attachments: OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_orderApplication.patch, OFBIZ-3919_OrderApplicationNewAddressLookup.patch, validate.zip
>
>
> Hi everybody,
> i took the order application and migrate all the Prototype JS Scripts to jQuery.
> I hope i didn't miss something and i was not able to test the ConvertUom Script. The rest should work properly.
> Please have a look.
> To commit apply the patch and copy the jQuery validation plugin in the jquery/plugin folder.
> So long Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.