[jira] Created: (OFBIZ-3920) HtmlFromRederer : with attribute skip-start, lookup fields are broken

[Nicolas Malin (Jira)]

HtmlFromRederer : with attribute skip-start, lookup fields are broken
---------------------------------------------------------------------

                 Key: OFBIZ-3920
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Nicolas Malin
            Priority: Minor
             Fix For: SVN trunk


When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.

I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
Nicolas

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3920:
---------------------------------

    Attachment: skipStartWithLookup.patch

> HtmlFromRederer : with attribute skip-start, lookup fields are broken
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3920:
--------------------------------------

    Summary: HtmlFormRenderer : with attribute skip-start, lookup fields are broken  (was: HtmlFromRederer : with attribute skip-start, lookup fields are broken)

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909415#action_12909415 ]

Jacques Le Roux commented on OFBIZ-3920:
----------------------------------------

I think we should use the same for calendar, reported some time ago by Chris Howe at OFBIZ-2282

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909624#action_12909624 ]

Nicolas Malin commented on OFBIZ-3920:
--------------------------------------

Ho sorry for duplication jira.
I think you right, it's the same problem, I recreate my patcch to correct both issue.

thx

Nicolas

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909630#action_12909630 ]

Jacques Le Roux commented on OFBIZ-3920:
----------------------------------------

Cool, thanks Nicolas!

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3920:
--------------------------------------

    Assignee: Jacques Le Roux

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912901#action_12912901 ]

Jacques Le Roux commented on OFBIZ-3920:
----------------------------------------

Actually we had a discussion with Nicolas, and it's not exactly the same problem, OFBIZ -2282 seems harder to fix... but still doable...

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912904#action_12912904 ]

Nicolas Malin commented on OFBIZ-3920:
--------------------------------------

Jacques, I haven't time to fixed it now, but I promise , ASAP

Nicolas

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912911#action_12912911 ]

Jacques Le Roux commented on OFBIZ-3920:
----------------------------------------

No worries Nicolas, there is no hurry.

Thanks

> HtmlFormRenderer : with attribute skip-start, lookup fields are broken
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3920
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: skipStartWithLookup.patch
>
>
> When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
> A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.
> I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated ;)
> Nicolas

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.