[jira] Created: (OFBIZ-3928) Error while creating a facilityContactMech if no purpose is given

[Nicolas Malin (Jira)]

Error while creating a facilityContactMech if no purpose is given
-----------------------------------------------------------------

                 Key: OFBIZ-3928
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
         Environment: linux, ofbiz trunk
            Reporter: Gil Portenseigne


When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.

A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gil Portenseigne updated OFBIZ-3928:
------------------------------------

    Attachment: OFBIZ-3928.diff

The patch. Now test if contactMechPurposeTypeId is in parameters.

gil

> Error while creating a facilityContactMech if no purpose is given
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: linux, ofbiz trunk
>            Reporter: Gil Portenseigne
>         Attachments: OFBIZ-3928.diff
>
>
> When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
> The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.
> A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3928:
--------------------------------------

    Assignee: Jacques Le Roux

> Error while creating a facilityContactMech if no purpose is given
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: linux, ofbiz trunk
>            Reporter: Gil Portenseigne
>            Assignee: Jacques Le Roux
>         Attachments: OFBIZ-3928.diff
>
>
> When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
> The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.
> A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3928.
----------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Gil,

Yes it makes sense indeed if we don't want to change the service definition (ie make contactMechPurposeTypeId mandatory). And to answer your question, it's not a contact mech which is created but a FacilityContactMechPurpose and of course there contactMechPurposeId is part of the primary key (hence its name BTW).

Your patch is in trunk at r995453  

> Error while creating a facilityContactMech if no purpose is given
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: linux, ofbiz trunk
>            Reporter: Gil Portenseigne
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3928.diff
>
>
> When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
> The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.
> A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907650#action_12907650 ]

Gil Portenseigne commented on OFBIZ-3928:
-----------------------------------------

Thanks,

Yes you are right for FacilityContactMechPurpose creation, i meant after creating a contactMech the association with a purpose was mandatory without this patch, and that surprised me.

Thank you for taking care of it.

gil

> Error while creating a facilityContactMech if no purpose is given
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: linux, ofbiz trunk
>            Reporter: Gil Portenseigne
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3928.diff
>
>
> When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
> The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.
> A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907670#action_12907670 ]

Jacques Le Roux commented on OFBIZ-3928:
----------------------------------------

Sure, it's an oversigh

> Error while creating a facilityContactMech if no purpose is given
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: linux, ofbiz trunk
>            Reporter: Gil Portenseigne
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3928.diff
>
>
> When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
> The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.
> A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907670#action_12907670 ]

Jacques Le Roux edited comment on OFBIZ-3928 at 9/9/10 12:22 PM:
-----------------------------------------------------------------

Sure, it's an oversight

EDIT=======TYPO=====

      was (Author: jacques.le.roux):
    Sure, it's an oversigh
 

> Error while creating a facilityContactMech if no purpose is given
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3928
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3928
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: linux, ofbiz trunk
>            Reporter: Gil Portenseigne
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3928.diff
>
>
> When creating a new facility contactMech, a facilityContactMechPurpose is automatically created, even if there is no contactMechPurposeTypeId is given in parameters.
> The problem is that its impossible to create a contact mech without purpose (is that normal ?), and contactMechPurposeTypeId is optional in service parameters.
> A patch is povided to correct the issue

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.