[jira] Created: (OFBIZ-3965) Ecommerce Customer Request has error.

[Nicolas Malin (Jira)]

Ecommerce Customer Request has  error.
--------------------------------------

                 Key: OFBIZ-3965
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/ecommerce
    Affects Versions: SVN trunk
         Environment: https://demo-stable.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
            Reporter: BJ Freeman
             Fix For: SVN trunk


login from ecomerce as DemoCustomer
click on
Create Customer Request
put in product #  WG-1111
click on Add to cart
Following Errors Occurred:

Customer Request should have a 'Name' if not in the draft status


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-3965:
------------------------------

    Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart  (was: https://demo-stable.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart)

corrected URL

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>             Fix For: SVN trunk
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916246#action_12916246 ]

Jacques Le Roux commented on OFBIZ-3965:
----------------------------------------

Looks like it's related to http://svn.apache.org/viewvc?rev=924647&view=rev. But not sure, just found, not digged in...

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>             Fix For: SVN trunk
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916285#action_12916285 ]

BJ Freeman commented on OFBIZ-3965:
-----------------------------------

Thanks will check out.

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>             Fix For: SVN trunk
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916316#action_12916316 ]

BJ Freeman commented on OFBIZ-3965:
-----------------------------------

so far it looks like the CreateRequest has been taken out of Ecommerce entirely.
I am still tracing code for CreateRequestfromCart.
I notice that upadateReqquest  is used but find  no CreateRequest.

this is more complicated that a single patch mistake.
going to ask hans to review , since he knows where he was going with this.

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>             Fix For: SVN trunk
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-3965:
-------------------------------

    Attachment: req.diff

We decided that a customer request needs a name of the request when it is not in the draft status.

I try to find the 'create customer request' option in e-commerce but i cannot find it.

Attached a diff file which could solve the problem, but could not test it. of course need internationalisation.

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>             Fix For: SVN trunk
>
>         Attachments: req.diff
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3965.
----------------------------------

         Assignee: Hans Bakker
    Fix Version/s: Release Branch 10.04
       Resolution: Fixed

Thanks BJ, Hans,

Hans your modified patch is in trunk at r1002963, R10.04 at r1002968

I provided the i18n, but weirdly it always renders in English (I tested in French and double-checked the labels I created)

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>            Assignee: Hans Bakker
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: req.diff
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916416#action_12916416 ]

Jacques Le Roux commented on OFBIZ-3965:
----------------------------------------

BTW for the 18n issue I thought it could be due to the fact that we switch to https and orde component. But I checked, on the ERP side I was also in French. I did not track it at this stage and gave up :/

> Ecommerce Customer Request has  error.
> --------------------------------------
>
>                 Key: OFBIZ-3965
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3965
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/createCustRequestFromCart
>            Reporter: BJ Freeman
>            Assignee: Hans Bakker
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: req.diff
>
>
> login from ecomerce as DemoCustomer
> click on
> Create Customer Request
> put in product #  WG-1111
> click on Add to cart
> Following Errors Occurred:
> Customer Request should have a 'Name' if not in the draft status

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.