OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3966) Collection task for application jQuery Migration

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3966) Collection task for application jQuery Migration

Collection task for application jQuery Migration
------------------------------------------------

Key: OFBIZ-3966
URL: https://issues.apache.org/jira/browse/OFBIZ-3966
Project: OFBiz
Issue Type: Sub-task
Components: ALL COMPONENTS
Affects Versions: jQuery
Reporter: Sascha Rodekamp
Fix For: jQuery

Hi,
here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
There is also a uiLabel update, i hope you can apply the patch.

Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3966) Collection task for application jQuery Migration

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3966:
-----------------------------------

Attachment: OFBIZ-3966_CommonDependentDropdownMigration.patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3966:
--------------------------------------

Assignee: Jacques Le Roux

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3966.
----------------------------------

Resolution: Fixed

Thanks Sascha,

Well done, your patches are committed at r1003949 + r1003957

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917329#action_12917329 ]

Jacques Le Roux commented on OFBIZ-3966:
----------------------------------------

When reviewing I just wondered about a point. It's not related to you work and was already existing. It's this snippet

{code}
var pars = 'templateGroupId='+templateGroupId+'&productStoreId='+productStoreId+'&pkCategoryId='+pkCategoryId;
var url = '<@ofbizUrl>ebayAdItemTemplate</@ofbizUrl>';

jQuery.ajax({
url: url,
type: "GET",
{code}

Is there any issues with that? Because we have a get request, with params in the URL, calling a service. I thought the framework would complain about a security issue. But I'm maybe missing something related to the GET Ajax query not really passing those parameters in the URL?

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917330#action_12917330 ]

Jacques Le Roux commented on OFBIZ-3966:
----------------------------------------

At r1003959 I have replaced last
<a href="javascript:$
by
<a href="javascript:document.getElementById

We are clear with that pattern now :)

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917331#action_12917331 ]

Sascha Rodekamp commented on OFBIZ-3966:
----------------------------------------

Hi Jacques,
hm i set it to GET because in the previous code, there was a GET too. So i thought it have to be a GET :-). If we run into an issue we should change it to POST i think, to be on the save side.

Arg i missed one $, thanks for changing ;)

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3966) Collection task for application jQuery Migration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917332#action_12917332 ]

Jacques Le Roux commented on OFBIZ-3966:
----------------------------------------

Actually completed at r1003960. I forgot to save changes made by hand :/

> Collection task for application jQuery Migration
> ------------------------------------------------
>
> Key: OFBIZ-3966
> URL: https://issues.apache.org/jira/browse/OFBIZ-3966
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Affects Versions: jQuery
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-3966_CommonDependentDropdownMigration.patch, OFBIZ-3966_CommonUiLabels.patch, OFBIZ-3966_EbayApplicationMigration.patch, OFBIZ-3966_EbayStoreApplicationMigration.patch, OFBIZ-3966_ExampleApplicationMigration.patch, OFBIZ-3966_GoogleApplicationMigration.patch, OFBIZ-3966_MarketingApplicationMigration.patch, OFBIZ-3966_OrderApplicationMigration.patch, OFBIZ-3966_PartyApplicationMigration.patch, OFBIZ-3966_ProductApplicationMigration.patch, OFBIZ-3966_ProjectManagerApplicationMigration.patch, OFBIZ-3966_TestToolsApplicationMigration.patch
>
>
> Hi,
> here are some patch files for different components, the most changes are small once. I found it easier to create one task to maintain them.
> There is also a uiLabel update, i hope you can apply the patch.
> Have a good day Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.