[jira] Created: (OFBIZ-3974) Wrong tax calculating

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3974) Wrong tax calculating

Nicolas Malin (Jira)
Wrong tax calculating
----------------------

                 Key: OFBIZ-3974
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3974
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Sascha Rodekamp
            Priority: Critical
             Fix For: SVN trunk
         Attachments: OFBIZ-3974_TaxAuthorityServices.java.patch

Hi,
another Patch for today,
we had problems with the taxation. When we configure our shop with "show prices with vat tax == N". Means our product price is stored  with vat in the db.
During the checkout process ofbiz doesn't differs between the  "show prices with vat tax" options when calculating the taxes. The result is a wrong order amount!

 i.e.
A product is stored with a price of: 100€ (Gross price).
Vat (19% in Germany) should be 15,97€

But ofbiz tread this price like a net price.

This patch differs the calculating. And looks what is configured in the shop setup.

Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3974) Wrong tax calculating

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3974:
-----------------------------------

    Attachment: OFBIZ-3974_TaxAuthorityServices.java.patch

> Wrong tax calculating
> ----------------------
>
>                 Key: OFBIZ-3974
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3974
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3974_TaxAuthorityServices.java.patch
>
>
> Hi,
> another Patch for today,
> we had problems with the taxation. When we configure our shop with "show prices with vat tax == N". Means our product price is stored  with vat in the db.
> During the checkout process ofbiz doesn't differs between the  "show prices with vat tax" options when calculating the taxes. The result is a wrong order amount!
>  i.e.
> A product is stored with a price of: 100€ (Gross price).
> Vat (19% in Germany) should be 15,97€
> But ofbiz tread this price like a net price.
> This patch differs the calculating. And looks what is configured in the shop setup.
> Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3974) Wrong tax calculating

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916922#action_12916922 ]

David E. Jones commented on OFBIZ-3974:
---------------------------------------

You wrote: "When we configure our shop with "show prices with vat tax == N". Means our product price is stored with vat in the db. "

Actually, it does NOT mean that, it simply means that tax should not be added to prices for display.

There is no setting in OFBiz right now to say that taxes are already included in the prices in the DB. In other words, the OFBiz tax code always assumes that the prices in the db do NOT have taxes included.

The problem with making the change you propose is that non-VAT jurisdictions will have this set to N, and after your change the code would assume that taxes are already included in prices, which they are not, and it would mess up the total in the other direction.

If you want to support prices that already have VAT included in them you'll have to add a new setting and write code for that. BTW, keep in mind that with this you'll have to have different sets of prices for different jurisdictions because of possibly different tax rates in each.

> Wrong tax calculating
> ----------------------
>
>                 Key: OFBIZ-3974
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3974
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3974_TaxAuthorityServices.java.patch
>
>
> Hi,
> another Patch for today,
> we had problems with the taxation. When we configure our shop with "show prices with vat tax == N". Means our product price is stored  with vat in the db.
> During the checkout process ofbiz doesn't differs between the  "show prices with vat tax" options when calculating the taxes. The result is a wrong order amount!
>  i.e.
> A product is stored with a price of: 100€ (Gross price).
> Vat (19% in Germany) should be 15,97€
> But ofbiz tread this price like a net price.
> This patch differs the calculating. And looks what is configured in the shop setup.
> Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3974) Wrong tax calculating

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916937#action_12916937 ]

Jacques Le Roux commented on OFBIZ-3974:
----------------------------------------

BTW, there have been a lot of discussions about that in the past... You may found interesting information at https://cwiki.apache.org/confluence/display/OFBIZ/VAT

> Wrong tax calculating
> ----------------------
>
>                 Key: OFBIZ-3974
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3974
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3974_TaxAuthorityServices.java.patch
>
>
> Hi,
> another Patch for today,
> we had problems with the taxation. When we configure our shop with "show prices with vat tax == N". Means our product price is stored  with vat in the db.
> During the checkout process ofbiz doesn't differs between the  "show prices with vat tax" options when calculating the taxes. The result is a wrong order amount!
>  i.e.
> A product is stored with a price of: 100€ (Gross price).
> Vat (19% in Germany) should be 15,97€
> But ofbiz tread this price like a net price.
> This patch differs the calculating. And looks what is configured in the shop setup.
> Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3974) Wrong tax calculating

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916969#action_12916969 ]

Sascha Rodekamp commented on OFBIZ-3974:
----------------------------------------

Hey David, hey Jacques

Thanks David for clarifying. You're absolutely right there are several other places. Maybe i've to rethink my purposes and reading the wiki entry (thanks Jacques) :-).

I think this task can be closed than!

Have a good day
regards
Sascha

> Wrong tax calculating
> ----------------------
>
>                 Key: OFBIZ-3974
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3974
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3974_TaxAuthorityServices.java.patch
>
>
> Hi,
> another Patch for today,
> we had problems with the taxation. When we configure our shop with "show prices with vat tax == N". Means our product price is stored  with vat in the db.
> During the checkout process ofbiz doesn't differs between the  "show prices with vat tax" options when calculating the taxes. The result is a wrong order amount!
>  i.e.
> A product is stored with a price of: 100€ (Gross price).
> Vat (19% in Germany) should be 15,97€
> But ofbiz tread this price like a net price.
> This patch differs the calculating. And looks what is configured in the shop setup.
> Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3974) Wrong tax calculating

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3974.
----------------------------------

      Assignee: David E. Jones
    Resolution: Invalid

> Wrong tax calculating
> ----------------------
>
>                 Key: OFBIZ-3974
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3974
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: David E. Jones
>            Priority: Critical
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3974_TaxAuthorityServices.java.patch
>
>
> Hi,
> another Patch for today,
> we had problems with the taxation. When we configure our shop with "show prices with vat tax == N". Means our product price is stored  with vat in the db.
> During the checkout process ofbiz doesn't differs between the  "show prices with vat tax" options when calculating the taxes. The result is a wrong order amount!
>  i.e.
> A product is stored with a price of: 100€ (Gross price).
> Vat (19% in Germany) should be 15,97€
> But ofbiz tread this price like a net price.
> This patch differs the calculating. And looks what is configured in the shop setup.
> Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.