[jira] Created: (OFBIZ-3978) Ecommerce Migration

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3978:
-----------------------------------

    Attachment: OFBIZ-3978_ProductImageHoverFix.patch

update for the product hover patch, i added two files to patch (remove a seed entry and load of prototype.js)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919906#action_12919906 ]

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Thanks Sascha,

Your (slightly modified, I re-sequenced sequenceId in seed) patch is commited at r1021429  

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919914#action_12919914 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

ok :) i missed ;) thanks

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924623#action_12924623 ]

Jonatan Soto commented on OFBIZ-3978:
-------------------------------------

I noticed that the old validation messages are no longer used with this jquery validator plugin. However, the plugin generates the label including a default message if no custom message is specified. AFAIK, custom messages should be defined in the validate method, which in our case, is often called inside a .js (ready function). The problem is with i18n of the error messages. I'm working with it in order to keep as much as possible the prototype behaviour, where the label was rendered in the ftl and the old validator just made it visible or not when an error ocurred. To do that, I'm using the documentation of the plugin located in the jquery site http://docs.jquery.com/Plugins/Validation/validate

Please let me know if someone is working on this to avoid overlap.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924876#action_12924876 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

Hi Jonatan,
you can set the validation message in you're specific FTL file and i18n them (that is good for having only the messages on the page which are really needed for the specific site to minimize traffic). Otherwise it's possible to have a seperate ftl file where all messages are defined and which is included to you're specific site.

Here is the right link to the plugin [http://docs.jquery.com/Plugins/Validation]
Have a look under the tobic validator.

Thanks for yxou're effort
and have a good day
Sascha

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924950#action_12924950 ]

Jonatan Soto commented on OFBIZ-3978:
-------------------------------------

Hi Sascha,

This is how I solved the issue, I just added this to the validate method in profile js. The spans with the error messages are no longer needed. I am totally agree, generated messages minimizes traffic.

    jQuery("#newUserFormStep").validate({
            errorPlacement: function(error, element) {                  
                   error.appendTo( element.parent("div").find("label") );
      },
                   errorClass: "errorMessage"              
          });

So to i18n them I just created an external ftl file and put it in the main-decorator or whatever is desired (even in profile.js, I think it will work too)

<script>
        jQuery.validator.messages.required = '${uiLabelMap.CommonRequired}';
        jQuery.validator.messages.email = '${uiLabelMap.CommonRequired}';
        jQuery.validator.messages.digits = '${uiLabelMap.CommonRequired}';
</script>

Have in mind that the input element can declare which validation methods are triggered in the class attribute, but I couldn't make it work for validations that requires a parameter, like minlength(length). I will investigate further on this, but I think it can be done if it is defined inside the validate method.


Sorry for don't create a patch, but as I mentioned in the ML I am working in a step by step wizard for the new customer screen, which is already done. So if it is ok to you, I can upload a patch including all the changes I've done.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924970#action_12924970 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

Jey Jonatan, that would be great. Take you're time to finish the worg .. sounds good to me :)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925320#action_12925320 ]

Jonatan Soto commented on OFBIZ-3978:
-------------------------------------

I found an error in applications/order/webapp/ordermgr/images/js/geoAutoCompleter.js on getAssociatedStateList function.

jQuery.ajax({
        url: requestToSend,
        sync: false,
        type: "POST",
        data: {countryGeoId: countryGeoId},
        success: function(data) {

sync:false should be replaced by async:true. Setting sync:false causes unexpected behaviour in the server side. ie: the tenantId in the Delegator was null and perhaps another weird things can happen.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925337#action_12925337 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

jep that's right "sync:false" is prototype fashion, For jQuery it should be "async: true" ;)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925346#action_12925346 ]

Jonatan Soto commented on OFBIZ-3978:
-------------------------------------

Sorry, I was wrong about my assumptions. It's true that the sync:false must be replaced but it wasn't the cause that makes the delegator create another instance.

This is the code in the same method that causes the error:

if (jQuery('#orderViewed')) {
        requestToSend = "/ordermgr/control/getAssociatedStateList"
}

Every time the request sent is /ordermgr/control/getAssociatedStateList. For now I commented it.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.