[jira] Created: (OFBIZ-3978) Ecommerce Migration

[Nicolas Malin (Jira)]

Ecommerce Migration
-------------------

                 Key: OFBIZ-3978
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
             Project: OFBiz
          Issue Type: Sub-task
          Components: specialpurpose/ecommerce
            Reporter: Ankit Jain


All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917522#action_12917522 ]

Ankit Jain commented on OFBIZ-3978:
-----------------------------------

This task is for ecommerce js migration.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3978:
------------------------------

    Attachment: CheckoutProcess.patch

Hi Folks,

Here is the patch for CheckoutProcess.js.

HTH
Ankit Jain :)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>         Attachments: CheckoutProcess.patch
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917542#action_12917542 ]

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Hi Ankit,

There  is an issue in your patch. In Jquery  
{code}
if (jQuery(selector)) {
{code}
does not work you have to check if it exists. The easier is to use
{code}
if (jQuery(selector).lenght) {
{code}

We would create an exist() function. Its code would be

{code}
jQuery.fn.exists = function(){return jQuery(this).length}
{code}
and would be used like that
{code}
if (jQuery(selector).exists()) {
   ...
}
{code}

But I'm not sure it's worth it (lenght is not intuitive but smaller than exists()). To be discussed...

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>         Attachments: CheckoutProcess.patch
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917551#action_12917551 ]

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Anyway the exists function is a waste of cycles, forget it... ;)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>         Attachments: CheckoutProcess.patch
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3978:
------------------------------

    Attachment: CheckoutProcess.patch

Hi Jacques,

I dont think it will show any kind of error but we can handle the exception as a jQuery selector always returns an object rather it exists or not.

We dont need to create any exist() function we can do it by checking the value greater then zero or not. So i used the .length to handle it and also updated the patch.

Thanks for reminding!

Ankit Jain :)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3978:
-----------------------------------

    Attachment: OFBIZ-3978_ecommerceMigration.patch
                smoothness.zip

Hi Jacques & Ankit,

here are the migration patch for the other ecommerce files, i try to migrate and clean up the JS code (and i deleted the not used parts, it's worth to keep them :-)).

To apply
* extract the zip file and copy the extracted filed in /framework/images/webapp/images/jquery/ui/css/smoothness
* apply the patch

Ankit thanks for you're patch i will review it now.
Cheers
Sascha

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3978:
--------------------------------------

    Assignee: Jacques Le Roux

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917946#action_12917946 ]

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Sascha,

I reviewed Ankit's patch yesterday evening but did not committed it yet. Here are my comments so far

I simply
* replaced .length > 0 by .length the > 0 part is not needed
* used if (jQuery('#initializedCompletedCartDiscount').length && jQuery('#initializedCompletedCartDiscount').val() == 0) { instead of
if (jQuery('#initializedCompletedCartDiscount') !=undefined && jQuery('#initializedCompletedCartDiscount').val() == 0) { which is not correct
* I noticed harcoded  "Attn: " and "Expires:" but gave up to change them, perhaps someone will clear them one day...

I hope I did not forget anything because I did not take the time to test, I only reviewed and it looked fine to me. I wonder though if we could not have refactored this file, some snippets seem redundant...

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917950#action_12917950 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

Jacques,
great, thanks.
There are some form validations which are not migrated correctly and the browser will throw an error. I handle that. And submit a working patch ASAP

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3978:
-----------------------------------

    Attachment: OFBIZ-3978_onePageCheckOutMigration.patch

Hi,
here are Ankits patch with a few fixed, the checkout process works now. But i have a little layout buck in step 4 billing.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918002#action_12918002 ]

Ankit Jain commented on OFBIZ-3978:
-----------------------------------

Thanks Sascha & Jacques. :)

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3978:
-----------------------------------

    Attachment: OFBIZ-3978_onePageCheckOutMigration.patch

Fixed the Layout Bug in Step 4

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3978:
-----------------------------------

    Attachment: OFBIZ-3978_onePageCheckOutMigration.patch

Hi Sascha,

I have reviewed your patch, and changed a few minor things in the patch:
* used length instead of length > 0
* removed usless commented out code

It looked good to me, but when I tested it did not work (stuck when trying to get to step 2). Did you try, may I miss something ?

BTW the trunk version works but looks really ugly (on Windows/FF)

I attach my slightly modified patch, and give up for now...

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919626#action_12919626 ]

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Hi Sascha,

Actually I forgot (missed) to apply the OFBIZ-3978_ecommerceMigration.patch. So with it it works almost well. There is an issue with the popup class, see for instance in main feature screen (main screen). If you remove the class it works but then we loose the popup effect.

I have committed the slightly modified patches (see above) at r1006326  

BTW I'm not sure what you meant with
{quote}
i deleted the not used parts, it's worth to keep them
{quote}
I guess you spoke about the other patch. I did not remove any lines there. I have some questions:
# I saw that you used the new screens in CustomerScreens.xml. Then why not removing the old ones, are there some issues?
# Why did you comment out submitEditBillToPostalAddress snippet at bottom of EditBillToAddress.ftl, related to point 1?
# Same for submitEditPostalAddress_${contactMech.contactMechId} in EditPostalAddress.ftl
# Same for submitEditShipToPostalAddress in EditShipToAddress.ftl
# in NewCustomer.ftl you removed the required class for some fields, should we not keep it for billToContactNumber and shipToContactNumber?
# in profile.js why did you remove validBillingAddress?

I did not close because we need to check more and also ans mostly because I'd like to commit OFBIZ-2000 (new) patch and migrate it before closing here, maybe it's redundant wit current code though, I did not check.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919745#action_12919745 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

Hi Jacques,
thanks for you're work. To you're questions:

1.) Yes why not, it seems that everything is working in the "new" Screens. I didn't know what to do with the old onces, so i comment them.
2.) I used jQuery Buttons in the Dialogs which Submits the for or Close the dialog. So these Buttons are not needed any more.
3.) see 2.)
4.) see 4.)  :-)
5.) i removed the "required" classes because the numbers are validated in a separate method which validates all three input at once. The validation plugins otherwise validate every input field for it's own, the result is a validation error and each field when they are empty. The separate method only shows one failure message.
6.) The validBillingAddress checks only if the fields are empty. I used the jQuery validation plugin for this purpose. So the function can be deleted.

Cheers

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919758#action_12919758 ]

Jacques Le Roux commented on OFBIZ-3978:
----------------------------------------

Thanks to clarify Sascha,

# I removed it
I learnt more about validate plugin yesterday.

Rishi told me that he will not work on OFBIZ-2000 till next weekend, I had a closer look and yes it's complementary. When I will have commited I will migrate it to jQuery.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919772#action_12919772 ]

Sascha Rodekamp commented on OFBIZ-3978:
----------------------------------------

Ok Jacques thanks.
Can you say a few words more about the popup issue.
I have no problems with the popups on the main page. They appear when i hover a product image and they disappear when the mouse leaves the image.

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3978:
-----------------------------------

    Attachment: popup issue.jpg

Ah! this is weird, here is what I get (tried in FF and Chrome on XP). Could I have missed something?

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3978:
-----------------------------------

    Attachment: OFBIZ-3978_ProductImageHoverFix.patch

My fault,
here is the missing piece. Now the Image Preview Hover should work

Cheers
Sascha

> Ecommerce Migration
> -------------------
>
>                 Key: OFBIZ-3978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3978
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/ecommerce
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>         Attachments: CheckoutProcess.patch, CheckoutProcess.patch, OFBIZ-3978_ecommerceMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_onePageCheckOutMigration.patch, OFBIZ-3978_ProductImageHoverFix.patch, popup issue.jpg, smoothness.zip
>
>
> All ecommerce js migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.