[jira] Created: (OFBIZ-4023) Wrong product displayed as associated product

[Nicolas Malin (Jira)]

Wrong product displayed as associated product
---------------------------------------------

                 Key: OFBIZ-4023
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4023
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/ecommerce
    Affects Versions: SVN trunk
         Environment: Rev 1035845
            Reporter: Anne Jessel
            Priority: Minor


To reproduce:

- add two associated products to a main product, both with "Complementary or Cross-Sell" association type

- view the main product in ecommerce

Expected behaviour: the two associated products are listed near the bottom of the page

Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product.

The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated.

I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anne Jessel updated OFBIZ-4023:
-------------------------------

    Attachment: OFBIZ-4023_Wrong-product-displayed-as-assoc-product.patch

> Wrong product displayed as associated product
> ---------------------------------------------
>
>                 Key: OFBIZ-4023
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4023
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Rev 1035845
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4023_Wrong-product-displayed-as-assoc-product.patch
>
>
> To reproduce:
> - add two associated products to a main product, both with "Complementary or Cross-Sell" association type
> - view the main product in ecommerce
> Expected behaviour: the two associated products are listed near the bottom of the page
> Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product.
> The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated.
> I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933328#action_12933328 ]

David - DiSiD Technologies commented on OFBIZ-4023:
---------------------------------------------------

This bug affects the "OFBiz Release Branch 10.04" too.

> Wrong product displayed as associated product
> ---------------------------------------------
>
>                 Key: OFBIZ-4023
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4023
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Rev 1035845
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4023_Wrong-product-displayed-as-assoc-product.patch
>
>
> To reproduce:
> - add two associated products to a main product, both with "Complementary or Cross-Sell" association type
> - view the main product in ecommerce
> Expected behaviour: the two associated products are listed near the bottom of the page
> Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product.
> The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated.
> I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4023.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

Thanks Anne,

Your patch is in trunk at r1042411, R10.04 at r1042414, R9.04 at r1042418  

> Wrong product displayed as associated product
> ---------------------------------------------
>
>                 Key: OFBIZ-4023
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4023
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>         Environment: Rev 1035845
>            Reporter: Anne Jessel
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4023_Wrong-product-displayed-as-assoc-product.patch
>
>
> To reproduce:
> - add two associated products to a main product, both with "Complementary or Cross-Sell" association type
> - view the main product in ecommerce
> Expected behaviour: the two associated products are listed near the bottom of the page
> Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product.
> The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated.
> I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.